Bug#885414: base-files: lack of quoting in shell variable expansions in /etc/profile

2024-05-04 Thread Santiago Vila
El 4/5/24 a las 16:48, ca...@allfreemail.net escribió: Package: base-files Version: 13.2 Followup-For: Bug #885414 Dear Maintainer, I'd like to point out that the "fix" doesn't actually fix the reported problem. Variables that must be quoted in order to have a well-defined behavior are still

Bug#885414: base-files: lack of quoting in shell variable expansions in /etc/profile

2024-05-04 Thread cacin
Package: base-files Version: 13.2 Followup-For: Bug #885414 Dear Maintainer, I'd like to point out that the "fix" doesn't actually fix the reported problem. Variables that must be quoted in order to have a well-defined behavior are still not quoted, namely the "$i" is not quoted. See the very

Bug#885414: base-files: lack of quoting in shell variable expansions in /etc/profile

2024-05-03 Thread Santiago Vila
[ Replying to both ] Richard Lewis wrote: On Thu, 18 Apr 2024, 23:18 Santiago Vila, mailto:sanv...@debian.org>> wrote: (I'd like to avoid spamming the users with non-important information) [...] - NEWS.Debian is "opt-in": if you install apt-listchanges you'll see NEWS.Debian, but that

Bug#885414: base-files: lack of quoting in shell variable expansions in /etc/profile

2024-04-20 Thread Vincent Lefevre
On 2024-04-20 19:40:16 +0100, Richard Lewis wrote: > fwiw my understanding is that release-notes should be used less often, than > NEWS.Debian because > - it only covers stable-to-stable upgrades (i doubt many unstable users > read it at all - certainly at the moment i don't think there is any

Bug#885414: base-files: lack of quoting in shell variable expansions in /etc/profile

2024-04-20 Thread Richard Lewis
On Thu, 18 Apr 2024, 23:18 Santiago Vila, wrote: > El 18/4/24 a las 22:17, Richard Lewis escribió: > >>> '^[a-zA-Z0-9_][a-zA-Z0-9._-]*\.sh$' > >> > >> Hi. I confirm that this is appropriate for what we distribute: > > > > What about local scripts added by users (which this change might > >

Bug#885414: base-files: lack of quoting in shell variable expansions in /etc/profile

2024-04-18 Thread Santiago Vila
El 18/4/24 a las 22:17, Richard Lewis escribió: '^[a-zA-Z0-9_][a-zA-Z0-9._-]*\.sh$' Hi. I confirm that this is appropriate for what we distribute: What about local scripts added by users (which this change might prevent loading): perhaps a NEWS.Debian entry would suffice? Are there any

Bug#885414: base-files: lack of quoting in shell variable expansions in /etc/profile

2024-04-18 Thread Richard Lewis
> >'^[a-zA-Z0-9_][a-zA-Z0-9._-]*\.sh$' > > Hi. I confirm that this is appropriate for what we distribute: What about local scripts added by users (which this change might prevent loading): perhaps a NEWS.Debian entry would suffice?

Bug#885414: base-files: lack of quoting in shell variable expansions in /etc/profile

2024-04-18 Thread Santiago Vila
tags 885414 - help thanks Vincent Lefevre wrote: '^[a-zA-Z0-9_][a-zA-Z0-9._-]*\.sh$' Hi. I confirm that this is appropriate for what we distribute: wget -q -O - http://deb.debian.org/debian/dists/unstable/main/Contents-amd64.gz | gzip -d | awk '/etc\/profile.d/ { print $1 }' yields:

Bug#885414: base-files: lack of quoting in shell variable expansions in /etc/profile

2024-04-18 Thread Santiago Vila
So I think that the --regex argument should be '^[a-zA-Z0-9_][a-zA-Z0-9._-]*\.sh$' Thanks a lot! Yes, this is the kind of feedback I need. Next I'd like to match such regexp with the files in /etc/profile.d that may be obtained from the Contents.gz file in the archives to be sure that the

Bug#885414: base-files: lack of quoting in shell variable expansions in /etc/profile

2024-04-18 Thread Vincent Lefevre
Hi, On 2024-04-17 13:55:31 +0200, Santiago Vila wrote: > The problem, more than lack of quoting, is that there is no specification > anywhere about what should be allowed and what should not. > > But we are not late to begin such specification. > Here is my current plan: > > --- a/share/profile

Bug#885414: base-files: lack of quoting in shell variable expansions in /etc/profile

2024-04-17 Thread Santiago Vila
tags 885414 + help thanks Hello. Sorry for the late reply. The problem, more than lack of quoting, is that there is no specification anywhere about what should be allowed and what should not. But we are not late to begin such specification. Here is my current plan: --- a/share/profile +++

Bug#885414: base-files: lack of quoting in shell variable expansions in /etc/profile

2023-07-10 Thread soh08a+cbo9nqx75gwzw
Package: base-files Version: 12.4 Followup-For: Bug #885414 Dear Maintainer, I agree that spaces in filenames are a bad idea, and a policy should be made against that, however scripts should still handle spaces in filenames gracefully (in this case by quoting variables properly) instead of

Bug#885414: base-files: lack of quoting in shell variable expansions in /etc/profile

2023-07-10 Thread Santiago Vila
El 9/7/23 a las 0:54, so54p1+4s6g31jabjix4@cs.email escribió: Package: base-files Version: 12.4 Followup-For: Bug #885414 Dear Maintainer, is there any progress on this issue? It causes issues when files with spaces are placed in /etc/profile.d/ Hello. There is no "progress" because I'm not

Bug#885414: base-files: lack of quoting in shell variable expansions in /etc/profile

2023-07-08 Thread so54p1+4s6g31jabjix4
Package: base-files Version: 12.4 Followup-For: Bug #885414 Dear Maintainer, is there any progress on this issue? It causes issues when files with spaces are placed in /etc/profile.d/

Bug#885414: base-files: lack of quoting in shell variable expansions in /etc/profile

2018-01-15 Thread Greg Wooledge
On Sun, Jan 14, 2018 at 01:35:30AM +0100, Santiago Vila wrote: > On Tue, 26 Dec 2017, Greg Wooledge wrote: > > > -if [ -r $i ]; then > > - . $i > > +if [ -r "$i" ]; then > > + . "$i" > > Thanks for the report. > > Before I just apply the patch: Is there a standard somewhere >

Bug#885414: base-files: lack of quoting in shell variable expansions in /etc/profile

2018-01-13 Thread Santiago Vila
On Tue, 26 Dec 2017, Greg Wooledge wrote: > -if [ -r $i ]; then > - . $i > +if [ -r "$i" ]; then > + . "$i" Thanks for the report. Before I just apply the patch: Is there a standard somewhere specifying what kind of filenames are allowed in /etc/profile.d?

Bug#885414: base-files: lack of quoting in shell variable expansions in /etc/profile

2017-12-26 Thread Greg Wooledge
Package: base-files Version: 9.9+deb9u3 Severity: normal Tags: patch --- /usr/share/base-files/profile 2016-03-04 06:00:00.0 -0500 +++ /tmp/profile2017-12-26 15:49:08.839804524 -0500 @@ -26,8 +26,8 @@ if [ -d /etc/profile.d ]; then for i in /etc/profile.d/*.sh; do -