Bug#490082: ripit: Problems with lame --genre-list

2008-09-28 Thread Jakub Lucký
Hi

There is still the same bug there, I can repeat it every time...
actually, nothing can be ripped at all.

But, the patch is working (on Debian Sid definetely)
Submitting it will be great

Jakub Lucký


Bug#490082: ripit: Problems with lame --genre-list

2008-07-09 Thread Michael Ott
Package: ripit
Version: 3.6.0-1
Severity: normal

After updating lame to version 3.98 ripit does not work longer.

I have to add this patch:
--- /usr/bin/ripit.orig 2008-07-09 19:55:18.0 +0200
+++ /usr/bin/ripit  2008-07-09 19:43:21.0 +0200
@@ -3399,7 +3398,7 @@
 
# If Lame is not used, don't die if ID3v2-tag is not compliant.
if($lameflag == 0) {
-  unless(log_system(lame --genre-list | grep -i \ $genre\$\  /dev/null 
)) {
+  unless(log_system(lame --genre-list 21 | grep -i \ $genre\$\  
/dev/null )) {
  print Genre $genre is not ID3v2 compliant!\n
 if($verbose = 1);
  print I continue anyway!\n\n if($verbose = 1);
@@ -3418,7 +3417,7 @@
 
# Check if (similar) genre exists. Enter a new one with interaction,
# or take the default one.
-   while(!log_system(lame --genre-list | grep -i \$genre\  /dev/null )) {
+   while(!log_system(lame --genre-list 21 | grep -i \$genre\  /dev/null 
)) {
   print Genre $genre is not ID3v2 compliant!\n if($verbose = 1);
   if($interaction == 1) {
  print Use \lame --genre-list\ to get a list!\n;
@@ -3438,7 +3437,7 @@
   return;
}
elsif($genre =~ /^\d+$/) {
-  $genre = `lame --genre-list | grep -i \'$genre\'`;
+  $genre = `lame --genre-list 21 | grep -i \' $genre \'`;
   chomp $genre;
}
else {
@@ -3450,10 +3449,10 @@
   # pop-like genres!
   # There will be a linebreak, if multiple possibilities found.
   my $ogenre = $genre;
-  $genre = `lame --genre-list | grep -i \'$genre\'`;
+  $genre = `lame --genre-list 21 | grep -i \'$genre\'`;
   chomp $genre;
   # Second we want THE original genre, if it precisly exists.
-  my $testgenre = `lame --genre-list | grep -i \'\^... $ogenre\$\'`;
+  my $testgenre = `lame --genre-list 21 | grep -i \'\^... $ogenre\$\'`;
   chomp $testgenre;
   $genre = $testgenre if($testgenre);
   # If we still have several genres:

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (700, 'unstable'), (650, 'testing'), (600, 'stable'), (1, 
'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.25 (PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages ripit depends on:
ii  cdparanoia   3.10.0+debian-1 audio extraction tool for sampling
ii  flac 1.2.1-1.2   Free Lossless Audio Codec - comman
ii  lame 3.98-0.0LAME Ain't an MP3 Encoder
ii  libcddb-get-perl 2.23-2.1read the CDDB entry for an audio C
ii  libwww-perl  5.812-1 WWW client/server library for Perl
ii  vorbis-tools 1.2.0-5 several Ogg Vorbis tools

ripit recommends no packages.

-- no debconf information



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]