Bug#687563: RFS: opengrm-ngram/1.0.3-1 [ITP] -- opengrm n-gram, library
* Giulio Paci giuliop...@gmail.com, 2013-04-09, 18:12: X: libngram0: shlib-calls-exit usr/lib/libngram.so.0.0.0 Do I understand correctly that this comes from libfst, and would have to be fixed there? I have not found any direct exit reference in libngram source code. So I checked libfst code and there are just a few calls: Thanks for the detailed analysis! 1) One is in FailedNewHandler() in src/lib/compat.cc. As far as I can tell this is only a convenience function to call exit and print an error message, to be used with std::set_new_handler() in applications. Yup, this fine; although I'm not sure how is it better than the default new-handler. :) 2) Some are in SetFlags() in src/lib/flags.cc. This seems a convenience function to be used at the begin of a program to parse flags, handle errors and exit if needed (I am not 100% sure anyway). It is also called by the deprecated similar convenience function InitFst(). This should be fine, too. 3) Another one is in LogMessage() in src/include/fst/log.h, when invoked with FATAL type. I think that's acceptable use of exit()... 4) TestProperties() in src/include/fst/test-properties.h, if FLAGS_fst_verify_properties is set, LogMessage(FATAL) may be called. 5) If FLAGS_fst_error_fatal is set all FSTERROR() calls results in a LogMessage(FATAL) call. ...but these two are worrisome. 1), 2), 4), 5) are not directly called in libngram. 3) is used several way in libngram instead. I am not sure about how to deal with this issue. OpenFST exit calls seem reasonable to me, while LOG(FATAL) calls in libngram seem not. Each side could be blamed: 1) OpenFST offers an inflexible logging-and-error-mechanisms, which is unsuitable for use in shared libraries; 2) OpenGrm-NGram uses this mechanisms. If OpenFST offered a way to plug in your own logging handler, it wouldn't be a problem at that OpenGrm-NGram uses LOG(FATAL). The application could install a handler that would throw an exception, or ignored the error, or exited with exit code more suitable for its needs. But anyway, we can worry about it later. I can upload the package as-is if you want. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#687563: RFS: opengrm-ngram/1.0.3-1 [ITP] -- opengrm n-gram, library
Il 11/04/2013 23:25, Jakub Wilk ha scritto: * Giulio Paci giuliop...@gmail.com, 2013-04-09, 18:12: X: libngram0: shlib-calls-exit usr/lib/libngram.so.0.0.0 Each side could be blamed: 1) OpenFST offers an inflexible logging-and-error-mechanisms, which is unsuitable for use in shared libraries; 2) OpenGrm-NGram uses this mechanisms. If OpenFST offered a way to plug in your own logging handler, it wouldn't be a problem at that OpenGrm-NGram uses LOG(FATAL). The application could install a handler that would throw an exception, or ignored the error, or exited with exit code more suitable for its needs. But anyway, we can worry about it later. I can upload the package as-is if you want. Please, upload it as-is. In the meanwhile I will inform both OpenFST and OpenGRM-NGram upstreams about the problem. Bests, Giulio. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#687563: RFS: opengrm-ngram/1.0.3-1 [ITP] -- opengrm n-gram, library
Lintian emits: X: libngram0: shlib-calls-exit usr/lib/libngram.so.0.0.0 Do I understand correctly that this comes from libfst, and would have to be fixed there? -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#687563: RFS: opengrm-ngram/1.0.3-1 [ITP] -- opengrm n-gram, library
Il 09/04/2013 14:57, Jakub Wilk ha scritto: Lintian emits: X: libngram0: shlib-calls-exit usr/lib/libngram.so.0.0.0 Do I understand correctly that this comes from libfst, and would have to be fixed there? I have not found any direct exit reference in libngram source code. So I checked libfst code and there are just a few calls: 1) One is in FailedNewHandler() in src/lib/compat.cc. As far as I can tell this is only a convenience function to call exit and print an error message, to be used with std::set_new_handler() in applications. 2) Some are in SetFlags() in src/lib/flags.cc. This seems a convenience function to be used at the begin of a program to parse flags, handle errors and exit if needed (I am not 100% sure anyway). It is also called by the deprecated similar convenience function InitFst(). 3) Another one is in LogMessage() in src/include/fst/log.h, when invoked with FATAL type. 4) TestProperties() in src/include/fst/test-properties.h, if FLAGS_fst_verify_properties is set, LogMessage(FATAL) may be called. 5) If FLAGS_fst_error_fatal is set all FSTERROR() calls results in a LogMessage(FATAL) call. 1), 2), 4), 5) are not directly called in libngram. 3) is used several way in libngram instead. I am not sure about how to deal with this issue. OpenFST exit calls seem reasonable to me, while LOG(FATAL) calls in libngram seem not. What is your opinion about this? Bests, Giulio. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#687563: RFS: opengrm-ngram/1.0.3-1 [ITP] -- opengrm n-gram, library
Il 06/04/2013 21:03, Jakub Wilk ha scritto: I see this in the build log: dpkg-shlibdeps: warning: symbol FLAGS_fst_default_cache_gc_limit used by debian/libngram0/usr/lib/libngram.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol FLAGS_fst_default_cache_gc used by debian/libngram0/usr/lib/libngram.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol FLAGS_fst_verify_properties used by debian/libngram0/usr/lib/libngram.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol FLAGS_v used by debian/libngram0/usr/lib/libngram.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol FLAGS_fst_error_fatal used by debian/libngram0/usr/lib/libngram.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol _ZN3fst13PropertyNamesE used by debian/libngram0/usr/lib/libngram.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol FLAGS_fst_compat_symbols used by debian/libngram0/usr/lib/libngram.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol _ZN3fst17ComposePropertiesEyy used by debian/libngram0/usr/lib/libngram.so.0.0.0 found in none of the libraries It looks like a violation of Policy §10.2: “shared libraries must be linked against all libraries that they use symbols from”. Indeed it was. I added a patch to fix this. Now autotools are run at build time, in order to use this patch. Bests, Giulio. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#687563: RFS: opengrm-ngram/1.0.3-1 [ITP] -- opengrm n-gram, library
I see this in the build log: dpkg-shlibdeps: warning: symbol FLAGS_fst_default_cache_gc_limit used by debian/libngram0/usr/lib/libngram.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol FLAGS_fst_default_cache_gc used by debian/libngram0/usr/lib/libngram.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol FLAGS_fst_verify_properties used by debian/libngram0/usr/lib/libngram.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol FLAGS_v used by debian/libngram0/usr/lib/libngram.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol FLAGS_fst_error_fatal used by debian/libngram0/usr/lib/libngram.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol _ZN3fst13PropertyNamesE used by debian/libngram0/usr/lib/libngram.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol FLAGS_fst_compat_symbols used by debian/libngram0/usr/lib/libngram.so.0.0.0 found in none of the libraries dpkg-shlibdeps: warning: symbol _ZN3fst17ComposePropertiesEyy used by debian/libngram0/usr/lib/libngram.so.0.0.0 found in none of the libraries It looks like a violation of Policy §10.2: “shared libraries must be linked against all libraries that they use symbols from”. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#687563: RFS: opengrm-ngram/1.0.3-1 [ITP] -- opengrm n-gram, library
(Sorry for the late reply. Somehow your mail fell through the cracks...) * Giulio Paci giuliop...@gmail.com, 2013-01-13, 13:56: Would it be possible to exclude binary files from the being analysed by licensecheck? Done. Now debian/source/include-binaries can be dropped. Is there a reason you explicitly enable building static libraries? Just to mimic openfst. But I have to say that openfst upstream suggests static libraries for performance reasons, while opengrm-ngram upstream suggests no static libraries for compilation speed reasons. Do you prefer if I drop the static libraries? If I were the maintainer, I wouldn't bother to enable them. But I'm okay with keeping them, too. Do you know how the files in src/testdata/* were generated? I wonder if we have the full source for it. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#687563: RFS: opengrm-ngram/1.0.3-1 [ITP] -- opengrm n-gram, library
Il 27/02/2013 13:27, Jakub Wilk ha scritto: (Sorry for the late reply. Somehow your mail fell through the cracks...) * Giulio Paci giuliop...@gmail.com, 2013-01-13, 13:56: Would it be possible to exclude binary files from the being analysed by licensecheck? Done. Now debian/source/include-binaries can be dropped. Is there a reason you explicitly enable building static libraries? Just to mimic openfst. But I have to say that openfst upstream suggests static libraries for performance reasons, while opengrm-ngram upstream suggests no static libraries for compilation speed reasons. Do you prefer if I drop the static libraries? If I were the maintainer, I wouldn't bother to enable them. But I'm okay with keeping them, too. I prefer to keep them. Do you know how the files in src/testdata/* were generated? I wonder if we have the full source for it. No I do not know. After manual inspection of the test scripts I can say that I do not know how to generate: 1) testdata/earnest.cat, testdata/earnest.det, testdata/earnest.fst, testdata/earnest.min (unused) 2) testdata/earnest.txt (used as input of ngramsymbols_test.sh and I guess the source of all the earnest.* files) 3) testdata/earnest.det.far, testdata/earnest.fst.far, testdata/earnest.min.far (used as input of ngramcount_test.sh) 4) testdata/init.randcorpus.0.mod, testdata/init.randcorpus.1.mod, testdata/init.randcorpus.2.mod, testdata/init.randcorpus.3.mod (used as input of ngramrand_test.sh) All the other file have a generation command line example in test scripts: testdata/earnest.far : ngramcount_test.sh testdata/earnest.cnts : ngramcount_test.sh testdata/earnest.syms : ngramsymbols_test.sh testdata/earnest-count_prune.pru : ngramshrink_test.sh testdata/earnest-relative_entropy.pru : ngramshrink_test.sh testdata/earnest-seymore.pru : ngramshrink_test.sh testdata/earnest.randgen.far : ngamrandgen_test.sh testdata/earnest.arpa : ngramprint_test.sh testdata/earnest.cnt.print : ngramprint_test.sh testdata/earnest.perp : ngramperplexity_test.sh testdata/earnest.mrg : ngrammerge_test.sh testdata/earnest.mod : ngrammake_test.sh testdata/earnest-absolute.mod : ngrammake_test.sh testdata/earnest-katz.mod : ngrammake_test.sh testdata/earnest-kneser_ney.mod : ngrammake_test.sh testdata/earnest-witten_bell.mod : ngrammake_test.sh testdata/earnest.info : ngraminfo_test.sh testdata/earnest-det.cnts : ngramcount_test.sh testdata/earnest-fst.cnts : ngramcount_test.sh testdata/earnest-min.cnts : ngramcount_test.sh testdata/earnest.randgen.apply.far : ngramapply_test.sh I sent an email upstream to ask about the other files, but I guess we can suppose that we have all the reasonable sources for those files. Bests, Giulio. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#687563: RFS: opengrm-ngram/1.0.3-1 [ITP] -- opengrm n-gram, library
Il 28/02/2013 00:36, Giulio Paci ha scritto: Il 27/02/2013 13:27, Jakub Wilk ha scritto: * Giulio Paci giuliop...@gmail.com, 2013-01-13, 13:56: Would it be possible to exclude binary files from the being analysed by licensecheck? Done. Now debian/source/include-binaries can be dropped. Dropped. Do you know how the files in src/testdata/* were generated? I wonder if we have the full source for it. No I do not know. After manual inspection of the test scripts I can say that I do not know how to generate: 1) testdata/earnest.cat, testdata/earnest.det, testdata/earnest.fst, testdata/earnest.min (unused) 2) testdata/earnest.txt (used as input of ngramsymbols_test.sh and I guess the source of all the earnest.* files) 3) testdata/earnest.det.far, testdata/earnest.fst.far, testdata/earnest.min.far (used as input of ngramcount_test.sh) 4) testdata/init.randcorpus.0.mod, testdata/init.randcorpus.1.mod, testdata/init.randcorpus.2.mod, testdata/init.randcorpus.3.mod (used as input of ngramrand_test.sh) I sent an email upstream to ask about the other files, but I guess we can suppose that we have all the reasonable sources for those files. Upstream confirmed the hypothesis that all the earnest.* files derived from earnest.txt. However upstream does not remember the exact procedure to obtain earnest.fst and earnest,cat. init.randcorpur.number.mod where produced using a random number generator. Bests, Giulio. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#687563: RFS: opengrm-ngram/1.0.3-1 [ITP] -- opengrm n-gram, library
* Jakub Wilk jw...@debian.org, 2013-01-11, 21:20: * Giulio Paci giuliop...@gmail.com, 2013-01-04, 18:39: As far as I can see, the test scripts create temporary files in an insecure way. The scripts do not interfere each other. Instead of patching them, I defined TMPDIR to tmpdata, so that the temporary files are created in the package build directory. That's okay for us, but please forward the bug upstream; they should fix it too. Reported. The package needs the OpenFST far extensions, which were not enabled in Debian until recently. It would be nice to make the libfst-dev build-dependency versioned. Done. Would it be possible to exclude binary files from the being analysed by licensecheck? Done. Is there a reason you explicitly enable building static libraries? Just to mimic openfst. But I have to say that openfst upstream suggests static libraries for performance reasons, while opengrm-ngram upstream suggests no static libraries for compilation speed reasons. Do you prefer if I drop the static libraries? src/include/ngram/ngram.h doesn't look like valid C++ to me... Fixed. Typo in src/bin/ngraminfo.cc: modesl - models. Fixed. Bests, Giulio. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#687563: RFS: opengrm-ngram/1.0.3-1 [ITP] -- opengrm n-gram library
* Giulio Paci giuliop...@gmail.com, 2013-01-04, 18:39: As far as I can see, the test scripts create temporary files in an insecure way. The scripts do not interfere each other. Instead of patching them, I defined TMPDIR to tmpdata, so that the temporary files are created in the package build directory. That's okay for us, but please forward the bug upstream; they should fix it too. The package needs the OpenFST far extensions, which were not enabled in Debian until recently. It would be nice to make the libfst-dev build-dependency versioned. Would it be possible to exclude binary files from the being analysed by licensecheck? Is there a reason you explicitly enable building static libraries? src/include/ngram/ngram.h doesn't look like valid C++ to me... Typo in src/bin/ngraminfo.cc: modesl - models. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#687563: RFS: opengrm-ngram/1.0.3-1 [ITP] -- opengrm n-gram library
Il 03/01/2013 16:55, Jakub Wilk ha scritto: * Giulio Paci giuliop...@gmail.com, 2013-01-03, 00:20: Now I get this: | /usr/bin/make check-TESTS | make[4]: Entering directory `/build/opengrm-ngram-6ZveSN/opengrm-ngram-1.0.3/src/test' | PASS: ngramprint_test.sh | PASS: ngramcount_test.sh | PASS: ngrammake_test.sh | PASS: ngrammerge_test.sh | PASS: ngramshrink_test.sh | PASS: ngraminfo_test.sh | PASS: ngramperplexity_test.sh | PASS: ngramsymbols_test.sh | PASS: ngramrandgen_test.sh | PASS: ngramapply_test.sh | Running 9 random trials... | FATAL: SetFlags: Bad option: --seed= ... I guess it's because of bashisms in the failing script: Indeed that was the reason. It is fixed now. It's now: seed1=`od -A n -N 2 -t u2 $RANDOMFILE` seed1=`printf %d $seed1` Is that pritnf only to strip whitespace? If yes, these two lines could be rewritten as: seed1=`od -A n -N 2 -t u2 $RANDOMFILE | xargs` (But that's of course not very important.) Thanks for the suggestion. I updated the patch with it. I also introduced a fallback mechanism so that $RANDOM is used if /dev/random or /dev/urandom are not available (i.e., with this patch the test works on MSYS using a bash shell). Typo in src/test/ngramcount_test.sh: determinitic - deterministic. Added a patch to fix that. As far as I can see, the test scripts create temporary files in an insecure way. The scripts do not interfere each other. Instead of patching them, I defined TMPDIR to tmpdata, so that the temporary files are created in the package build directory. Bests, Giulio. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#687563: RFS: opengrm-ngram/1.0.3-1 [ITP] -- opengrm n-gram library
* Giulio Paci giuliop...@gmail.com, 2013-01-03, 00:20: Now I get this: | /usr/bin/make check-TESTS | make[4]: Entering directory `/build/opengrm-ngram-6ZveSN/opengrm-ngram-1.0.3/src/test' | PASS: ngramprint_test.sh | PASS: ngramcount_test.sh | PASS: ngrammake_test.sh | PASS: ngrammerge_test.sh | PASS: ngramshrink_test.sh | PASS: ngraminfo_test.sh | PASS: ngramperplexity_test.sh | PASS: ngramsymbols_test.sh | PASS: ngramrandgen_test.sh | PASS: ngramapply_test.sh | Running 9 random trials... | FATAL: SetFlags: Bad option: --seed= ... I guess it's because of bashisms in the failing script: Indeed that was the reason. It is fixed now. It's now: seed1=`od -A n -N 2 -t u2 $RANDOMFILE` seed1=`printf %d $seed1` Is that pritnf only to strip whitespace? If yes, these two lines could be rewritten as: seed1=`od -A n -N 2 -t u2 $RANDOMFILE | xargs` (But that's of course not very important.) Typo in src/test/ngramcount_test.sh: determinitic - deterministic. As far as I can see, the test scripts create temporary files in an insecure way. -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#687563: RFS: opengrm-ngram/1.0.3-1 [ITP] -- opengrm n-gram library
* Giulio Paci giuliop...@gmail.com, 2013-01-01, 21:54: The package FTBFS here: | checking fst/fst.h usability... no | checking fst/fst.h presence... no | checking for fst/fst.h... no | configure: error: fst/fst.h header not found | make: *** [debian/stamp-autotools] Error 1 Added missing libfst-dev dependency. Now it fails with: | /usr/bin/make check-TESTS | make[4]: Entering directory `/build/opengrm-ngram-ORzcqC/opengrm-ngram-1.0.3/src/test' | ./ngramprint_test.sh: 23: ./ngramprint_test.sh: fstequal: not found | FAIL: ngramprint_test.sh | ./ngramcount_test.sh: 11: ./ngramcount_test.sh: farcompilestrings: not found | FAIL: ngramcount_test.sh | ./ngrammake_test.sh: 14: ./ngrammake_test.sh: fstequal: not found | FAIL: ngrammake_test.sh | ./ngrammerge_test.sh: 15: ./ngrammerge_test.sh: fstequal: not found | FAIL: ngrammerge_test.sh | ./ngramshrink_test.sh: 16: ./ngramshrink_test.sh: fstequal: not found | FAIL: ngramshrink_test.sh | PASS: ngraminfo_test.sh | PASS: ngramperplexity_test.sh | PASS: ngramsymbols_test.sh | ./ngramrandgen_test.sh: 16: ./ngramrandgen_test.sh: farequal: not found | FAIL: ngramrandgen_test.sh | ./ngramapply_test.sh: 13: ./ngramapply_test.sh: farequal: not found | FAIL: ngramapply_test.sh | ./ngramrand_test.sh: 14: ./ngramrand_test.sh: farprintstrings: not found | Running random trials... | FATAL: SetFlags: Bad option: --max_sents= | FAIL: ngramrand_test.sh | == | 8 of 11 tests failed -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#687563: RFS: opengrm-ngram/1.0.3-1 [ITP] -- opengrm n-gram library
Il 02/01/2013 11:33, Jakub Wilk ha scritto: * Giulio Paci giuliop...@gmail.com, 2013-01-01, 21:54: The package FTBFS here: Now it fails with: | /usr/bin/make check-TESTS | make[4]: Entering directory `/build/opengrm-ngram-ORzcqC/opengrm-ngram-1.0.3/src/test' | ./ngramprint_test.sh: 23: ./ngramprint_test.sh: fstequal: not found ... Added missing libfst-tools dependency. Also added libfst-tools to the Recommends field for libngram-tools. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#687563: RFS: opengrm-ngram/1.0.3-1 [ITP] -- opengrm n-gram library
* Giulio Paci giuliop...@gmail.com, 2013-01-02, 12:18: | /usr/bin/make check-TESTS | make[4]: Entering directory `/build/opengrm-ngram-ORzcqC/opengrm-ngram-1.0.3/src/test' | ./ngramprint_test.sh: 23: ./ngramprint_test.sh: fstequal: not found ... Added missing libfst-tools dependency. Also added libfst-tools to the Recommends field for libngram-tools. Now I get this: | /usr/bin/make check-TESTS | make[4]: Entering directory `/build/opengrm-ngram-6ZveSN/opengrm-ngram-1.0.3/src/test' | PASS: ngramprint_test.sh | PASS: ngramcount_test.sh | PASS: ngrammake_test.sh | PASS: ngrammerge_test.sh | PASS: ngramshrink_test.sh | PASS: ngraminfo_test.sh | PASS: ngramperplexity_test.sh | PASS: ngramsymbols_test.sh | PASS: ngramrandgen_test.sh | PASS: ngramapply_test.sh | Running 9 random trials... | FATAL: SetFlags: Bad option: --seed= | FATAL: SetFlags: Bad option: --seed= | FATAL: SetFlags: Bad option: --seed= | FATAL: SetFlags: Bad option: --seed= | FATAL: SetFlags: Bad option: --seed= | FATAL: SetFlags: Bad option: --seed= | FATAL: SetFlags: Bad option: --seed= | FATAL: SetFlags: Bad option: --seed= | FATAL: SetFlags: Bad option: --seed= | FATAL: SetFlags: Bad option: --seed= | FATAL: SetFlags: Bad option: --seed= | FATAL: SetFlags: Bad option: --seed= | FATAL: SetFlags: Bad option: --seed= | FATAL: SetFlags: Bad option: --seed= | FATAL: SetFlags: Bad option: --seed= | FATAL: SetFlags: Bad option: --seed= | FATAL: SetFlags: Bad option: --seed= | FATAL: SetFlags: Bad option: --seed= | 1 params: V=1; S=1; sents1=348; sents2=440; O1=2; O2=3; T=2 | seed1=;seed2= | FATAL: SetFlags: Bad option: --seed= | FAIL: ngramrand_test.sh I guess it's because of bashisms in the failing script: | $ checkbashisms src/test/*.sh | possible bashism in src/test/ngramrand_test.sh line 55 ($RANDOM): | seed1=$RANDOM | possible bashism in src/test/ngramrand_test.sh line 58 ($RANDOM): | seed2=$RANDOM -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#687563: RFS: opengrm-ngram/1.0.3-1 [ITP] -- opengrm n-gram library
Il 02/01/2013 14:52, Jakub Wilk ha scritto: * Giulio Paci giuliop...@gmail.com, 2013-01-02, 12:18: | /usr/bin/make check-TESTS | make[4]: Entering directory `/build/opengrm-ngram-ORzcqC/opengrm-ngram-1.0.3/src/test' | ./ngramprint_test.sh: 23: ./ngramprint_test.sh: fstequal: not found ... Added missing libfst-tools dependency. Also added libfst-tools to the Recommends field for libngram-tools. Now I get this: | /usr/bin/make check-TESTS | make[4]: Entering directory `/build/opengrm-ngram-6ZveSN/opengrm-ngram-1.0.3/src/test' | PASS: ngramprint_test.sh | PASS: ngramcount_test.sh | PASS: ngrammake_test.sh | PASS: ngrammerge_test.sh | PASS: ngramshrink_test.sh | PASS: ngraminfo_test.sh | PASS: ngramperplexity_test.sh | PASS: ngramsymbols_test.sh | PASS: ngramrandgen_test.sh | PASS: ngramapply_test.sh | Running 9 random trials... | FATAL: SetFlags: Bad option: --seed= ... I guess it's because of bashisms in the failing script: Indeed that was the reason. It is fixed now. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#687563: RFS: opengrm-ngram/1.0.3-1 [ITP] -- opengrm n-gram library
Il 31/12/2012 22:00, Jakub Wilk ha scritto: * Giulio Paci giuliop...@gmail.com, 2012-09-13, 21:21: http://mentors.debian.net/debian/pool/main/o/opengrm-ngram/opengrm-ngram_1.0.3-1.dsc The Apache license text in debian/copyright should be indented by one space, not two. Fixed. debian/copyright_hints makes me sad… Refreshed. The package FTBFS here: | checking fst/fst.h usability... no | checking fst/fst.h presence... no | checking for fst/fst.h... no | configure: error: fst/fst.h header not found | make: *** [debian/stamp-autotools] Error 1 Added missing libfst-dev dependency. Bests, Giulio. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#687563: RFS: opengrm-ngram/1.0.3-1 [ITP] -- opengrm n-gram library
Il 01/01/2013 21:54, Giulio Paci ha scritto: Il 31/12/2012 22:00, Jakub Wilk ha scritto: * Giulio Paci giuliop...@gmail.com, 2012-09-13, 21:21: http://mentors.debian.net/debian/pool/main/o/opengrm-ngram/opengrm-ngram_1.0.3-1.dsc I moved the sources to: git://anonscm.debian.org/collab-maint/opengrm-ngram.git -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#687563: RFS: opengrm-ngram/1.0.3-1 [ITP] -- opengrm n-gram library
* Giulio Paci giuliop...@gmail.com, 2012-09-13, 21:21: http://mentors.debian.net/debian/pool/main/o/opengrm-ngram/opengrm-ngram_1.0.3-1.dsc The Apache license text in debian/copyright should be indented by one space, not two. debian/copyright_hints makes me sad… The package FTBFS here: | checking fst/fst.h usability... no | checking fst/fst.h presence... no | checking for fst/fst.h... no | configure: error: fst/fst.h header not found | make: *** [debian/stamp-autotools] Error 1 -- Jakub Wilk -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#687563: RFS: opengrm-ngram/1.0.3-1 [ITP] -- opengrm n-gram library
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package opengrm-ngram * Package name: opengrm-ngram Version : 1.0.3-1 Upstream Author : Brian Roark roar...@gmail.com * URL : http://www.openfst.org/twiki/bin/view/GRM/NGramLibrary * License : APACHE-2.0 Section : libs It builds those binary packages: libngram-dev - opengrm n-gram library (development) libngram-tools - opengrm n-gram library (tools) libngram0 - opengrm n-gram library (runtime) libngram0-dbg - opengrm n-gram library (debug symbols) To access further information about this package, please visit the following URL: http://mentors.debian.net/package/opengrm-ngram Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/o/opengrm-ngram/opengrm-ngram_1.0.3-1.dsc More information about opengrm-ngram can be obtained from http://www.openfst.org/twiki/bin/view/GRM/NGramLibrary/. Regards, Giulio Paci -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
