Your message dated Tue, 09 Apr 2024 08:11:14 +0200
with message-id <14045375.RDIVbhacDa@turnagra>
and subject line Re: Bug#1050288: nsis 3.08-3 (bookworm) generates bogus 
relocation information (regression)
has caused the Debian Bug report #1050288,
regarding nsis 3.08-3 (bookworm) generates bogus relocation information 
(regression)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1050288: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050288
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: nsis
Version: 3.08-3
Severity: important

makensis 3.08-3 on bookworm creates installers with a non-empty relocation section which contains garbage.

The installers work, but trigger false positive warnings from security scanners, likely due to exe file corruption.

Testcase:

$ dpkg --list nsis nsis-common
...
ii  nsis           3.08-3       amd64        ...
ii  nsis-common    3.08-3       all          ...

$ cat test.nsi
Section "Empty"
SectionEnd

$ makensis test.nsi
...

$ objdump -p test.exe >/dev/null
objdump: error: test.exe(.reloc) is too large (0x8e4 bytes)

$ objdump -p test.exe 2>/dev/null
...
Entry 5 00047000 000008e4 Base Relocation Directory [.reloc]
...

$ objdump -p /usr/share/nsis/Stubs/zlib-x86-unicode
...
Entry 5 00047000 000008e4 Base Relocation Directory [.reloc]
...
PE File Base Relocations (interpreted .reloc section contents)

Virtual Address: 00001000 Chunk size 196 (0xc4) Number of fixups 94
        reloc    0 offset   2b [102b] HIGHLOW
        reloc    1 offset   40 [1040] HIGHLOW
...
Virtual Address: 0000c000 Chunk size 216 (0xd8) Number of fixups 104
        reloc    1 offset    8 [c008] HIGHLOW
        reloc    2 offset    c [c00c] HIGHLOW
...
        reloc  102 offset  8f8 [c8f8] HIGHLOW
        reloc  103 offset  8fc [c8fc] HIGHLOW


All the stubs apparently have a non-empty relocation section with garbage. This is not the case for the stubs from nsis-common-3.06.1-1 (bullseye) and nsis-common-3.09-1 (sid).

This is also not the case with the upstream 3.08 and 3.09 builds for windows which are available at
https://sourceforge.net/projects/nsis/files/NSIS%203/

Related: https://sourceforge.net/p/nsis/bugs/1299/

--
Regards
Christian Franke
smartmontools.org

--- End Message ---
--- Begin Message ---
Version: 3.09-1

Le samedi, 26 août 2023, 14.23:38 h CEST Thomas Gaugler a écrit :
> Thank you for your detailed bug report.
> 
> I built the nsis_3.09-1 and nsis-common_3.09-1 packages on Debian
> Bookworm, installed the resulting packages and can confirm with the two
> Nullsoft Installer (.nsi) scripts provided by you that the resulting
> installer executables no longer show the "(.reloc) is too large" error
> with objdump.

In other words, you are claiming that you have verified that this is fixed in 
the 3.09-1 version.

I'm hereby marking this bug as fixed in that version (via a -done email, with 
a "Version:" pseudo-header).

This will mark it as solved in testing and sid (as the 3.09-1 is older than 
the versions in both these releases. It will open the possibility for a fix in 
stable.

Best,
    OdyX

Attachment: signature.asc
Description: This is a digitally signed message part.


--- End Message ---

Reply via email to