Your message dated Mon, 04 Jan 2021 09:04:56 +0000
with message-id <e1kwlnm-0008tn...@fasolo.debian.org>
and subject line Bug#979208: fixed in node-source-map 
0.7.0++dfsg2+really.0.6.1-6
has caused the Debian Bug report #979208,
regarding libjs-source-map breaks ruby-terser with err ExecJS::ProgramError: 
ReferenceError: window is not defined
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
979208: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=979208
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
package: libjs-source-map
version: 0.7.0++dfsg2+really.0.6.1-4
severity: grave
Control: affects -1 ruby-terser

Upstream npmjs.com dist tarball has the following at the top of dist/source-map.min.js

!function(e,n){"object"==typeof exports&&"object"==typeof module?module.exports=n():"function"==typeof define&&define.amd?define([],n):"object"==typeof exports?exports.sourceMap=n():e.sourceMap=n()}(this,function(){return function(e){function n(t){if(r[t])return r[t].exports;

But debian package ships with the following ("window,function()" instead of "this,function()",

!function(e,n){"object"==typeof exports&&"object"==typeof module?module.exports=n():"function"==typeof define&&define.amd?define([],n):"object"==typeof exports?exports.sourceMap=n():e.sourceMap=n()}(window,function(){return function(e){var n={};function r(t){if(n[t])return n[t].exports;

which breaks no browser environments like ruby execjs/rails assets pipeline.

This caused gitlab asset precompilation failure, which now switched to ruby-terser from earlier ruby-uglifier.

rake aborted!
ExecJS::ProgramError: ReferenceError: window is not defined
(execjs):441:200
(execjs):502:14
(execjs):1:40
Object.<anonymous> ((execjs):1:58)
Module._compile (internal/modules/cjs/loader.js:1015:30)
Object.Module._extensions..js (internal/modules/cjs/loader.js:1035:10)
Module.load (internal/modules/cjs/loader.js:879:32)
Function.Module._load (internal/modules/cjs/loader.js:724:14)
Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
internal/main/run_main_module.js:17:47
/usr/share/rubygems-integration/all/gems/terser-1.0.2/lib/terser.rb:183:in `context' /usr/share/rubygems-integration/all/gems/terser-1.0.2/lib/terser.rb:223:in `run_terserjs' /usr/share/rubygems-integration/all/gems/terser-1.0.2/lib/terser.rb:164:in `compile' /usr/share/rubygems-integration/all/gems/terser-1.0.2/lib/terser/compressor.rb:45:in `call' /usr/share/rubygems-integration/all/gems/terser-1.0.2/lib/terser/compressor.rb:23:in `call' /usr/share/rubygems-integration/all/gems/actionview-6.0.3.4/lib/action_view/helpers/asset_url_helper.rb:201:in `asset_path' /usr/share/gitlab/app/assets/javascripts/lib/ace/ace_config_paths.js.erb:22:in `block in _evaluate_template' /usr/share/gitlab/app/assets/javascripts/lib/ace/ace_config_paths.js.erb:21:in `each' /usr/share/gitlab/app/assets/javascripts/lib/ace/ace_config_paths.js.erb:21:in `_evaluate_template' /usr/share/rubygems-integration/all/gems/rake-13.0.1/exe/rake:27:in `<top (required)>'
Tasks: TOP => assets:precompile
(See full trace by running task with --trace)

Upstream build is using webpack 1.12 where as we have webpack 4.43 so we need to update our webpack configuration.

As per https://dev.to/riversun/recipes-on-how-to-create-a-library-that-supports-both-browser-and-node-js-201m

we should add globalObject: 'this', to webpack configuration.

--- End Message ---
--- Begin Message ---
Source: node-source-map
Source-Version: 0.7.0++dfsg2+really.0.6.1-6
Done: Pirate Praveen <prav...@debian.org>

We believe that the bug you reported is fixed in the latest version of
node-source-map, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 979...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Pirate Praveen <prav...@debian.org> (supplier of updated node-source-map 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 04 Jan 2021 14:15:18 +0530
Source: node-source-map
Architecture: source
Version: 0.7.0++dfsg2+really.0.6.1-6
Distribution: unstable
Urgency: medium
Maintainer: Debian Javascript Maintainers 
<pkg-javascript-de...@lists.alioth.debian.org>
Changed-By: Pirate Praveen <prav...@debian.org>
Closes: 979208
Changes:
 node-source-map (0.7.0++dfsg2+really.0.6.1-6) unstable; urgency=medium
 .
   * Team upload
   * Use globalObject: this in webpack configuration for node compatibility
     (Closes: #979208)
   * Add comment to patch
Checksums-Sha1:
 7c0aa33fc675648d202b984c0535a8fe22c1502a 2317 
node-source-map_0.7.0++dfsg2+really.0.6.1-6.dsc
 5744635c5467e6a1f4b6a96dc4844c1d94fb7179 4940 
node-source-map_0.7.0++dfsg2+really.0.6.1-6.debian.tar.xz
 3b91f1bb7db650991dcee8fb5b1b8200e70207dd 14113 
node-source-map_0.7.0++dfsg2+really.0.6.1-6_amd64.buildinfo
Checksums-Sha256:
 243dee08cce487688a62e435603fe6f2ad7c61ca350a0c1a0eac59c185df4d36 2317 
node-source-map_0.7.0++dfsg2+really.0.6.1-6.dsc
 7d4365f4407917af9028c023e4bb03b65821ce8f8e3d6a1e314eff0764f5480b 4940 
node-source-map_0.7.0++dfsg2+really.0.6.1-6.debian.tar.xz
 866966fdc5ce2928f604d99a106154595730408d7d25717d32fe5f7f2dc0ec72 14113 
node-source-map_0.7.0++dfsg2+really.0.6.1-6_amd64.buildinfo
Files:
 7371eb10b052effb084c4b0b50860195 2317 javascript optional 
node-source-map_0.7.0++dfsg2+really.0.6.1-6.dsc
 df08d4a5a62805f17566db5377d9b7cb 4940 javascript optional 
node-source-map_0.7.0++dfsg2+really.0.6.1-6.debian.tar.xz
 8bbcf7720cd42b0459cf3e1c11d3244c 14113 javascript optional 
node-source-map_0.7.0++dfsg2+really.0.6.1-6_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE0whj4mAg5UP0cZqDj1PgGTspS3UFAl/y11gACgkQj1PgGTsp
S3XcgQ//SM5uIpJBj0k98p7WPPsTBz1rOZqzr9V+uPKEGFwyzWU4gc+bhIVre/Db
ceIGmOX+d9pPUucthtYHkuXy4seTCwd7gqDnqzlZbTUVEL/00U8439OfNmwdN0jT
QaynF3GzUTTnvr36RRDISDWDgdsq8eg6j6qgfzySsNGbNm7zSSILTD26EEBCQI4m
6J+VeC6uEnHH9NJxuTbfBgmNZBowGohrv7FjudPMznQivXSzcRmuw20U8hAeyA8G
WPu42poUBwBbmQQ4J80qWQ2FoRIpa76yjfLHsN+OVE2xnMtOrw7SowhkdYKZWqC/
Xouqky+eS1MBfDiepNQzKSnvtfsfQ/ntOmGvwTBhiMtxzfABYETalHkp7PDefCid
x540/I/eU0aJLXYs8eZSDhRhN3jKhf/yPjuM140a6xMmuv11T6oQNVwkPKYQ9jio
66TlrlIReU8PKWR01a6FeaQLJLHVRI9eHvBysicFng7Tuz2Nzwcrtsd1+Z6alfrN
dXsqWoP7yUpiLlOBK+OT+V5i95Css49YtHcq9GgrhsPjdK9rKOEes3SE+uVJDoj7
7mcTxS8pZN4dNc1yniLnkLFKoZbj89Kxa2Asfp86FntFbH6PIQ5enj5PwQCCCjN2
fdBG137F+KMBuIBY7JNTOrSBHajG0EjZ6bp4W1Az3aa86y9E2jk=
=UMHp
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to