Bug#1069686: libsequoia-octopus-librnp: postinst script Syntax error: "fi" unexpected

2024-04-23 Thread Daniel Kahn Gillmor
On Mon 2024-04-22 20:17:54 +, Holger Levsen wrote:
> fixed in git.

thanks!  I've just uninstalled the octopus, but i'll consider
reinstalling it later if this and some of the performance issues can be
ironed out (or maybe to help iron out the performance issues, visible
upstream at
https://gitlab.com/sequoia-pgp/sequoia-octopus-librnp/-/issues/102)

> the change seems innocent enough... (I just wasnt expected the different
> formatting styles...)

i hear you, and i've made this exact mistake myself more times than i
can count :P

> the irony is: the autopkg tests for the package had failed which I blamed
> on unstables unstableness these days, so I reviewed the diff once more,
> (again) didnt notice the introduced bug and did a source only upload,
> because the change were tiny... :/

urgh, yeah, unstable breakage makes everything harder.

I'm still thinking about what kinds of autopkgtests might be useful in
terms of ensuring that thunderbird actually works with librnp, though.
that's different from the autopkgtests generated by debcargo.

I'll report that in a different bug report, though, maybe we can
brainstorm there.

   --dkg


signature.asc
Description: PGP signature


Bug#1069686: libsequoia-octopus-librnp: postinst script Syntax error: "fi" unexpected

2024-04-22 Thread Holger Levsen
On Mon, Apr 22, 2024 at 02:41:44PM -0400, Daniel Kahn Gillmor wrote:
> /var/lib/dpkg/tmp.ci/preinst: 12: Syntax error: "fi" unexpected (expecting 
> "then")
> dpkg: error processing archive 
> /tmp/apt-dpkg-install-aFNmwO/1-libsequoia-octopus-librnp_1.8.1-3_amd64.deb 
> (--unpack):
>  new libsequoia-octopus-librnp package pre-installation script subprocess 
> returned error exit status 2

fixed in git.
 
> Please try at least installing and uninstalling the package before
> pushing it into unstable!

the change seems innocent enough... (I just wasnt expected the different
formatting styles...)

> This also makes me wonder whether we should be doing anything in an
> autopkgtest kind of way for this package.  It'd be great to get some
> more automated confirmation that the things are working as expected
> before we inflict them on the rest of the debian ecosystem :P

the irony is: the autopkg tests for the package had failed which I blamed
on unstables unstableness these days, so I reviewed the diff once more,
(again) didnt notice the introduced bug and did a source only upload,
because the change were tiny... :/

to me this is more an argument for unstable-untested, or testing maybe.


-- 
cheers,
Holger

 ⢀⣴⠾⠻⢶⣦⠀
 ⣾⠁⢠⠒⠀⣿⡁  holger@(debian|reproducible-builds|layer-acht).org
 ⢿⡄⠘⠷⠚⠋⠀  OpenPGP: B8BF54137B09D35CF026FE9D 091AB856069AAA1C
 ⠈⠳⣄

20230709: Today was the warmest day on earth in 125,000 years. Today was also
the day with the most planes in the air at one time ever in history. By the time
you read this both of these records have probably been broken.


signature.asc
Description: PGP signature


Bug#1069686: libsequoia-octopus-librnp: postinst script Syntax error: "fi" unexpected

2024-04-22 Thread Daniel Kahn Gillmor
Package: libsequoia-octopus-librnp
Version: 1.8.1-3
Severity: grave
X-Debbugs-Cc: Daniel Kahn Gillmor 

Trying to install libsequoia-octopus-librnp:

/var/lib/dpkg/tmp.ci/preinst: 12: Syntax error: "fi" unexpected (expecting 
"then")
dpkg: error processing archive 
/tmp/apt-dpkg-install-aFNmwO/1-libsequoia-octopus-librnp_1.8.1-3_amd64.deb 
(--unpack):
 new libsequoia-octopus-librnp package pre-installation script subprocess 
returned error exit status 2

Please try at least installing and uninstalling the package before
pushing it into unstable!

This also makes me wonder whether we should be doing anything in an
autopkgtest kind of way for this package.  It'd be great to get some
more automated confirmation that the things are working as expected
before we inflict them on the rest of the debian ecosystem :P

   --dkg

-- System Information:
Debian Release: trixie/sid
  APT prefers testing-debug
  APT policy: (500, 'testing-debug'), (500, 'testing'), (500, 'stable'), (500, 
'oldstable'), (200, 'unstable-debug'), (200, 'unstable'), (1, 
'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.6.15-amd64 (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_FIRMWARE_WORKAROUND
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libsequoia-octopus-librnp depends on:
ii  libbz2-1.0  1.0.8-5.1
ii  libc6   2.37-15
ii  libgcc-s1   14-20240201-3
ii  libgmp102:6.3.0+dfsg-2+b1
ii  libhogweed6t64  3.9.1-2.2
ii  libnettle8t64   3.9.1-2.2
ii  libsqlite3-03.45.1-1
ii  libssl3t64  3.2.1-3

Versions of packages libsequoia-octopus-librnp recommends:
ii  zenity  4.0.1-1

Versions of packages libsequoia-octopus-librnp suggests:
ii  thunderbird  1:115.10.1-1

-- no debconf information


signature.asc
Description: PGP signature