Re: autodep8 test for C/C++ header

2023-08-12 Thread Lisandro Damian Nicanor Perez Meyer
On martes, 8 de agosto de 2023 04:50:04 -03 Helmut Grohne wrote: > Hi Sune, > > On Tue, Aug 08, 2023 at 06:46:38AM -, Sune Vuorela wrote: > > I don't think this is a important problem that some headers might have > > special conditions for use. I'd rather have our developers spend time > >

Re: autodep8 test for C/C++ header

2023-08-09 Thread Benjamin Drung
On Wed, 2023-08-09 at 18:30 +0300, Adrian Bunk wrote: > On Wed, Aug 09, 2023 at 02:26:17PM +0800, Paul Wise wrote: > > On Tue, 2023-08-08 at 18:32 +0300, Adrian Bunk wrote: > > > > > Manual opt-in for our > 11k -dev packages is a significant cost > > > that would have to be justified by the

Re: autodep8 test for C/C++ header

2023-08-09 Thread Adrian Bunk
On Wed, Aug 09, 2023 at 02:26:17PM +0800, Paul Wise wrote: > On Tue, 2023-08-08 at 18:32 +0300, Adrian Bunk wrote: > > > Manual opt-in for our > 11k -dev packages is a significant cost > > that would have to be justified by the people who oppose opt-out. > > You could use the Janitor to do

Re: autodep8 test for C/C++ header

2023-08-09 Thread Benjamin Drung
On Tue, 2023-08-08 at 18:32 +0300, Adrian Bunk wrote: > On Tue, Aug 08, 2023 at 09:19:16AM -0300, Antonio Terceiro wrote: > > On Tue, Aug 08, 2023 at 11:35:01AM +0300, Adrian Bunk wrote: > > > On Tue, Aug 08, 2023 at 06:46:38AM -, Sune Vuorela wrote: > > > > On 2023-08-07, Benjamin Drung

Re: autodep8 test for C/C++ header

2023-08-09 Thread Paul Wise
On Tue, 2023-08-08 at 11:42 +0300, Adrian Bunk wrote: > An additional check with some overlap would be whether >    pkgconf --cflags .pc > returns 0 for every pkgconfig file in a package. piuparts runs adequate, which runs something similar:    pkg-config --exists --print-errors .pc It emits

Re: autodep8 test for C/C++ header

2023-08-09 Thread Paul Wise
On Tue, 2023-08-08 at 18:32 +0300, Adrian Bunk wrote: > Manual opt-in for our > 11k -dev packages is a significant cost > that would have to be justified by the people who oppose opt-out. You could use the Janitor to do automatic opt-in where it works, IIRC the Janitor runs autopkgtests before

Re: autodep8 test for C/C++ header

2023-08-08 Thread Helmut Grohne
Hi Sune, On Tue, Aug 08, 2023 at 06:46:38AM -, Sune Vuorela wrote: > I don't think this is a important problem that some headers might have > special conditions for use. I'd rather have our developers spend time > fixing other issues than satisfying this script. A while ago, I've performed a

Re: autodep8 test for C/C++ header

2023-08-08 Thread Adrian Bunk
On Tue, Aug 08, 2023 at 09:19:16AM -0300, Antonio Terceiro wrote: > On Tue, Aug 08, 2023 at 11:35:01AM +0300, Adrian Bunk wrote: > > On Tue, Aug 08, 2023 at 06:46:38AM -, Sune Vuorela wrote: > > > On 2023-08-07, Benjamin Drung wrote: > > > > while working a whole week on fixing failing C/C++

Re: autodep8 test for C/C++ header

2023-08-08 Thread Antonio Terceiro
On Tue, Aug 08, 2023 at 11:35:01AM +0300, Adrian Bunk wrote: > On Tue, Aug 08, 2023 at 06:46:38AM -, Sune Vuorela wrote: > > On 2023-08-07, Benjamin Drung wrote: > > > while working a whole week on fixing failing C/C++ header compilations > > > for armhf time_t [1], I noticed a common

Re: autodep8 test for C/C++ header

2023-08-08 Thread Adrian Bunk
On Mon, Aug 07, 2023 at 06:43:36PM +, Benjamin Drung wrote: >... > I propose to add an autodep8 test for C/C++ header files that tries to > compile the header file. This will catch issues like missing > dependencies and other issues. >... An additional check with some overlap would be whether

Re: autodep8 test for C/C++ header

2023-08-08 Thread Adrian Bunk
On Tue, Aug 08, 2023 at 06:46:38AM -, Sune Vuorela wrote: > On 2023-08-07, Benjamin Drung wrote: > > while working a whole week on fixing failing C/C++ header compilations > > for armhf time_t [1], I noticed a common pattern: The library -dev > > packages was missing one or more dependencies

Re: autodep8 test for C/C++ header

2023-08-08 Thread Adrian Bunk
On Mon, Aug 07, 2023 at 09:17:18PM +, Benjamin Drung wrote: > On Mon, 2023-08-07 at 22:52 +0300, Peter Pentchev wrote: >... > > 1) The library has a "main" header file that must be included before > >any of the others, and it does not come first in lexicographical > >order. It may

Re: autodep8 test for C/C++ header

2023-08-08 Thread Sune Vuorela
On 2023-08-07, Benjamin Drung wrote: > while working a whole week on fixing failing C/C++ header compilations > for armhf time_t [1], I noticed a common pattern: The library -dev > packages was missing one or more dependencies on another -dev package. > Over 200 -dev packages are affected. I

Re: autodep8 test for C/C++ header

2023-08-07 Thread Johannes Schauer Marin Rodrigues
Hi, Quoting Benjamin Drung (2023-08-07 20:43:36) > while working a whole week on fixing failing C/C++ header compilations for > armhf time_t [1], I noticed a common pattern: The library -dev packages was > missing one or more dependencies on another -dev package. Over 200 -dev > packages are

Re: autodep8 test for C/C++ header

2023-08-07 Thread Benjamin Drung
On Mon, 2023-08-07 at 22:52 +0300, Peter Pentchev wrote: > On Mon, Aug 07, 2023 at 06:43:36PM +, Benjamin Drung wrote: > > Hi, > > > > while working a whole week on fixing failing C/C++ header compilations > > for armhf time_t [1], I noticed a common pattern: The library -dev > > packages was

Re: autodep8 test for C/C++ header

2023-08-07 Thread Peter Pentchev
On Mon, Aug 07, 2023 at 06:43:36PM +, Benjamin Drung wrote: > Hi, > > while working a whole week on fixing failing C/C++ header compilations > for armhf time_t [1], I noticed a common pattern: The library -dev > packages was missing one or more dependencies on another -dev package. > Over 200