Bug#652356: please use argument-safe bswap macros on all architectures

2011-12-19 Thread Thorsten Glaser
Dixi quod… Jonathan Nieder dixit: Thorsten, can you test this patch or arrange for it to be tested? Will do that Built, WFM. bye, //mirabilos -- “Having a smoking section in a restaurant is like having a peeing section in a swimming pool.”

Re: Bug#652356: please use argument-safe bswap macros on all architectures

2011-12-17 Thread Aurelien Jarno
On Sat, Dec 17, 2011 at 02:52:53AM +, Thorsten Glaser wrote: Aurelien Jarno dixit: I have dropped it in favor of the default version for the next upload. Why don’t you just use these? (Tested for 32-bit and 64-bit both.) I am not an m68k porter, and I am not planning to try things.

Bug#652356: please use argument-safe bswap macros on all architectures

2011-12-17 Thread Thorsten Glaser
Aurelien Jarno dixit: I am not an m68k porter, and I am not planning to try things. m68k is lagging upstream wrt other architectures. Please work with upstream to fix things, then I can include tested and accepted patches. I’m not an m68k porter either, but this fix is easily done from working

Re: Bug#652356: please use argument-safe bswap macros on all architectures

2011-12-17 Thread Aurelien Jarno
On Sat, Dec 17, 2011 at 12:51:48PM +, Thorsten Glaser wrote: Aurelien Jarno dixit: I am not an m68k porter, and I am not planning to try things. m68k is lagging upstream wrt other architectures. Please work with upstream to fix things, then I can include tested and accepted patches.

Bug#652356: please use argument-safe bswap macros on all architectures

2011-12-17 Thread Thorsten Glaser
Aurelien Jarno dixit: If you are not an m68k porter, you should simply stop to care about m68k porting issues. I care about the entire Open Source ecosystem. (Way to motivate people.) bye, //mirabilos -- 13:22⎜«neurodamage» mira, what's up man? I have a CVS question for you in #cvs

Bug#652356: please use argument-safe bswap macros on all architectures

2011-12-16 Thread Thorsten Glaser
Source: eglibc Hi, (from #595496) please make sure that this passes on all architectures: cat x.c 'EOF' #include stddef.h #include stdint.h #include byteswap.h uint32_t foo(uint32_t *bar, size_t *baz) { return (bswap_32(bar[(*baz)++])); } EOF gcc -Wall -c x.c On amd64 it passes, on

Bug#652356: please use argument-safe bswap macros on all architectures

2011-12-16 Thread Aurelien Jarno
On Fri, Dec 16, 2011 at 03:29:59PM +, Thorsten Glaser wrote: Source: eglibc Hi, (from #595496) please make sure that this passes on all architectures: cat x.c 'EOF' #include stddef.h #include stdint.h #include byteswap.h uint32_t foo(uint32_t *bar, size_t *baz) {

Bug#652356: please use argument-safe bswap macros on all architectures

2011-12-16 Thread Thorsten Glaser
Aurelien Jarno dixit: I have dropped it in favor of the default version for the next upload. Why don’t you just use these? (Tested for 32-bit and 64-bit both.) I’ve not looked at other architectures atm though. --- usr/include/m68k-linux-gnu/bits/byteswap.h~ 2011-12-17 02:44:08.0 +