Bug#855606: marked as done (sqrt() regression on powerpc/jessie)

[Debian Bug Tracking System]

Your message dated Tue, 25 Apr 2017 19:47:13 +
with message-id 
and subject line Bug#855606: fixed in glibc 2.19-18+deb8u8
has caused the Debian Bug report #855606,
regarding sqrt() regression on powerpc/jessie
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
855606: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=855606
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: libc6
Version: 2.19-18+deb8u7
Severity: normal
Tags: jessie

The following C program produces different output on Jessie and Sid. I
believe the Sid output is the correct one, and in fact this is the
output that has been observed for the "point" (and "polygon")
regression tests for PostgreSQL on all platforms for the last 20 years
since the test got added.


$ cat sqrt.c
#include 
#include 
#include 

double
pg_hypot(double x, double y)
{
double  yx;

/* Some PG-specific code deleted here */

/* Else, drop any minus signs */
x = fabs(x);
y = fabs(y);

/* Swap x and y if needed to make x the larger one */
if (x < y)
{
double  temp = x;

x = y;
y = temp;
}

/*
 * If y is zero, the hypotenuse is x.  This test saves a few cycles in
 * such cases, but more importantly it also protects against
 * divide-by-zero errors, since now x >= y.
 */
if (y == 0.0)
return x;

/* Determine the hypotenuse */
yx = y / x;
return x * sqrt(1.0 + (yx * yx));
}


int main ()
{
//fesetround(FE_TONEAREST);
printf("fegetround is %d\n", fegetround());
double r = pg_hypot(10.0, 10.0);
printf("14 %.14g\n", r);
printf("15 %.15g\n", r);
printf("16 %.16g\n", r);
printf("17 %.17g\n", r);
return 0;
}


Jessie output:
fegetround is 0
14 14.142135623731
15 14.1421356237309
16 14.14213562373095
17 14.142135623730949

Sid output:
fegetround is 0
14 14.142135623731
15 14.142135623731
16 14.14213562373095
17 14.142135623730951


The Sid output is also observed when running the binary compiled on
Jessie on Sid, so it's a library issue, not a compiler/binary one.


The problem might be due to the fix for #843904.


FTBFS in postgresql-9.4 in jessie-pu:
https://buildd.debian.org/status/fetch.php?pkg=postgresql-9.4=powerpc=9.4.11-0%2Bdeb8u1=1487473754=0
FTBFS in postgresql-9.6 in jessie-backports:
https://buildd.debian.org/status/fetch.php?pkg=postgresql-9.6=powerpc=9.6.1-2~bpo8%2B1=1485184696=0

Thread on pgsql-hackers:
https://www.postgresql.org/message-id/20170220155819.m2s43pf2pvkes4pc%40msg.credativ.de

Christoph


signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: glibc
Source-Version: 2.19-18+deb8u8

We believe that the bug you reported is fixed in the latest version of
glibc, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 855...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Aurelien Jarno  (supplier of updated glibc package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Format: 1.8
Date: Mon, 24 Apr 2017 06:41:38 +0200
Source: glibc
Binary: libc-bin libc-dev-bin glibc-doc glibc-source locales locales-all nscd 
multiarch-support libc6 libc6-dev libc6-dbg libc6-pic libc6-udeb libc6.1 
libc6.1-dev libc6.1-dbg libc6.1-pic libc6.1-udeb libc0.3 libc0.3-dev 
libc0.3-dbg libc0.3-pic libc0.3-udeb libc0.1 libc0.1-dev libc0.1-dbg 
libc0.1-pic libc0.1-udeb libc6-i386 libc6-dev-i386 libc6-sparc libc6-dev-sparc 
libc6-sparc64 libc6-dev-sparc64 libc6-s390 libc6-dev-s390 libc6-amd64 
libc6-dev-amd64 libc6-powerpc libc6-dev-powerpc libc6-ppc64 libc6-dev-ppc64 
libc6-mips32 libc6-dev-mips32 libc6-mipsn32 libc6-dev-mipsn32 libc6-mips64 
libc6-dev-mips64 libc0.1-i386 libc0.1-dev-i386 libc6-x32 libc6-dev-x32 
libc6-i686 libc6-xen libc0.1-i686 libc0.3-i686 libc0.3-xen libc6.1-alphaev67 
libc6-loongson2f libnss-dns-udeb libnss-files-udeb
Architecture: source all
Version: 2.19-18+deb8u8
Distribution: stable
Urgency: medium
Maintainer: Aurelien Jarno 
Changed-By: Aurelien Jarno 
Description:
 

Bug#861183: [PATCH] redact the build directory out of the glibc-source tarball paths

[Aurelien Jarno]

On 2017-04-25 15:46, Andrew Shadura wrote:
> Package: glibc-source
> Version: 2.24-10
> Severity: important

I fail to see why it is an important bug, IMHO it should be minor or
normal.

> Tags: patch
> Control: affects -1 cross-toolchain-base
> X-Debbugs-Cc: Aurelien Jarno 
> 
> Hi,
> 
> We’re building a downstream distribution based on Debian using OBS, and
> it unpacks packages differently than Debian buildds do.

I guess you don't use the default directory created by dpkg-source.

> When the tarball for glibc-source package is being created, the
> directory name where the package is unpacked may be captured by tar and
> embedded into the tarball paths. On its own it may cause further
> inconvenience when unpacking the tarball, but quite a practical downside
> of that is that one of the Debian packages in affected by
> this: cross-toolchain-base fails to unpack glibc tarball, or more
> precisely, unpacks it into a different directory compared to what it
> expects, and the build fails.
> 
> This patch mitigates this issue, replacing the glibc-source tarball path
> prefix with glibc-$(GLIBC_VERSION) using tar’s --xform option.

Thanks for the patch, it looks fine. That said I guess we actually avoid
adding the unpack directory to GLIBC_SOURCES and transforming that.

I'll look at that when applying the patch, after the freeze.

-- 
Aurelien Jarno  GPG: 4096R/1DDD8C9B
aurel...@aurel32.net http://www.aurel32.net


signature.asc
Description: PGP signature

Bug#861026: both kernel and glibc want s64 not long (s32)

[Aurelien Jarno]

Control: reassign -1 glibc-doc-reference

On 2017-04-24 08:15, Martin Pitt wrote:
> Control: retitle -1 fix documentation of struct timespec' tv_nsec type
> 

The glibc package doesn't provide the documentation as it is non-free. I
am therefore reassigning the bug to the corresponding package.

-- 
Aurelien Jarno  GPG: 4096R/1DDD8C9B
aurel...@aurel32.net http://www.aurel32.net

Processed: Re: Bug#861026: both kernel and glibc want s64 not long (s32)

[Debian Bug Tracking System]

Processing control commands:

> reassign -1 glibc-doc-reference
Bug #861026 [libc6-dev] fix documentation of struct timespec' tv_nsec type
Bug reassigned from package 'libc6-dev' to 'glibc-doc-reference'.
No longer marked as found in versions glibc/2.24-10.
Ignoring request to alter fixed versions of bug #861026 to the same values 
previously set

-- 
861026: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=861026
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#861183: [PATCH] redact the build directory out of the glibc-source tarball paths

[Andrew Shadura]

Package: glibc-source
Version: 2.24-10
Severity: important
Tags: patch
Control: affects -1 cross-toolchain-base
X-Debbugs-Cc: Aurelien Jarno 

Hi,

We’re building a downstream distribution based on Debian using OBS, and
it unpacks packages differently than Debian buildds do.

When the tarball for glibc-source package is being created, the
directory name where the package is unpacked may be captured by tar and
embedded into the tarball paths. On its own it may cause further
inconvenience when unpacking the tarball, but quite a practical downside
of that is that one of the Debian packages in affected by
this: cross-toolchain-base fails to unpack glibc tarball, or more
precisely, unpacks it into a different directory compared to what it
expects, and the build fails.

This patch mitigates this issue, replacing the glibc-source tarball path
prefix with glibc-$(GLIBC_VERSION) using tar’s --xform option.


-- 
Cheers,
  Andrew
From 66d1d2d072055613fc3ce83820dea1733377b401 Mon Sep 17 00:00:00 2001
From: Andrew Shadura 
Date: Tue, 25 Apr 2017 15:33:45 +0200
Subject: [PATCH] debian/rules.d/build.mk: redact the build directory out of
 the tarball paths

When the tarball for glibc-source package is being created, the
directory name where the package is unpacked may be captured by tar
and embedded into the tarball paths. This may cause further inconvenience
when unpacking the tarball. One of the Debian packages in affected by
this: cross-toolchain-base fails to unpack glibc tarball.

To mitigate the issue, replace the glibc-source tarball path prefix with
glibc-$(GLIBC_VERSION).

Signed-off-by: Andrew Shadura 
---
 debian/rules.d/build.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/rules.d/build.mk b/debian/rules.d/build.mk
index 1e9174e5..792d27c2 100644
--- a/debian/rules.d/build.mk
+++ b/debian/rules.d/build.mk
@@ -324,6 +324,7 @@ $(stamp)source: $(stamp)patch
 			--mode=go=rX,u+rw,a-s \
 			--clamp-mtime --mtime "@$(SOURCE_DATE_EPOCH)" \
 			--owner=root --group=root --numeric-owner \
+			--xform='s=^[^/]*\/=glibc-$(GLIBC_VERSION)/=' \
 			-f $(CURDIR)/$(build-tree)/glibc-$(GLIBC_VERSION).tar.xz
 	mkdir -p debian/glibc-source/usr/src/glibc
 	tar cf - --files-from debian/glibc-source.filelist \
-- 
2.11.0



signature.asc
Description: OpenPGP digital signature

Processed: [PATCH] redact the build directory out of the glibc-source tarball paths

[Debian Bug Tracking System]

Processing control commands:

> affects -1 cross-toolchain-base
Bug #861183 [glibc-source] [PATCH] redact the build directory out of the 
glibc-source tarball paths
Added indication that 861183 affects cross-toolchain-base

-- 
861183: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=861183
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems