Re: Help with cmake / Qt5 migration needed

2017-10-21 Thread Alexis Murzeau
2017-10-20 11:03 GMT+02:00 Andreas Tille : > > but I'm somehow missing some proper -I option to tell gcc where to seek > for the qt5 includes. I'm afraid that the cmake configuration was not > fully successful. Any further hints? > According to [1], #include should work.

Re: C++ help needed (Was: Help with cmake / Qt5 migration needed)

2017-10-21 Thread Juhani Numminen
Hi Andreas, Andreas Tille kirjoitti 21.10.2017 klo 09:22: Hi Juhani, thanks a lot for your help. I'm happy to help you. On Fri, Oct 20, 2017 at 08:41:35PM +0300, Juhani Numminen wrote: I think that's the build system sorted, even though the compilation still fails. Now you probably need

Re: C++ help needed (Was: Help with cmake / Qt5 migration needed)

2017-10-21 Thread Andreas Tille
Hi Juhani, thanks a lot for your help. On Fri, Oct 20, 2017 at 08:41:35PM +0300, Juhani Numminen wrote: > > I think that's the build system sorted, even though the compilation still > fails. Now you probably need to add some includes. I was able to add the said includes but somehow this

Re: Help with cmake / Qt5 migration needed

2017-10-20 Thread Alexis Murzeau
2017-10-20 11:03 GMT+02:00 Andreas Tille : > > but I'm somehow missing some proper -I option to tell gcc where to seek > for the qt5 includes. I'm afraid that the cmake configuration was not > fully successful. Any further hints? > According to [1], #include should work.

Re: C++ help needed (Was: Help with cmake / Qt5 migration needed)

2017-10-20 Thread Juhani Numminen
Hi Andreas, Andreas Tille kirjoitti 20.10.2017 klo 18:41: Hi Juhani, On Fri, Oct 20, 2017 at 06:14:02PM +0300, Juhani Numminen wrote: -TARGET_LINK_LIBRARIES( qtbeads ${QT_LIBRARIES} ... +TARGET_LINK_LIBRARIES( qtbeads Qt::Widgets ...>> I can't see that line in the patch at [1]

Re: C++ help needed (Was: Help with cmake / Qt5 migration needed)

2017-10-20 Thread Andreas Tille
Hi Juhani, On Fri, Oct 20, 2017 at 06:14:02PM +0300, Juhani Numminen wrote: > > I think I fixed this by removing the code copy of CImg.h and using the > > Debian packaged version instead. But the QDebug issue came back and > > may be I need another trick to tweak src/qtbeads/CMakeLists.txt that

Re: C++ help needed (Was: Help with cmake / Qt5 migration needed)

2017-10-20 Thread Juhani Numminen
Andreas Tille kirjoitti 20.10.2017 klo 15:29: > Hi again, > > On Fri, Oct 20, 2017 at 11:55:22AM +0200, Wout B wrote: >> It looks like the initial #include was actually correct and that >> it indeed doesn't find it somehow. Manually adding Qt5::Core and >> Qt5::Widgets to target_link_libraries

C++ help needed (Was: Help with cmake / Qt5 migration needed)

2017-10-20 Thread Andreas Tille
Hi again, On Fri, Oct 20, 2017 at 11:55:22AM +0200, Wout B wrote: > It looks like the initial #include was actually correct and that > it indeed doesn't find it somehow. Manually adding Qt5::Core and > Qt5::Widgets to target_link_libraries seems to work though. I can confirm that this helps -

Re: Help with cmake / Qt5 migration needed

2017-10-20 Thread Wout B
It looks like the initial #include was actually correct and that it indeed doesn't find it somehow. Manually adding Qt5::Core and Qt5::Widgets to target_link_libraries seems to work though. Then there's still some error (declaration of 'float t' shadows template parameter), but I don't know how

Re: Help with cmake / Qt5 migration needed

2017-10-20 Thread Andreas Tille
Hi again, On Fri, Oct 20, 2017 at 10:30:08AM +0200, Wout B wrote: > Shouldn't it be #include ? I may be wrong though. I replaced all instances of '#include ' by '#include ' and the error now occures in some other file (not sure whether this is by chance due to parallel build): cd

Re: Help with cmake / Qt5 migration needed

2017-10-20 Thread Wout B
Shouldn't it be #include ? I may be wrong though. Op 19 okt. 2017 10:41 p.m. schreef "Andreas Tille" : On Thu, Oct 19, 2017 at 07:18:45PM +0200, Wout B wrote: > Have you added the LinguistTools component too? I think it depends on that. Ahhh, another step forward and I fixed

Re: Help with cmake / Qt5 migration needed

2017-10-20 Thread Alexis Murzeau
Hi, Le 19/10/2017 18:56, Andreas Tille a écrit : > Hi Andrey, > > On Thu, Oct 19, 2017 at 07:16:47PM +0500, Andrey Rahmatullin wrote: >> On Thu, Oct 19, 2017 at 04:11:49PM +0200, Andreas Tille wrote: >>> The FIND_PACKAGE line was patched by me where I naively did >>> >>>s/Qt4 REQUIRED/Qt5

Re: Help with cmake / Qt5 migration needed

2017-10-19 Thread Andreas Tille
On Thu, Oct 19, 2017 at 07:18:45PM +0200, Wout B wrote: > Have you added the LinguistTools component too? I think it depends on that. Ahhh, another step forward and I fixed some more in [1]. Now the configuration seems to be finalised but I get: ... cd

Re: Help with cmake / Qt5 migration needed

2017-10-19 Thread Andreas Tille
Hi Andrey, On Thu, Oct 19, 2017 at 07:16:47PM +0500, Andrey Rahmatullin wrote: > On Thu, Oct 19, 2017 at 04:11:49PM +0200, Andreas Tille wrote: > > The FIND_PACKAGE line was patched by me where I naively did > > > >s/Qt4 REQUIRED/Qt5 REQUIRED/ > find_package(Qt5 REQUIRED COMPONENTS Core

Re: Help with cmake / Qt5 migration needed

2017-10-19 Thread Andrey Rahmatullin
On Thu, Oct 19, 2017 at 04:11:49PM +0200, Andreas Tille wrote: > I'd like to package beads[1] which is Qt4 but since Qt4 will be droped > soon my goal is to port it to Qt5. With my current packaging attempt[1] > I get: > > CMake Error at src/CMakeLists.txt:4 (FIND_PACKAGE): > Found package

Help with cmake / Qt5 migration needed

2017-10-19 Thread Andreas Tille
Hi, I'd like to package beads[1] which is Qt4 but since Qt4 will be droped soon my goal is to port it to Qt5. With my current packaging attempt[1] I get: CMake Error at src/CMakeLists.txt:4 (FIND_PACKAGE): Found package configuration file: