Re: RFS: dhcp-probe, another try to request with a lot of update

Hi! [...] I'll grab the package from mentors.d.n later on this weekend and report back. Sorry that it took so long, but now I got around to do another round of review. - The unpacked source contains dhcp-probe.debhelper.log - control/Description has some strange whitespace, please clean

Re: RFS: dhcp-probe, another try to request with a lot of update

[...] OK, OK, i think that is not the cleaner method to run a rm -rf on a file which doesn't exist but if you want, and if it is the usage in debian project, i will do This is definitely a minor issue, but I'm just trying to get you to follow at the very least the KISS principle (keep it

Re: RFS: dhcp-probe, another try to request with a lot of update

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Michael Tautschnig a écrit : Hi Laurent, [...] I've started another review of your package. The following things jumped at me immediately (just tried to build the package using dpkg-buildpackage): ===

Re: RFS: dhcp-probe, another try to request with a lot of update

Hi Laurent, [...] I've started another review of your package. The following things jumped at me immediately (just tried to build the package using dpkg-buildpackage): === dpkg-buildpackage snippet == make: Circular distclean - clean dependency

Re: RFS: dhcp-probe, another try to request with a lot of update

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Sorry for mistake. I use a personnal script to create the package and run lintian, display report... and there are some bugs in :-( A correct version had been uploaded on mentors.debian.net. Sorry again for this mistake but i have to learn ;)

Re: RFS: dhcp-probe, another try to request with a lot of update

[...] A new version of the package is available which integrates all updates you noticed. I controlled all files twice but an error or anything else could be hidden in. You will find all links need to reach the package on mentors.debian.net The package can be found on

Re: RFS: dhcp-probe, another try to request with a lot of update

On Wed, Dec 03, 2008 at 04:14:06PM -0800, Michael Tautschnig wrote: [...] A new version of the package is available which integrates all updates you noticed. I controlled all files twice but an error or anything else could be hidden in. You will find all links need to reach the

Re: RFS: dhcp-probe, another try to request with a lot of update

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi mentors, Neil Williams a écrit : On Sat, 29 Nov 2008 13:37:25 +0100 Laurent Guignard [EMAIL PROTECTED] wrote: I thought it was a cleaner method to test the file exists before running a command on, but may be i am wrong ? The test is okay,

Re: RFS: dhcp-probe, another try to request with a lot of update

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Matthew Palmer a écrit : On Sat, Nov 29, 2008 at 01:37:48PM +0100, Laurent Guignard wrote: I have another question about architecture : How is it possible to check if a package could be built on architecture without the appropriate hardware ? I

Re: RFS: dhcp-probe, another try to request with a lot of update

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Michal Čihař a écrit : Hi Most of things were already answered in Matthews reply, I only react on missing things. Dne Thu, 27 Nov 2008 22:14:56 +0100 Laurent Guignard [EMAIL PROTECTED] napsal(a): - debian/rules: - rm -f can not fail,

Re: RFS: dhcp-probe, another try to request with a lot of update

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Matthew Palmer a écrit : On Thu, Nov 27, 2008 at 10:14:56PM +0100, Laurent Guignard wrote: Michal ??iha?? a écrit : Hi [...] Quick look at the package: - any reason why it is Architecture: i386? In reason of the libraries dependency.

Re: RFS: dhcp-probe, another try to request with a lot of update

On Sat, 29 Nov 2008 13:37:25 +0100 Laurent Guignard [EMAIL PROTECTED] wrote: I thought it was a cleaner method to test the file exists before running a command on, but may be i am wrong ? The test is okay, but why do you invoke debian/rules? If you need config.status to be up to date,

Re: RFS: dhcp-probe, another try to request with a lot of update

On Sat, 29 Nov 2008 13:37:48 +0100 Laurent Guignard [EMAIL PROTECTED] wrote: I have another question about architecture : How is it possible to check if a package could be built on architecture without the appropriate hardware ? As long as all the dependencies exist on all the available

Re: RFS: dhcp-probe, another try to request with a lot of update

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Neil Williams a écrit : On Sat, 29 Nov 2008 13:37:48 +0100 Laurent Guignard [EMAIL PROTECTED] wrote: I have another question about architecture : How is it possible to check if a package could be built on architecture without the appropriate

Re: RFS: dhcp-probe, another try to request with a lot of update

[...] On the upstream README file, Irwin said that : This version runs on Solaris 9 on SPARC, compiled with gcc. So for me, dhcp-probe could be built on this platform. I haven't any possibility to test the package on this type of architecture and i haven't any assigned sponsor too. If

Re: RFS: dhcp-probe, another try to request with a lot of update

On Sat, Nov 29, 2008 at 01:37:48PM +0100, Laurent Guignard wrote: I have another question about architecture : How is it possible to check if a package could be built on architecture without the appropriate hardware ? I can say that dhcp-probe could be build on i386 and any compatible

Re: RFS: dhcp-probe, another try to request with a lot of update

On Sat, 29 Nov 2008 21:38:53 +0100 Laurent Guignard [EMAIL PROTECTED] wrote: It has to build on sparc, you are required to ensure that it does by fixing any FTBFS bugs that appear and those will provide a lot of the information you need to fix the bug. In that case, your sponsor can help

Re: RFS: dhcp-probe, another try to request with a lot of update

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, I just upload on mentors.debian.net a new version of the package with several update according to previous comments. You could find below my answers/explanation for each comment. The package can be found on mentors.debian.net: - - URL:

Re: RFS: dhcp-probe, another try to request with a lot of update

On Thu, Nov 27, 2008 at 10:14:56PM +0100, Laurent Guignard wrote: Michal ??iha?? a écrit : Hi [...] Quick look at the package: - any reason why it is Architecture: i386? In reason of the libraries dependency. libnet1 package is for i386 architecture and dhcp_probe use it

Re: RFS: dhcp-probe, another try to request with a lot of update

Hi Most of things were already answered in Matthews reply, I only react on missing things. Dne Thu, 27 Nov 2008 22:14:56 +0100 Laurent Guignard [EMAIL PROTECTED] napsal(a): - debian/rules: - rm -f can not fail, so you can strip some useless test commands - test ! -f Makefile ||

Re: RFS: dhcp-probe, another try to request with a lot of update

Hi Dne Tue, 25 Nov 2008 07:43:58 -0800 Michael Tautschnig [EMAIL PROTECTED] napsal(a): [...] - debian/README.source content should be rather in debian/README.Debian I think this is not entirely true: - First paragraph in there is ok (dhcp-probe for Debian) But it IMHO does not bring

RFS: dhcp-probe, another try to request with a lot of update

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Dear mentors, I am looking for a sponsor for my package dhcp-probe. * Package name: dhcp-probe Version : 1.2.2-1 Upstream Author : Irwin Tillman (irwin AT princeton DOT edu) * URL :

Re: RFS: dhcp-probe, another try to request with a lot of update

Hi Dne Tue, 25 Nov 2008 14:21:00 +0100 Laurent Guignard [EMAIL PROTECTED] napsal(a): The package can be found on mentors.debian.net: - - URL: http://mentors.debian.net/debian/pool/main/d/dhcp-probe - - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free

Re: RFS: dhcp-probe, another try to request with a lot of update

[...] - debian/README.source content should be rather in debian/README.Debian I think this is not entirely true: - First paragraph in there is ok (dhcp-probe for Debian) - Second paragraph should mostly be moved (Special usecase, but not the last sentence, which is not relevant for our