Re: scikit-learn testing migration

2022-08-13 Thread PICCA Frederic-Emmanuel
Hello Andreas, > When looking at the rules file I noticed that we currently exclude > (more or less randomly) certain tests for certain architectures. > So I had two options: > 1. Simply add the other failing tests > 2. Ignore all failures but print the failures into the build logs what about

Re: scikit-learn testing migration

2022-08-13 Thread Andreas Tille
Hi Nilesh, Am Sat, Aug 13, 2022 at 02:13:05PM +0530 schrieb Nilesh Patra: > > Considering long term maintainance this does not seem to be nice especially > keeping in mind the fact that sklearn is a key package. For sure it is not nice. > I think it is OK to do it _for the moment_ to allow the

Re: scikit-learn testing migration

2022-08-13 Thread Nilesh Patra
On 8/13/22 13:34, Andreas Tille wrote: The drawback of this solution is that we will not get any warning for new *potentially more important* issues since all test failures will be ignored now. For me this is outweighted by the advantage that we can present upstream a full log of all issues in

Re: scikit-learn testing migration

2022-08-13 Thread Andreas Tille
Hi again, Am Thu, Aug 04, 2022 at 01:25:42PM +0200 schrieb Andreas Tille: > Am Fri, Jul 29, 2022 at 06:09:26AM +0200 schrieb Andreas Tille: > Before we fall into another "do nothing" period: I will upload > scikit-learn restricted to those architectures only which have all tests > passing and