[jira] Commented: (DERBY-1474) Add assertEquals overloads for Blob and Clob

2006-07-07 Thread Andreas Korneliussen (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1474?page=comments#action_12419657 ] Andreas Korneliussen commented on DERBY-1474: - I think the new patch ('derby-1474-2b.diff') is fine and can be committed. Add assertEquals overloads for Blob and

[jira] Commented: (DERBY-1474) Add assertEquals overloads for Blob and Clob

2006-07-07 Thread Knut Anders Hatlen (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1474?page=comments#action_12419669 ] Knut Anders Hatlen commented on DERBY-1474: --- Committed derby-1474-2b.diff into trunk with revision 419848. Add assertEquals overloads for Blob and Clob

[jira] Commented: (DERBY-1474) Add assertEquals overloads for Blob and Clob

2006-07-06 Thread Andreas Korneliussen (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1474?page=comments#action_12419526 ] Andreas Korneliussen commented on DERBY-1474: - Just some minor comments (sorry I did not catch this earlier), however I guess these comments can be addressed in

[jira] Commented: (DERBY-1474) Add assertEquals overloads for Blob and Clob

2006-07-06 Thread Knut Anders Hatlen (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1474?page=comments#action_12419589 ] Knut Anders Hatlen commented on DERBY-1474: --- Hi Kristian, I think your approach is good. I have a couple of comments about your BaseTestCase.generateError() method.

[jira] Commented: (DERBY-1474) Add assertEquals overloads for Blob and Clob

2006-07-06 Thread Andreas Korneliussen (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-1474?page=comments#action_12419596 ] Andreas Korneliussen commented on DERBY-1474: - I do not think it is a problem to let the assertBlob(..) method throw checked exceptions. It is an assert method