[jira] Commented: (DERBY-2493) Use unsynchronized collections in BackingStoreHashtable

2007-03-29 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485109 ] Knut Anders Hatlen commented on DERBY-2493: --- Committed the test changes with revision 523621. Use

[jira] Commented: (DERBY-2493) Use unsynchronized collections in BackingStoreHashtable

2007-03-29 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485170 ] Knut Anders Hatlen commented on DERBY-2493: --- Committed derby-2493-aggregate with revision 523691. Use

[jira] Commented: (DERBY-2493) Use unsynchronized collections in BackingStoreHashtable

2007-03-29 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485191 ] Bryan Pendleton commented on DERBY-2493: I read (can't find the reference, sorry) that switching to use of

[jira] Commented: (DERBY-2493) Use unsynchronized collections in BackingStoreHashtable

2007-03-29 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485198 ] Knut Anders Hatlen commented on DERBY-2493: --- In my experience, things have become much better, especially

[jira] Commented: (DERBY-2493) Use unsynchronized collections in BackingStoreHashtable

2007-03-28 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484857 ] Knut Anders Hatlen commented on DERBY-2493: --- Replacing the Hashtable with a HashMap was trivial, but

[jira] Commented: (DERBY-2493) Use unsynchronized collections in BackingStoreHashtable

2007-03-28 Thread Knut Anders Hatlen (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484860 ] Knut Anders Hatlen commented on DERBY-2493: --- It seems like the ordering is already a problem in

Re: [jira] Commented: (DERBY-2493) Use unsynchronized collections in BackingStoreHashtable

2007-03-28 Thread Mike Matrigali
it depends on what the test is testing, but I usually consider these ordering dependencies a test bug - ie. they are counting on an order not specified by SQL. For .sql tests there are usually 2 possible fixes: 1) If what is being tested is not affected by adding an order by to the query, I

[jira] Commented: (DERBY-2493) Use unsynchronized collections in BackingStoreHashtable

2007-03-28 Thread Andrew McIntyre (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484923 ] Andrew McIntyre commented on DERBY-2493: Thanks for the review, Knut! I appreciate it. checkDistinctRows