[jira] Commented: (DERBY-280) Wrong result from select when aliasing to same name as used in group by

2005-12-01 Thread Satheesh Bandaram (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-280?page=comments#action_12359116 ] Satheesh Bandaram commented on DERBY-280: - Thanks Kathey... Your comment explains what you were refering to. There was a potential regression that was found and fixed

[jira] Commented: (DERBY-280) Wrong result from select when aliasing to same name as used in group by

2005-11-30 Thread Kathey Marsden (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-280?page=comments#action_12358932 ] Kathey Marsden commented on DERBY-280: -- I was wondering was there another bug filed for the regression introduced by the patch? I did not see one linked to this issue.

[jira] Commented: (DERBY-280) Wrong result from select when aliasing to same name as used in group by

2005-11-30 Thread Satheesh Bandaram (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-280?page=comments#action_12358935 ] Satheesh Bandaram commented on DERBY-280: - What regression? I don't know of any regression introduced by this patch. Let me know if there is one. RICK, assuming

[jira] Commented: (DERBY-280) Wrong result from select when aliasing to same name as used in group by

2005-11-30 Thread Kathey Marsden (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-280?page=comments#action_12358945 ] Kathey Marsden commented on DERBY-280: -- In an earlier comment you mentioned a valid query which worked before the patch which now fails with: ij select a+1 as a, a+1 as

Re: [jira] Commented: (DERBY-280) Wrong result from select when aliasing to same name as used in group by

2005-11-30 Thread Francois Orsini
There was a reported of a possible NPE in a particular code path and condition which Satheesh identified - I remember Rick fixing it and re-running the tests...On 11/30/05, Kathey Marsden (JIRA) derby-dev@db.apache.org wrote: [

Re: [jira] Commented: (DERBY-280) Wrong result from select when aliasing to same name as used in group by

2005-11-17 Thread Rick Hillegas
Hi Satheesh, I fixed the npe you spotted and attached the updated patch to the JIRA issue. This is ready for you to commit when you have a moment. Thanks, -Rick

[jira] Commented: (DERBY-280) Wrong result from select when aliasing to same name as used in group by

2005-11-17 Thread Satheesh Bandaram (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-280?page=comments#action_12357918 ] Satheesh Bandaram commented on DERBY-280: - I have submitted this fix to trunk. Please Resolve and Close the bug after confirming the fix. I have added a comment to

Re: [jira] Commented: (DERBY-280) Wrong result from select when aliasing to same name as used in group by

2005-11-17 Thread Satheesh Bandaram
Hi Rick, This is committed now. Thanks for addressing all issues. Satheesh Rick Hillegas wrote: Hi Satheesh, I fixed the npe you spotted and attached the updated patch to the JIRA issue. This is ready for you to commit when you have a moment. Thanks, -Rick

Re: [jira] Commented: (DERBY-280) Wrong result from select when aliasing to same name as used in group by

2005-11-17 Thread Rick Hillegas
Thanks, Satheesh! Satheesh Bandaram (JIRA) wrote: [ http://issues.apache.org/jira/browse/DERBY-280?page=comments#action_12357918 ] Satheesh Bandaram commented on DERBY-280: - I have submitted this fix to trunk. Please Resolve and Close the bug

Re: [jira] Commented: (DERBY-280) Wrong result from select when aliasing to same name as used in group by

2005-11-15 Thread Knut Anders Hatlen
Satheesh Bandaram (JIRA) derby-dev@db.apache.org writes: [ http://issues.apache.org/jira/browse/DERBY-280?page=comments#action_12357654 ] Satheesh Bandaram commented on DERBY-280: - Rick, what have you decided about this patch? Would you like

[jira] Commented: (DERBY-280) Wrong result from select when aliasing to same name as used in group by

2005-11-15 Thread Satheesh Bandaram (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-280?page=comments#action_12357757 ] Satheesh Bandaram commented on DERBY-280: - Thanks for updating the patch, Rick. But I think I found one issue, that definitely need fixing. I should have seen these at

[jira] Commented: (DERBY-280) Wrong result from select when aliasing to same name as used in group by

2005-11-14 Thread Satheesh Bandaram (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-280?page=comments#action_12357654 ] Satheesh Bandaram commented on DERBY-280: - Rick, what have you decided about this patch? Would you like me to commit this? As I mentioned, I believe, this patch

[jira] Commented: (DERBY-280) Wrong result from select when aliasing to same name as used in group by

2005-11-11 Thread Kathey Marsden (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-280?page=comments#action_12357377 ] Kathey Marsden commented on DERBY-280: -- I t hink it would be important to talk about this in the Release Notes.I really like the error message because it tells users

[jira] Commented: (DERBY-280) Wrong result from select when aliasing to same name as used in group by

2005-11-10 Thread Satheesh Bandaram (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-280?page=comments#action_12357306 ] Satheesh Bandaram commented on DERBY-280: - I have briefly looked at your patch... While not addressing the underlying problem, the patch attempts to improve the

[jira] Commented: (DERBY-280) Wrong result from select when aliasing to same name as used in group by

2005-11-10 Thread Satheesh Bandaram (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-280?page=comments#action_12357307 ] Satheesh Bandaram commented on DERBY-280: - In case you are planning on submitting a new enhanced patch, please update your client... Patch can't be applied as

[jira] Commented: (DERBY-280) Wrong result from select when aliasing to same name as used in group by

2005-11-10 Thread Rick Hillegas (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-280?page=comments#action_12357313 ] Rick Hillegas commented on DERBY-280: - It is true that, given this patch, that edge case will raise an error. The query would have to be rewritten as the error message

[jira] Commented: (DERBY-280) Wrong result from select when aliasing to same name as used in group by

2005-11-10 Thread Satheesh Bandaram (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-280?page=comments#action_12357330 ] Satheesh Bandaram commented on DERBY-280: - I agree the patch is not fixable to make this query work... Your patch currently assumes two instances of expressions are

[jira] Commented: (DERBY-280) Wrong result from select when aliasing to same name as used in group by

2005-11-02 Thread Rick Hillegas (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-280?page=comments#action_12356646 ] Rick Hillegas commented on DERBY-280: - From my reading of Part 2 of the ANSI spec, this syntax should be disallowed: select i, count(*) as i from tt group by i; This

[jira] Commented: (DERBY-280) Wrong result from select when aliasing to same name as used in group by

2005-11-02 Thread Rick Hillegas (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-280?page=comments#action_12356658 ] Rick Hillegas commented on DERBY-280: - Hm, I'm afraid these illegal relations (relations with identically named columns) turn up everywhere. Disallowing them is not going

[jira] Commented: (DERBY-280) Wrong result from select when aliasing to same name as used in group by

2005-11-02 Thread Satheesh Bandaram (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-280?page=comments#action_12356660 ] Satheesh Bandaram commented on DERBY-280: - I agree... I was just doing research to find all places where Derby does handle identical names. JDBC spec actually

[jira] Commented: (DERBY-280) Wrong result from select when aliasing to same name as used in group by

2005-11-02 Thread Francois Orsini (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-280?page=comments#action_12356678 ] Francois Orsini commented on DERBY-280: --- Would it help to allow a numeric expression in the GROUP BY clause to (force) indicate which column to use in the result table?

[jira] Commented: (DERBY-280) Wrong result from select when aliasing to same name as used in group by

2005-06-11 Thread Satheesh Bandaram (JIRA)
[ http://issues.apache.org/jira/browse/DERBY-280?page=comments#action_12313377 ] Satheesh Bandaram commented on DERBY-280: - I think this problem is caused because of rewriting of group by clause and having multiple result columns with same name. (i