[
http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12449848 ]
Suresh Thalamati commented on DERBY-801:
Hi Anders,
I agree with Knut, this issue can be marked as fixed, Thanks a lot for
working on this
[
http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12446607 ]
Knut Anders Hatlen commented on DERBY-801:
--
I couldn't build the jar files with this patch because the build system
expected
[
http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12446609 ]
Knut Anders Hatlen commented on DERBY-801:
--
if we agree that closing a container that is being dropped while IO is still
active on it is sane, it
[
http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12446767 ]
Knut Anders Hatlen commented on DERBY-801:
--
Thanks Anders. I committed DERBY-801-6.patch with revision 470573.
I'm not sure checking for the committed
[
http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12446493 ]
Anders Morken commented on DERBY-801:
-
Maybe moving the committedDropState check to the start of writePage and
skipping the write altogether if it is in that
[
http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12443179 ]
Knut Anders Hatlen commented on DERBY-801:
--
Army Brown reported an intermittent assert failure in a comment to DERBY-1976.
It is probably related to this
[
http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12443260 ]
Øystein Grøvlen commented on DERBY-801:
---
I saw the above error when developing the LobLengthTest, but it went away after
I made some changes to the test.
[
http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12443338 ]
Anders Morken commented on DERBY-801:
-
Yeah, looks like I've let in some critters. I'll give it a bit of a kickin' and
see if I can figure it out. =)
Allow
[
http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12443040 ]
Knut Anders Hatlen commented on DERBY-801:
--
I'm wondering whether we should change the DEBUG_PRINT calls to
ASSERT/THROWASSERT. Falling back to the old
[
http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12435677 ]
Anders Morken commented on DERBY-801:
-
Suresh, Knut Anders, thanks for your advice. There's no need to rush this patch
for my part, I'll be happy to provide a
[
http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12435752 ]
Knut Anders Hatlen commented on DERBY-801:
--
Committed v4 into trunk with revision 447815. Fixed Suresh's comments 1-3 in
RAFContainer4 before committing.
[
http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12435798 ]
Knut Anders Hatlen commented on DERBY-801:
--
Backed out the changes for DERBY-733 with the following commands:
svn merge -r 357275:357274 .
svn merge -r
Suresh Thalamati (JIRA):
[
http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12434613
]
Suresh Thalamati commented on DERBY-801:
Thanks for working on this issue, Anders. I really like your solution to solve
Anders Morken wrote:
Suresh Thalamati (JIRA):
[ http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12434613 ]
snip ..
RAFContainerFactory.java
Logic in this new class seems to be deciding whether to load RafContainer.java
or
the
[
http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12435610 ]
Suresh Thalamati commented on DERBY-801:
Hi Knut ,
Patch is good. It is ok with me , if you would like to commit the current
patch and let Anders
[
http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12434965 ]
Knut Anders Hatlen commented on DERBY-801:
--
I will hold the commit until Anders has responded to the questions from Suresh.
1, 2 and 3 seem like trivial
[
http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12434613 ]
Suresh Thalamati commented on DERBY-801:
Thanks for working on this issue, Anders. I really like your solution to solve
this issue. Patch is very good, I
Suresh Thalamati (JIRA) derby-dev@db.apache.org writes:
4) I noticed, there is new encryption buffer created on every
writePage() call, if the database is encrypted. This may cause jvm
peak memory usage increase, when there is a checkpoint, if there are
lot of dirty pages in the cache and if
[
http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12430262 ]
Anders Morken commented on DERBY-801:
-
Oh, and yes, it still passes tests. storeall ran flawlessly, derbyall failed in
the derbynetmats suite's
[
http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12429015 ]
Knut Anders Hatlen commented on DERBY-801:
--
Hi Anders,
Thank you for working on this issue! I have looked at your patch, and
my impression is that your
[
http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12429018 ]
Knut Anders Hatlen commented on DERBY-801:
--
When this fix gets into the codeline, the fix for DERBY-733 could be backed out.
Allow parallel access to
Anders Morken (JIRA) wrote:
[ http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12413541 ]
Anders Morken commented on DERBY-801:
-
I've found a benchmark to test this patch with, and quite frankly I'm not seeing any difference in
[
http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12413841 ]
Øystein Grøvlen commented on DERBY-801:
---
I have run our tpc-b like benchmark on with and without your patch on a 2-CPU
opteron box with 2 local disks running Linux.
[
http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12413925 ]
Anders Morken commented on DERBY-801:
-
Ooh, very cool to see those numbers. Thanks for testing it despite my
pessimism. I probably haven't been running the benchmark I
[
http://issues.apache.org/jira/browse/DERBY-801?page=comments#action_12413541 ]
Anders Morken commented on DERBY-801:
-
I've found a benchmark to test this patch with, and quite frankly I'm not
seeing any difference in throughput between my patch and
25 matches
Mail list logo
