[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ https://issues.apache.org/jira/browse/DERBY-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Matrigali updated DERBY-210: - Urgency: Normal Triaged July 10, 2009: assigned normal urgency. Network Server will leak

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Kathey Marsden updated DERBY-210: - Version: 10.0.2.0 Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Derby Info: (was: [Patch Available]) I had been working on this issue and had unassigned myself after completing the work I intended to do (covered in sub-task

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Andrew McIntyre updated DERBY-210: -- Other Info: (was: [Patch available]) Derby Info: [Patch Available] Network Server will leak prepared statements if not explicitly closed by the

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Assign To: (was: Deepa Remesh) I have opened a sub-task (DERBY-1103) for the work I have done for this issue for 10.2. I am unassigning myself from

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] John H. Embretsen updated DERBY-210: Attachment: runtimeinfo_DOTS-OOME.txt I attached runtimeinfo_DOTS-OOME.txt, which is runtimeinfo (org.apache.derby.drda.NetworkServerControl

Re: [jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

Deepa Remesh wrote: Thanks for the update. Here is how I interpreted the test results from John's mails and comments at https://issues.apache.org/jira/browse/DERBY-210#action_12364800

Re: [jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

Deepa Remesh wrote: Thanks John for uploading your repro. I have not been able to look at it closely as jira seems to be having problems again. I was wondering if you have the results from your DOTS test. Please post if you have any updates. Actually, the DOTS test failed, i.e. the network

Re: [jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

John Embretsen wrote: Deepa Remesh wrote: Thanks John for uploading your repro. I have not been able to look at it closely as jira seems to be having problems again. I was wondering if you have the results from your DOTS test. Please post if you have any updates. Actually, the DOTS test

Re: [jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

On 3/7/06, John Embretsen [EMAIL PROTECTED] wrote: Deepa Remesh wrote: Thanks John for uploading your repro. I have not been able to look at it closely as jira seems to be having problems again. I was wondering if you have the results from your DOTS test. Please post if you have any

Re: [jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

On 3/3/06, John H. Embretsen (JIRA) derby-dev@db.apache.org wrote: [ http://issues.apache.org/jira/browse/DERBY-210?page=all ] John H. Embretsen updated DERBY-210: Attachment: StatementStress.java Uploaded my repro (StatementStress.java) for

Re: [jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

Bryan Pendleton wrote: Meanwhile, I noticed in John's message earlier today that he has been able to build a specialized test to stress test this area of the system: I created a smaller stand-alone application inspired by the really bad parts of the DOTS test John, is it worth

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] John H. Embretsen updated DERBY-210: Attachment: StatementStress.java Uploaded my repro (StatementStress.java) for this issue. The repro is an independent Java program with elements

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Attachment: derby-210-patch5-v1.diff derby-210-patch5-v1.status Attaching a patch 'derby-210-patch5-v1.diff' which removes the actual memory

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Attachment: derby-210-patch4-v3.diff derby-210-patch4-v3.status Attaching a patch 'derby-210-patch4-v3.diff'. In this patch, I synched upto

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Other Info: [Patch available] Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Kathey Marsden updated DERBY-210: - Comment: was deleted Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Other Info: (was: [Patch available]) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Other Info: [Patch available] Description: Network server will not garbage collect prepared statements that are not explicitly closed by the user. So a

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Attachment: derby-210-patch4-v2.diff derby-210-patch4-v2.status Attaching a patch 'derby-210-patch4-v2.diff' which fixes the finalization code in

Re: [jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

Deepa Remesh updated DERBY-210: Looks great! Thanks for all the hard work on this bug. bryan

Re: [jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

On 2/12/06, Bryan Pendleton [EMAIL PROTECTED] wrote: Deepa Remesh (JIRA) wrote: I am attaching a draft patch 'derby-210-v2-draft.diff' for review. Hi Deepa, I studied this patch for a while, focusing specifically on your bullet points 8, 9, and 10. The changes look good to me, and I think

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Attachment: derby-210-patch3.diff Attaching 'derby-210-patch3.diff' which changes method DRDAStatement.close() in Network Server. The following line is added to

Re: [jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

Deepa Remesh (JIRA) wrote: Attaching 'derby-210-patch3.diff' which changes method DRDAStatement.close() in Network Server. Looks great. Thanks for adding the comment there, too. bryan

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Attachment: derby-210-patch4.diff derby-210-patch4.status Attaching 'derby-210-patch4.diff' which changes the finalizer method in Statement and

Re: [jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

Deepa Remesh (JIRA) wrote: Just before submitting this, I was re-reading the patch and noticed there is no need to override close and closeX method in PreparedStatement since these methods are doing exactly same things as the methods in Statement class. Hi Deepa, I looked at your new patch4

Re: [jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

A trivial nit: there appears to be an unnecessary whitespace diff at line 2066 of PreparedStatement.java now: @@ -2039,7 +2066,7 @@^M } } parameters_ = null; - + connection_.CommitAndRollbackListeners_.remove(this); } thanks, bryan

Re: [jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

On 2/13/06, Bryan Pendleton [EMAIL PROTECTED] wrote: Deepa Remesh (JIRA) wrote: Just before submitting this, I was re-reading the patch and noticed there is no need to override close and closeX method in PreparedStatement since these methods are doing exactly same things as the methods in

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Attachment: (was: derby-210-patch4.diff) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Attachment: (was: derby-210-patch4.status) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Attachment: (was: derby-210.diff) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Attachment: (was: derby-210.status) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Attachment: derby-210-patch1.diff Attaching a patch 'derby-210-patch1.diff' which removes the list 'RollbackOnlyListeners_' from

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Attachment: derby-210-patch2.diff derby-210-patch2.status Attaching second patch 'derby-210-patch2.diff' which adds a test to jdbcapi suite for

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Attachment: derby-210-v2-draft.diff derby-210-v2-draft.status I am attaching a draft patch 'derby-210-v2-draft.diff' for review. It is not ready

Re: [jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

John Embretsen wrote: I suspect there will be other issues that are uncovered by running the DOTS test case (or variations of it) with various configurations, but they may or may not be related to this particular issue. I will certainly let you know as soon as possible if I notice any memory

Re: [jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

Bryan Pendleton wrote: This is *excellent* news! Can you tell, at this point, whether there is a secondary leak that we must additionally pursue? That is, does it seem as though, if we are able to incorporate the DERBY-210 fixes into the base product, we will be able to run DOTS without memory

Re: [jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

In other words, the patch seems to provide significant improvement to Derby robustness with regards to cases where statements are not always explicitly closed by the application using the Derby client. The garbage collector is able to collect much more garbage with the patch than without.

Re: [jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

I hope this patch gets (re-)committed once the current issues are resolved. Thanks John for running tests with the patch and posting results. I have been trying to create a repro for the sporadic problem which occured after commiting this patch. After few unsuccessful attempts, I put it on hold

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Attachment: (was: derby-210_10.1.diff) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Attachment: (was: derby-210_10.1.status) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Attachment: derby-210_10.1.diff derby-210_10.1.status Attaching a patch 'derby-210_10.1.diff' for 10.1 branch. I could not merge the changes

Re: [jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

On 1/15/06, Bryan Pendleton [EMAIL PROTECTED] wrote: Deepa Remesh (JIRA) wrote: I have attached a partial patch 'derby-210-patch1.diff' for this problem. Hello Deepa, I was interested to read your patch because I have been trying to learn how the client code works. Thanks Bryan for

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Attachment: (was: derby-210-patch1.diff) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Attachment: (was: derby-210-patch1.status) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Attachment: derby-210.diff derby-210.status I am uploading a combined patch 'derby-210.diff' which solves the memory leak. As Bryan suggested, I

Re: [jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

Deepa Remesh (JIRA) derby-dev@db.apache.org writes: * Adds a test 'derbyStress.java' to jdbcapi suite. This test is based on the repro for this patch. Without this patch, it fails when run with client driver. Kathey had suggested in another mail that tests for client memory leak problems

Re: [jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

Deepa Remesh (JIRA) wrote: I have attached a partial patch 'derby-210-patch1.diff' for this problem. Hello Deepa, I was interested to read your patch because I have been trying to learn how the client code works. After reading your patch, I had a few small questions: 1) I was a bit surprised

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Comment: was deleted Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Deepa Remesh updated DERBY-210: --- Attachment: derby-210-patch1.diff derby-210-patch1.status I have attached a partial patch 'derby-210-patch1.diff' for this problem. It does not

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=all ] Kathey Marsden updated DERBY-210: - Component: Network Client (was: Network Server) This is actually a client issue. There is no protocol in the specification to close a

[jira] Updated: (DERBY-210) Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed

[ http://issues.apache.org/jira/browse/DERBY-210?page=history ] Kathey Marsden updated DERBY-210: - Attachment: derbyStress.java Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed