[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-06-11 Thread Harshvardhan Gupta (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046056#comment-16046056 ] Harshvardhan Gupta commented on DERBY-6935: --- Yes, the latest commit looks good. I am resolving

[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-06-10 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045717#comment-16045717 ] Bryan Pendleton commented on DERBY-6935: Thanks again for catching this. Can you re-check the

[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-06-10 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045716#comment-16045716 ] ASF subversion and git services commented on DERBY-6935: Commit 1798340 from

[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-06-10 Thread Harshvardhan Gupta (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045702#comment-16045702 ] Harshvardhan Gupta commented on DERBY-6935: --- Bryan, Yes the 'moreCycleTests.diff' contains the

[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-06-10 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045567#comment-16045567 ] Bryan Pendleton commented on DERBY-6935: I see now that I missed some of your tests when working

[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-06-10 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045566#comment-16045566 ] Bryan Pendleton commented on DERBY-6935: Did we add tests covering the behavior of

[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-06-10 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045558#comment-16045558 ] Bryan Pendleton commented on DERBY-6935: OK, let me look more closely; I probably fumbled the

[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-06-10 Thread Harshvardhan Gupta (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045556#comment-16045556 ] Harshvardhan Gupta commented on DERBY-6935: --- No, the recent changes to

[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-06-10 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045553#comment-16045553 ] Bryan Pendleton commented on DERBY-6935: Yes, I believe those were committed as part of Commit

[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-06-10 Thread Harshvardhan Gupta (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045551#comment-16045551 ] Harshvardhan Gupta commented on DERBY-6935: --- Hi Bryan, I added some catalog tests too in

[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-06-09 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045314#comment-16045314 ] ASF subversion and git services commented on DERBY-6935: Commit 1798290 from

[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-06-09 Thread Harshvardhan Gupta (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16044865#comment-16044865 ] Harshvardhan Gupta commented on DERBY-6935: --- Bryan, I do think that we should go ahead and

[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-06-09 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1606#comment-1606 ] Bryan Pendleton commented on DERBY-6935: Hi Vardhan, thanks for the updated tests. The new tests

[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-06-03 Thread Harshvardhan Gupta (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036035#comment-16036035 ] Harshvardhan Gupta commented on DERBY-6935: --- Hey Bryan, Yes the tests look good to me and

[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-05-29 Thread Bryan Pendleton (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028615#comment-16028615 ] Bryan Pendleton commented on DERBY-6935: That seems like a good plan to me. Why don't you write

[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-05-29 Thread Harshvardhan Gupta (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028482#comment-16028482 ] Harshvardhan Gupta commented on DERBY-6935: --- Hey Bryan, Since most of the functionality we are

[jira] [Commented] (DERBY-6935) Test Coverage for added features.

2017-05-29 Thread Harshvardhan Gupta (JIRA)
[ https://issues.apache.org/jira/browse/DERBY-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028480#comment-16028480 ] Harshvardhan Gupta commented on DERBY-6935: --- The following functionality should be covered as