Re: [junit] Move JUnit base/utility classes???

2006-08-22 Thread Kristian Waagan
Daniel John Debrunner wrote: I don't see any value in this, the existing layput looks fine to me. org.apache.derbyTesting.junit.functionalTests.tests.jdbcapi org.apache.derbyTesting.junit.unitTests.lang org.apache.derbyTesting.junit.systemTests.app1 (future) (Note: existing layout does not

Re: [junit] Move JUnit base/utility classes???

2006-08-22 Thread Andreas Korneliussen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Kristian Waagan wrote: Hi, I still have a question regarding the placement of JUnit tests. I have brought this up before, but got very little response (I did get some, see below). Do we want to support [unit] testing of package private

Re: [junit] Move JUnit base/utility classes???

2006-08-22 Thread Kristian Waagan
Andreas Korneliussen wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Kristian Waagan wrote: Hi, I still have a question regarding the placement of JUnit tests. I have brought this up before, but got very little response (I did get some, see below). Do we want to support [unit] testing

Re: [junit] Move JUnit base/utility classes???

2006-08-22 Thread Daniel John Debrunner
Andreas Korneliussen wrote: I think there are some testclasses which are in the same source tree as the derby source, however the .class files are packaged into dergbyTesting.jar. I.e: org/apache/derby/impl/drda/TestProto.class I think that class should be moved into the derbyTesting area

Re: [junit] Move JUnit base/utility classes???

2006-08-22 Thread Daniel John Debrunner
Kristian Waagan wrote: Andreas Korneliussen wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Kristian Waagan wrote: Hi, I still have a question regarding the placement of JUnit tests. I have brought this up before, but got very little response (I did get some, see below). Do

Re: [junit] Move JUnit base/utility classes???

2006-08-22 Thread Kristian Waagan
Daniel John Debrunner wrote: Kristian Waagan wrote: Andreas Korneliussen wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Kristian Waagan wrote: Hi, I still have a question regarding the placement of JUnit tests. I have brought this up before, but got very little response (I did get

Re: [junit] Move JUnit base/utility classes???

2006-08-16 Thread Andreas Korneliussen
David Van Couvering wrote: Sounds good to me... David Daniel John Debrunner wrote: Currently the JUnit base and utility classes are in this package: org.apache.derbyTesting.functionTests.util (See http://wiki.apache.org/db-derby/DerbyJUnitTesting) I was wondering if they should be moved,

Re: [junit] Move JUnit base/utility classes???

2006-08-16 Thread Daniel John Debrunner
Andreas Korneliussen wrote: David Van Couvering wrote: Sounds good to me... David Daniel John Debrunner wrote: Currently the JUnit base and utility classes are in this package: org.apache.derbyTesting.functionTests.util (See http://wiki.apache.org/db-derby/DerbyJUnitTesting) I was

Re: [junit] Move JUnit base/utility classes???

2006-08-16 Thread Andreas Korneliussen
The functional tests would continue to live in their current location, just that the super-class BaseJDBCTestCase would be in the new package. Thoughts? I support moving the utility classes to a new package. Below are some thoughts on how Junit tests could be structured, in case we would like

Re: [junit] Move JUnit base/utility classes???

2006-08-16 Thread Daniel John Debrunner
I don't see any value in this, the existing layput looks fine to me. org.apache.derbyTesting.junit.functionalTests.tests.jdbcapi org.apache.derbyTesting.junit.unitTests.lang org.apache.derbyTesting.junit.systemTests.app1 (future) (Note: existing layout does not have .junit.) (sorry copy

[junit] Move JUnit base/utility classes???

2006-08-15 Thread Daniel John Debrunner
Currently the JUnit base and utility classes are in this package: org.apache.derbyTesting.functionTests.util (See http://wiki.apache.org/db-derby/DerbyJUnitTesting) I was wondering if they should be moved, for two reasons: 1) That package is cluttered up with other stuff, it's more or less a

Re: [junit] Move JUnit base/utility classes???

2006-08-15 Thread David Van Couvering
Sounds good to me... David Daniel John Debrunner wrote: Currently the JUnit base and utility classes are in this package: org.apache.derbyTesting.functionTests.util (See http://wiki.apache.org/db-derby/DerbyJUnitTesting) I was wondering if they should be moved, for two reasons: 1) That