Github user twogee commented on the issue:
https://github.com/apache/ant/pull/50
BTW, JUnit license has changed from CPL to EPL.
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands,
Github user twogee commented on the issue:
https://github.com/apache/ant/pull/50
Sorry about confusion ð -- here comes a corrected commit.
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For
+---+
| Bugzilla Bug ID |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned
Github user bodewig commented on the issue:
https://github.com/apache/ant/pull/50
Ant's junit task itself is supposed to work with JUnit 3 not only 4, so it
is not superfluous at all IMHO,
---
-
To unsubscribe,
Github user bodewig commented on the issue:
https://github.com/apache/ant/pull/49
Thanks @jaikiran, I've added a buch of inline comments.
Overall I'm in favor of this change and if you want to spend the time on
fixing the bugzilla issue in a Java5 friendly way for 1.9.x that
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155928363
--- Diff: src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java ---
@@ -30,6 +30,8 @@
* a symbolic link based on the absent support for them in Java.
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155928313
--- Diff: src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java
---
@@ -500,18 +502,12 @@ private void doLink(String res, String lnk) throws
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155928143
--- Diff: src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java
---
@@ -448,49 +432,67 @@ private void handleError(String msg) {
/**
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155928069
--- Diff: src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java
---
@@ -207,26 +198,30 @@ public void recreate() throws BuildException {
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155927463
--- Diff: src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java
---
@@ -207,26 +198,30 @@ public void recreate() throws BuildException {
Github user twogee commented on the issue:
https://github.com/apache/ant/pull/50
Sorry about the whitespace -- I can separate all "drive-by" changes into a
commit on its own.
Could you please elaborate on having both JUnit 3 and 4? JUnit 4 is Java 5
compatible, and most test
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155927271
--- Diff: manual/Tasks/symlink.html ---
@@ -26,7 +26,7 @@
Symlink
Description
- Manages symbolic links on Unix based platforms. Can be used
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155927252
--- Diff: WHATSNEW ---
@@ -27,6 +27,11 @@ Fixed bugs:
copy happened to be the same source file (symlinked back
to itself).
+ * Bugzilla
Github user bodewig commented on the issue:
https://github.com/apache/ant/pull/50
Thank you @twogee
The idea was you can build a minimal set of Ant (without the optional tasks
that have external dependencies) and run the tests for this minimal set without
downloading
GitHub user twogee opened a pull request:
https://github.com/apache/ant/pull/50
Use newer Maven Ant tasks
The initial aim was to avoid NPE when retrieving jasper and automate
retrieval of ant-antunit (with exclusion of ant/ant-launcher).
Then I started wondering whether it
15 matches
Mail list logo
