Re: Ivy release this month?

On 2018-02-18, Gintautas Grigelionis wrote: > 2018-02-18 20:30 GMT+01:00 Stefan Bodewig : >> On 2018-02-18, Gintautas Grigelionis wrote: >>>- https://github.com/apache/ant-ivy/pull/63 (has to do with choice of >>>generics, with are not set in stone yet); >> changes

[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/67#discussion_r168989393 --- Diff: ivy.xml --- @@ -61,6 +61,7 @@ + --- End diff -- strange, thanks. As Ivy uses

Re: Ant support for users who use JUnit5

On 19/02/18 1:37 AM, Stefan Bodewig wrote: On 2018-02-15, Jaikiran Pai wrote: I'm now done with the initial goals that I had in mind for this task. I've opened a PR[1] for review. I've included a manual for this task and it can be currently found here[2]. I would suggest reading the manual

[GitHub] ant issue #60: JUnit 5 support - A new junitlauncher task

Github user asfgit commented on the issue: https://github.com/apache/ant/pull/60 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/39/ ---

[GitHub] ant issue #60: JUnit 5 support - A new junitlauncher task

Github user asfgit commented on the issue: https://github.com/apache/ant/pull/60 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/45/ ---

[GitHub] ant issue #60: JUnit 5 support - A new junitlauncher task

Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/60 @bodewig, Thank you very much for the review. Based on the review comments, I have updated the PR with additional separate commits (for easier reference). I'll be squashing all these commits together

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r168983237 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,139 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

Github user jaikiran commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r168983118 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,139 @@ +package

[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/67#discussion_r168964592 --- Diff: ivy.xml --- @@ -61,6 +61,7 @@ + --- End diff -- Yes. Invocation of Ant runs Ivy's

[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/67#discussion_r168964407 --- Diff: ivy.xml --- @@ -61,6 +61,7 @@ + --- End diff -- to run which unit tests? Ivy's?

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r168964381 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,139 @@ +package

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r168964295 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,139 @@ +package

[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/67#discussion_r168963965 --- Diff: ivy.xml --- @@ -61,6 +61,7 @@ + --- End diff -- If Ant (launcher and core) is

[GitHub] ant pull request #60: JUnit 5 support - A new junitlauncher task

Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant/pull/60#discussion_r168963955 --- Diff: src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java --- @@ -0,0 +1,139 @@ +package

Re: Ant support for users who use JUnit5

On 2018-02-15, Jaikiran Pai wrote: > I'm now done with the initial goals that I had in mind for this > task. I've opened a PR[1] for review. I've included a manual for this > task and it can be currently found here[2]. I would suggest reading > the manual first, before reviewing the PR, since the

[GitHub] ant issue #58: Use StringBuilder instead of StringBuffer as it offers high p...

Github user bodewig commented on the issue: https://github.com/apache/ant/pull/58 The changes to `FixCRLF`, `TaskOutputStream`, `VerifyJar`, `Message`, `TraxLiaison` and `RegexpPatternMapper` all change instance variables of classes that might be used in a mutlithreaded context. In

Re: Ivy release this month?

[Personally I prefer discussion by email over discussion in github issues.] On 2018-02-18, Gintautas Grigelionis wrote: >- https://github.com/apache/ant-ivy/pull/63 (has to do with choice of >generics, with are not set in stone yet); changes the generic type of an argument of a public

[GitHub] ant-ivy pull request #67: IVY-1483 Invoke Ant through Ivy;

Github user bodewig commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/67#discussion_r168961676 --- Diff: ivy.xml --- @@ -61,6 +61,7 @@ + --- End diff -- why has this dependency been

Re: Ivy release this month?

I suggested previously how some of the contentious issues could be dealt with (no response AFAICS). In the meantime, I added the following PRs asking for some discussion - https://github.com/apache/ant-ivy/pull/63 (has to do with choice of generics, with are not set in stone yet); -

[GitHub] ant issue #60: JUnit 5 support - A new junitlauncher task

Github user asfgit commented on the issue: https://github.com/apache/ant/pull/60 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Windows/44/ ---

[GitHub] ant issue #60: JUnit 5 support - A new junitlauncher task

Github user asfgit commented on the issue: https://github.com/apache/ant/pull/60 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Ant%20Github-PR-Linux/38/ ---

Ivy release this month?

Hello everyone, Is there anything I can help with to start off and complete the Ivy release, hopefully this month? As I noted in the dev list mail, I don't plan to include the fix for https://issues.apache.org/jira/browse/IVY-1485 in this release and instead try and tackle it after that. There

New Release(s)?

Hi all https://bz.apache.org/bugzilla/show_bug.cgi?id=62086 is a serious regression in 1.10.2 and it has been fixed in master by now. The 1.9.x branch has never been affected. By now I have reviewed all changes of the really big commit that also caused the regression. I found a few more places