[GitHub] ant pull request #:

Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/1c80d507f496dde98869890e671edf635bef8dec#commitcomment-28426956 In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java: In src/main/org/apache/tools/ant/taskdefs/optional/net/FTP.java

[GitHub] ant pull request #:

Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/1c80d507f496dde98869890e671edf635bef8dec#commitcomment-28426843 In src/main/org/apache/tools/ant/taskdefs/Sync.java: In src/main/org/apache/tools/ant/taskdefs/Sync.java on line 242: I think

[GitHub] ant-ivy issue #71: Ivy main/standalone: Patch to include 'makepom' function

Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/71 @aanno, thank you for this PR. I have gone ahead and included your patch with minor modifications to upstream and also included a test along with it. I have also included your name in our release

Re: File type mapping in external task

Thank you Stefan ! I was a bit afraid of duplicating the logic for String to File mapping, but if it's just about using Project#resolveFile then I'll do it. Gilles On Wed, Apr 4, 2018 at 1:40 PM, Stefan Bodewig wrote: > On 2018-04-03, Gilles Querret wrote: > > > If I have

JunitTestRunner commit

Hi, Since this is more or less my first commit to the Ant codebase, could someone please review my change to JunitTestRunner ?And if all is ok, what is the correct way to merge this into the 1.9.x branch? Maarten

Re: File type mapping in external task

On 2018-04-03, Gilles Querret wrote: > If I have an attribute mapped to a File type (such as setSrcDir(File file) > { this.srcDir = file; } ), then passing an empty string (as in srcDir="" ) leads to srcDir set to baseDir (or current directory, not sure). baseDir :-) > Is there a way to trap