Github user mc1arke commented on the pull request:
https://github.com/apache/ant/pull/5#issuecomment-136161751
@changgengli sorry, I forgot about this and your change now doesn't merge
(I think it just needs master pulled back on to your branch). If you're still
interested
Github user mc1arke commented on the pull request:
https://github.com/apache/ant/pull/5#issuecomment-68174716
Your changes look reasonable from a quick scan of them, and I'm impressed
with the speed you made them. I'll give it a more thorough review once you've
got some tests
Github user mc1arke commented on the pull request:
https://github.com/apache/ant/pull/5#issuecomment-67930586
Some pointers for you:
* You're introducing a runtime dependency on JUnit 4 by referencing a JUnit
class directly. There are still users of Ant who only use JUnit 3, so
