Seros commented on PR #101:
URL: https://github.com/apache/ant-ivy/pull/101#issuecomment-2133442798
Hey ^^ Just wanted to ask when we can expect this change to be merged as it
seems it's the only one left for the [next version
basil opened a new pull request, #210:
URL: https://github.com/apache/ant/pull/210
I am migrating from Commons Compress to Ant for tar/untar functionality,
since new releases of Commons Compress pull in unwanted dependencies, while new
releases of Ant are self-contained. But while doing
jaikiran closed pull request #209: pull
URL: https://github.com/apache/ant/pull/209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
obsfeil opened a new pull request, #209:
URL: https://github.com/apache/ant/pull/209
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lewismc opened a new pull request, #101:
URL: https://github.com/apache/ant-ivy/pull/101
PR to address https://issues.apache.org/jira/browse/IVY-1651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jaikiran merged PR #208:
URL: https://github.com/apache/ant/pull/208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
jaikiran commented on PR #208:
URL: https://github.com/apache/ant/pull/208#issuecomment-1956990993
Thank you Dave for this fix. The change looks correct to me and matches the
`compilerarg` documentation of the `javac` task.
--
This is an automated message from the Apache Git
mebigfatguy opened a new pull request, #208:
URL: https://github.com/apache/ant/pull/208
documentation says the attribute name for is arg, but it's
value. Updated doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mbs-c opened a new pull request, #100:
URL: https://github.com/apache/ant-ivy/pull/100
The namespaces of dependencies' extra attributes were forgotten before
writing them to the cache when a module descriptor was created from scratch.
With this change, namespaced attributes are correctly
mkitti opened a new pull request, #99:
URL: https://github.com/apache/ant-ivy/pull/99
Currenty ivy does not include the classifier as a key for extra information.
This pull request adds classifier to the extra info key.
--
This is an automated message from the Apache Git Service.
To
jaikiran merged PR #207:
URL: https://github.com/apache/ant/pull/207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
tg-freigmbh commented on PR #207:
URL: https://github.com/apache/ant/pull/207#issuecomment-1892275667
Ah I already made an Contribution under a different account, I am Gösen ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
jaikiran commented on PR #207:
URL: https://github.com/apache/ant/pull/207#issuecomment-1892272296
Thank you for the update, looks good to me. Since you are a first time
contributor to Ant, we add your name to the contributors list we maintain in
the repo. Is there a specific first name,
tg-freigmbh commented on code in PR #207:
URL: https://github.com/apache/ant/pull/207#discussion_r1452440245
##
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/LauncherSupport.java:
##
@@ -45,14 +45,7 @@
import
tg-freigmbh commented on PR #207:
URL: https://github.com/apache/ant/pull/207#issuecomment-1892265688
I tried, but my ide realy doesnt like that :D maybe I can do it manually on
github
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
jaikiran commented on code in PR #207:
URL: https://github.com/apache/ant/pull/207#discussion_r1452430883
##
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/LauncherSupport.java:
##
@@ -45,14 +45,7 @@
import
jaikiran commented on PR #207:
URL: https://github.com/apache/ant/pull/207#issuecomment-1892256118
Hello @tg-freigmbh, very good catch. This indeed is an issue. I've added a
trivial comment inline, other than that this looks good.
--
This is an automated message from the Apache Git
tg-freigmbh opened a new pull request, #207:
URL: https://github.com/apache/ant/pull/207
I realized that running tests using ant was much slower than running them
from the IDE. The culprit was the legacy-xml reporter.
mfaquan commented on PR #206:
URL: https://github.com/apache/ant/pull/206#issuecomment-1815320520
> looks good, thank you. We'll also need to change the manual page, which I
can do myself.
>
> If you want to be listed in Ant's contributor's list, please let us know
which name you
bodewig merged PR #206:
URL: https://github.com/apache/ant/pull/206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For
bodewig commented on PR #206:
URL: https://github.com/apache/ant/pull/206#issuecomment-1815261409
looks good, thank you. We'll also need to change the manual page, which I
can do myself.
If you want to be listed in Ant's contributor's list, please let us know
which name you want us
mfaquan commented on PR #206:
URL: https://github.com/apache/ant/pull/206#issuecomment-1815013377
> You are correct and I don't recall why the code works the way it does. But
it has done so for more than 20 years now and changing it might break existing
builds. Let me suggest to introduce
bodewig commented on PR #206:
URL: https://github.com/apache/ant/pull/206#issuecomment-1814953625
You are correct and I don't recall why the code works the way it does. But
it has done so for more than 20 years now and changing it might break existing
builds. Let me suggest to introduce a
mfaquan opened a new pull request, #206:
URL: https://github.com/apache/ant/pull/206
Currently, if an IOException occurs in ReplaceRegExp or a file is missing,
the task logs the error, but does not fail. This pull request has
ReplaceRegExp throw a BuildException if the task encounters an
Cmac299203 commented on PR #201:
URL: https://github.com/apache/ant/pull/201#issuecomment-1793953335
Awesome
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mataha commented on PR #205:
URL: https://github.com/apache/ant/pull/205#issuecomment-1722502639
The pleasure is mine!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jaikiran commented on PR #205:
URL: https://github.com/apache/ant/pull/205#issuecomment-172236
Thank you @mataha for those details. I have now merged this PR and added you
(`Mateusz Kazimierczuk`) as a contributor to our contributors list.
--
This is an automated message from the
asfgit closed pull request #205: Fix `--release` param check in bootstrap.bat
URL: https://github.com/apache/ant/pull/205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mataha commented on PR #205:
URL: https://github.com/apache/ant/pull/205#issuecomment-1722284523
These, of course, can be run on all Windows versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mataha commented on PR #205:
URL: https://github.com/apache/ant/pull/205#issuecomment-1722247407
> Hello @mataha, what you propose here looks OK to me. However, I haven't
been able to reproduce the issue that prompted this change. Is there some
specific Windows version where this can be
jaikiran commented on PR #205:
URL: https://github.com/apache/ant/pull/205#issuecomment-1722169214
Hello @mataha, what you propose here looks OK to me. However, I haven't been
able to reproduce the issue that prompted this change. Is there some specific
Windows version where this can be
jaikiran commented on PR #204:
URL: https://github.com/apache/ant/pull/204#issuecomment-1715096911
Thank you @jmichelberger for this patch, this looks OK to me and I've now
merged it and I have added you to our contributors list. The patch doesn't have
a test case, I'm guessing that you
asfgit closed pull request #204: bz-66552 fix Depend task does not handle
Dynamic constant pool entries - java.lang.ClassFormatError: Invalid Constant
Pool entry Type 17
URL: https://github.com/apache/ant/pull/204
--
This is an automated message from the Apache Git Service.
To respond to
jmichelberger opened a new pull request, #204:
URL: https://github.com/apache/ant/pull/204
In cases the Depend task scans a class file with Constant Pool entry Type
17 there was no handling, just fireing an Exception.
Constant is defined since JDK11, and format is same as InvokeDynamic
jaikiran closed pull request #203: bz-67082 fix unintended trimmed string
output by pathconvert
URL: https://github.com/apache/ant/pull/203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jaikiran commented on PR #203:
URL: https://github.com/apache/ant/pull/203#issuecomment-1710984197
Hello Sebastian, thank you for reporting this issue and providing a fix that
too with a test case. This is a very well done patch. I've merged this and also
included your name in our
sratz opened a new pull request, #203:
URL: https://github.com/apache/ant/pull/203
PropertyOutputStream by default trims output.
This is undesired in the use case. Explicitly set it to false.
Fixes regression introduced in 1.10.13 /
90ed3ff6cca8634e38d7c3c82858ce48c9c4be2b.
stevenschlansker commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1680938966
Thank you very much :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
jaikiran commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1680564559
Ant 1.10.14 (containing this change) is in voting phase if you would like to
try it https://lists.apache.org/thread/th6yrxc4dtpqhc2vnzmrd7d9b881hk4g
--
This is an automated message from the
dependabot[bot] closed pull request #202: Bump xalan:xalan from 2.7.2 to 2.7.3
in /src/etc/poms/ant-apache-xalan2
URL: https://github.com/apache/ant/pull/202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dependabot[bot] commented on PR #202:
URL: https://github.com/apache/ant/pull/202#issuecomment-1680152807
Looks like xalan:xalan is up-to-date now, so this is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
jaikiran commented on PR #122:
URL: https://github.com/apache/ant/pull/122#issuecomment-1676403559
Hello Marc, sorry this took this long. I saw this PR again this week and
what you raise here is a valid bug. I've pushed a commit which should address
this and should be available in our
asfgit closed pull request #122: Bugfix/catch dynamic test before each
URL: https://github.com/apache/ant/pull/122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dependabot[bot] opened a new pull request, #202:
URL: https://github.com/apache/ant/pull/202
Bumps xalan:xalan from 2.7.2 to 2.7.3.
[![Dependabot compatibility
dependabot[bot] opened a new pull request, #201:
URL: https://github.com/apache/ant/pull/201
Bumps xalan:xalan from 2.7.2 to 2.7.3.
[![Dependabot compatibility
jaikiran closed pull request #121: use displayName instead of
legacyReportingName in xml reports
URL: https://github.com/apache/ant/pull/121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jaikiran commented on PR #121:
URL: https://github.com/apache/ant/pull/121#issuecomment-1675840459
I'll go ahead and close this PR since this was already delivered in Ant
1.10.10 release as part of https://bz.apache.org/bugzilla/show_bug.cgi?id=64564
--
This is an automated message from
jaikiran commented on PR #121:
URL: https://github.com/apache/ant/pull/121#issuecomment-1675840246
Hello Vincent @don-vip,
> Can we please get the same output as JUnit 4?
Test.testMethod[displayedName]
I had forgottent about this. But now that I went backed and looked at it,
this
jglick closed pull request #200: Do not treat failure of
`System.setSecurityManager` as fatal
URL: https://github.com/apache/ant/pull/200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jglick commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1675085764
Looks like this is indeed superseded by
689b6ea90ee1fbad580a437137d80609c9336f12 in particular. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message,
jaikiran commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1673554885
Hello Jesse and Steven, I've pushed some commits to master branch which
reverts all the complex/brittle workarounds we had added in Ant 1.10.13 to keep
using SecurityManager.
A fresh
jglick commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1634629922
> it would anyway require an Ant release
Yes, and then for `spotbugs-maven-plugin` to update to that release and cut
its own release.
--
This is an automated message from the Apache
jaikiran commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1633402124
Hello Jesse,
> > are you running these tests by building Ant from source?
>
> @jaikiran why would you ask that? [#200
stevenschlansker commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1633231279
No, I am running the latest spotbugs-maven-plugin release, which uses Ant as
a library. The problem only manifests if you disable forking in the plugin
configuration.
--
This is an
jglick commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1632843378
> are you running these tests by building Ant from source?
@jaikiran why would you ask that?
https://github.com/apache/ant/pull/200#issuecomment-1631658175 reports an error
that looks
didiksupriadi41 closed pull request #97: Remove unused dependencies
URL: https://github.com/apache/ant-ivy/pull/97
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jaikiran commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1631739432
Sorry everyone, my testing with the changes I have is taking longer than
expected. @stevenschlansker, are you running these tests by building Ant from
source? If yes, then I'll go ahead and
arturobernalg closed pull request #165: Use object equals instead of ==, which
does a character-by-character comparison when the strings are different objects
URL: https://github.com/apache/ant/pull/165
--
This is an automated message from the Apache Git Service.
To respond to the message,
arturobernalg closed pull request #163: Make final var when is possible.
URL: https://github.com/apache/ant/pull/163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
apupier closed pull request #62: IVY-1572 - Check for Thread interruption while
resolving resources
URL: https://github.com/apache/ant-ivy/pull/62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
apupier commented on PR #62:
URL: https://github.com/apache/ant-ivy/pull/62#issuecomment-1558743234
long time without progress and no more in my scope of work. Closing. feel
free to reuse my work if needed
--
This is an automated message from the Apache Git Service.
To respond to the
asfgit closed pull request #197: Handling forked VM timeout in a similar way to
junit ant task
URL: https://github.com/apache/ant/pull/197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jaikiran commented on PR #197:
URL: https://github.com/apache/ant/pull/197#issuecomment-1512565293
The change in this PR looks fine to me. A test can be added separately - I
haven't found the time to try and help you get the test implemented/run. I'll
go ahead and merge this now and will
mabartos commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1511152337
@jaikiran Hello, any progress with this issue? Or is there any workaround
for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jaikiran commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1503458393
> > the work we had done in a recent release to set
`java.security.manager=allow` when launching Ant
>
>
jglick commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1503392846
> the work we had done in a recent release to set
`java.security.manager=allow` when launching Ant
82c70f3 I guess. Yes I think it would be appropriate to not even attempt to
call
jaikiran commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1503324250
Hello Jesse, I'm currently in the process of undoing some of the work we had
done in a recent release to set `java.security.manager=allow` when launching
Ant. This change has caused more than
jglick opened a new pull request, #200:
URL: https://github.com/apache/ant/pull/200
Fixes https://github.com/spotbugs/spotbugs-maven-plugin/issues/423. When
running on Java 18+, where `System.setSecurityManager` is not allowed by
default, just let in-process Java execution run without a
tbw777 closed pull request #198: Using static modifier to normalize methods
contract and performance
URL: https://github.com/apache/ant/pull/198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
bodewig commented on PR #199:
URL: https://github.com/apache/ant/pull/199#issuecomment-1446276764
https://bz.apache.org/bugzilla/show_bug.cgi?id=66496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
bodewig commented on PR #199:
URL: https://github.com/apache/ant/pull/199#issuecomment-1446269521
I'll create a bugzilla issue to scan for Resource#toString uses. This change
here is fine as it is and we don't need to clutter it with more discussion.
Thank you for catching this
jaikiran commented on PR #199:
URL: https://github.com/apache/ant/pull/199#issuecomment-1446256401
Hello Stefan,
> Looks as if StringResource printed its contents, but that seems wrong to
me as there may be more places where code expects toString to not reveal the
contents.
bodewig commented on PR #199:
URL: https://github.com/apache/ant/pull/199#issuecomment-1446249553
I wonder what kind of `Resource` this is as `Resource#toString` is expected
to only print the resource's name - and this is what the code here relied on.
Looks as if `StringResource` printed
asfgit closed pull request #199: Use verbose log level for loading stylesheets
URL: https://github.com/apache/ant/pull/199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jaikiran commented on PR #199:
URL: https://github.com/apache/ant/pull/199#issuecomment-1446237933
Thank you for these changes. Looks good to me. I'll merge this shortly.
Since this is your first contribution to the Ant project, I'll be adding
`Christoph Dreis` to our contributors list
dreis2211 commented on code in PR #199:
URL: https://github.com/apache/ant/pull/199#discussion_r1118662584
##
src/main/org/apache/tools/ant/taskdefs/XSLTProcess.java:
##
@@ -1258,7 +1258,7 @@ protected void configureLiaison(final Resource
stylesheet) throws BuildException
jaikiran commented on code in PR #199:
URL: https://github.com/apache/ant/pull/199#discussion_r1118656632
##
src/main/org/apache/tools/ant/taskdefs/XSLTProcess.java:
##
@@ -1258,7 +1258,7 @@ protected void configureLiaison(final Resource
stylesheet) throws BuildException
dreis2211 opened a new pull request, #199:
URL: https://github.com/apache/ant/pull/199
Hi,
I've noticed that working with `checkstyle` via Gradle (probably using it
directly will do the same) we always see the very verbose output of the
stylesheet being loaded. Imho this is not a
tkowalcz commented on PR #197:
URL: https://github.com/apache/ant/pull/197#issuecomment-1436945641
@jaikiran I'm sorry but I was unable to run the tests. After implementing
your instructions the `LegacyXmlResultFormatterTest` was run but there was no
mention of `JUnitLauncherTaskTest`
bodewig commented on PR #198:
URL: https://github.com/apache/ant/pull/198#issuecomment-1422055507
I must say I find it extremely difficult to properly review a PR that
touches 100+ files, even if the change is supposed to be mechanical.
In this case I saw a change to `Antlib.java`
Wade-tech commented on PR #166:
URL: https://github.com/apache/ant/pull/166#issuecomment-1421930331
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
jaikiran commented on PR #166:
URL: https://github.com/apache/ant/pull/166#issuecomment-1421877210
Hello @Wade-tech, it will be present in the ant-jakartamail artifact which
is here https://repo1.maven.org/maven2/org/apache/ant/ant-jakartamail/1.10.13/
--
This is an automated message
Wade-tech commented on PR #166:
URL: https://github.com/apache/ant/pull/166#issuecomment-1421837416
Thanks, JakartaMimeMailer.java use jakarta.mail . I downdload
org.apache.ant-ant-1.10.13
jar(url:https://mvnrepository.com/artifact/org.apache.ant/ant/1.10.13). In this
jar , not found
bodewig commented on PR #166:
URL: https://github.com/apache/ant/pull/166#issuecomment-1421399930
https://ant.apache.org/manual/Tasks/mail.html - Ant 1.10.13.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Wade-tech commented on PR #166:
URL: https://github.com/apache/ant/pull/166#issuecomment-1420290634
Hi ,tomcat10 change javax.* namespace to jakarta.*， Does ant now support
jakarta.mail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
tkowalcz commented on PR #197:
URL: https://github.com/apache/ant/pull/197#issuecomment-1419282632
Thanks. I will give it a try and let you know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jaikiran commented on PR #197:
URL: https://github.com/apache/ant/pull/197#issuecomment-1419267691
> When I build the project the tests do not seem to be executed
Some of the tasks in Ant, including the `junitlauncher` aren't part of the
"core". You will have to first fetch the
tkowalcz commented on PR #197:
URL: https://github.com/apache/ant/pull/197#issuecomment-1419257202
Hi, actually I had problems running the tests in the first place. When I
build the project the tests do not seem to be executed (build pass even when I
introduce failing assertion). I can
jaikiran commented on PR #197:
URL: https://github.com/apache/ant/pull/197#issuecomment-1419253719
Hello Tomasz, I don't want to rush you, but if writing a test is proving to
be time consuming or complicated, do let me know and I'll merge this fix (which
looks good to me) and I'll add a
89 matches
Mail list logo
