[GitHub] ant-ivy issue #43: Generics and other fixes in tests and tutorials

2017-06-13 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/43 Here comes a bunch of new changes: I had to go for Commons Collections 4 to use generics, and threw in Commons CLI 1.4 for a good measure. I left HTTP Client 2.0 for the future lest this PR grows

[GitHub] ant-ivy issue #43: Generics and other fixes in tests and tutorials

2017-06-13 Thread janmaterne
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/43 I wont split this PR. Adress these in this PR: - diamond operator - renaming - ModuleIdTest The other things should be done in a new PR (PRs shouldnt be too big ;) I

[GitHub] ant-ivy issue #43: Generics and other fixes in tests and tutorials

2017-06-13 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/43 Thank you for comments, I'll split the PR and correct according to your suggestions. Should I remove common-colections altogether and use collections with generics from Java runtime? --- If your

[GitHub] ant-ivy issue #43: Generics and other fixes in tests and tutorials

2017-06-13 Thread janmaterne
Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/43 Java7 supports the diamond operator and Ivy's baseline is now Java7. So you could use that (e.g. CCFilter.java). HMFilter: one advantage of foreach is having a meaningful iterator name.