Github user mc1arke commented on the pull request:
https://github.com/apache/ant/pull/5#issuecomment-68174716
Your changes look reasonable from a quick scan of them, and I'm impressed
with the speed you made them. I'll give it a more thorough review once you've
got some tests in.
Github user mc1arke commented on the pull request:
https://github.com/apache/ant/pull/5#issuecomment-67930586
Some pointers for you:
* You're introducing a runtime dependency on JUnit 4 by referencing a JUnit
class directly. There are still users of Ant who only use JUnit 3, so
Github user changgengli commented on the pull request:
https://github.com/apache/ant/pull/5#issuecomment-67999297
Hello Michael,
Except for some tests that prove this feature and protect it in future
changes, all other concerns should have been addressed.
Please let
GitHub user changgengli opened a pull request:
https://github.com/apache/ant/pull/5
My 194
Hello,
This PR is to randomize the excution order the junit test method in the
same class. I came to this idea during the work we are upgrading from java 6 to
java 8. A lot of test
