Re: JunitTestRunner commit

On 2018-04-05, Maarten Coene wrote: > I think I finally got it merged into the 1.9.x branch... yes, looks good. > (Where are the days where everything was so easy with SVN ;-)) I've maintained svn branches long enough to recall merging is a pain regardless of which SCM you use :-) > I did a

[GitHub] ant pull request #:

Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/26c8789a5067809255040d3338235b5ae25a3898#commitcomment-28428974 don't worry. I'm happy Jenkins caught it. --- - To

[GitHub] ant pull request #:

Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/1c80d507f496dde98869890e671edf635bef8dec#commitcomment-28428982 :+1: --- - To unsubscribe, e-mail:

Re: [2/2] ant git commit: Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/ant

Sorry, I have no idea what this is... should it be reverted? (I'm a Git noob and this is something that my IntelliJ git plugin seems to have done). Maarten Van: "maart...@apache.org" Aan: notificati...@ant.apache.org Verzonden: donderdag 5 april 11:33 2018

Re: [2/2] ant git commit: Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/ant

On 2018-04-05, Maarten Coene wrote: > Sorry, I have no idea what this is... should it be reverted? No, you haven't really changed anything. Your "fix typo" commit was based on a version of the master branch that is older than the HEAD at apache as you didn't update your local copy first. When

[GitHub] ant pull request #:

Github user bodewig commented on the pull request: https://github.com/apache/ant/commit/1c80d507f496dde98869890e671edf635bef8dec#commitcomment-28426966 In src/main/org/apache/tools/ant/taskdefs/optional/net/FTPTaskMirrorImpl.java: In

[GitHub] ant pull request #:

Github user twogee commented on the pull request: https://github.com/apache/ant/commit/1c80d507f496dde98869890e671edf635bef8dec#commitcomment-28428804 You're right, there is no concise way to do backwards foreach loops in Java. I will revert them later today. ---

Re: JunitTestRunner commit

On 2018-04-04, Maarten Coene wrote: > Since this is more or less my first commit to the Ant codebase, could > someone please review my change to JunitTestRunner ? Typo in WHATSNEW (until rather than untill). I think the change is good, although I'm not sure whether there is a difference in how

[GitHub] ant pull request #:

Github user twogee commented on the pull request: https://github.com/apache/ant/commit/26c8789a5067809255040d3338235b5ae25a3898#commitcomment-28428779 Sorry about letting this through. getLocationURLs() should be annotated with `@SuppressWarnings("deprecated") `. ---

Re: JunitTestRunner commit

Thanks Stefan for your time and patience :-)I think I finally got it merged into the 1.9.x branch...(Where are the days where everything was so easy with SVN ;-)) I did a little test, and I didn't see a difference compared to 1.10.3 in the error output when a test has a failing static

Re: ant git commit: Tidy up the code

By and large I approve of these changes, but I felt compelled to express the opinion that I do not believe adding else after if/continue does anything to simplify the code. IMO it does the opposite. Matt On Thu, Apr 5, 2018, 1:15 AM wrote: > Repository: ant > Updated