Re: Ant-Ivy: Publish don't pull declared dependencies

2017-08-28 Thread Jaikiran Pai
As far as I know, the publish task itself doesn't fetch any dependencies. The dependencies itself are downloaded by a (previous) resolve task that is invoked separately and explicitly. -Jaikiran On 31/07/17 11:32 PM, maikel van den Hurk wrote: Hi all, I am wondering if there is already

Re: Broken tutorial

2017-08-28 Thread Jaikiran Pai
effort algorithm during install, so that everything gets installed except the missing artifacts. (Note: these missing artifacts are not in the public maven repository due to licensing issues) ... [1] http://ant.apache.org/ivy/history/master/tutorial/build-repository/basic.html -Jaikiran

Re: Broken tutorial

2017-08-31 Thread Jaikiran Pai
On 29/08/17 12:35 PM, Gintautas Grigelionis wrote: I noticed another problem with asciidoc: 1.5.4 fails on my box with the latest Java 8u144, I had to downgrade it to 1.5.3 -- did anyone else see that? 1.5.4 works fine for me with Java 8. -Jaikiran

Ivy - Latest snapshots will now be regularly available in Apache Maven Snapshot repository

2017-08-31 Thread Jaikiran Pai
version) are:     org.apache.ivy     ivy     2.5.0-SNAPSHOT and can be found here https://repository.apache.org/content/groups/snapshots/org/apache/ivy/ivy/2.5.0-SNAPSHOT/ [1] https://builds.apache.org/job/Ivy-Snapshot-Deploy/ [2] https://repository.apache.org/snapshots/ -Jaikiran

Re: new JDK version scheme

2017-11-28 Thread Jaikiran Pai
[1] http://openjdk.java.net/jeps/223 [2] https://docs.oracle.com/javase/9/docs/api/java/lang/Runtime.html#version-- -Jaikiran On 28/11/17 10:10 PM, Stefan Bodewig wrote: On 2017-11-28, Stefan Bodewig wrote: Maybe we really need to start parsing the java.version syste

Re: Build failed in Jenkins: Ant-Build-Matrix-1.9.x-Linux » JDK 1.6 (latest) #134

2017-12-13 Thread Jaikiran Pai
most likely _not_ a coincidence. But given this a JVM crash (in Java 6), it most likely is a JVM issue. I'll see if I can find something on this, before we decide if at all we need to rollback that commit. [1] https://github.com/apache/ant/commit/0fd2a86369aab41db316b1064a559bae08afae0f -Jaikiran

Re: ant git commit: disable a bunch of caches, just so we've tried that as well

2017-12-19 Thread Jaikiran Pai
[exec] [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.276 sec -Jaikiran On 19/12/17 5:02 PM, bode...@apache.org wrote: Repository: ant Updated Branches: refs/heads/master c2c821a38 -> 3dad11d41 disable a bunch of caches, just so we've tried that as w

Re: ant git commit: disable a bunch of caches, just so we've tried that as well

2017-12-19 Thread Jaikiran Pai
On 19/12/17 5:13 PM, Jaikiran Pai wrote: Looking at the JDK code, I still am not sure which exact code path triggers this stale/invalid cache in this specific case, but apparently it does. Now that we know the canonical path cache is playing a role, I think the only way this issue makes

Re: Ant support for users who use JUnit5

2017-12-15 Thread Jaikiran Pai
Thank you. I'm moving ahead with the new proposed task. Hopefully I should be able to have something functional in a few days. -Jaikiran On 14/12/17 5:14 PM, Stefan Bodewig wrote: On 2017-12-14, Jaikiran Pai wrote: With that context, I would like to explain what I have attempted so far

Re: Build failed in Jenkins: Ant-Build-Matrix-1.9.x-Linux » JDK 1.6 (latest) #134

2017-12-13 Thread Jaikiran Pai
It's back to normal [1], so the crash seems to be specific to certain nodes on Jenkins, for Java 6. I don't plan to look more into this. [1] https://builds.apache.org/job/Ant-Build-Matrix-1.9.x-Linux/jdk=JDK%201.6%20(latest)/135/ -Jaikiran On 13/12/17 8:40 PM, Jaikiran Pai wrote: So we

Re: Github ant repo now integrated with Jenkins for pull request testing

2017-12-13 Thread Jaikiran Pai
On 12/12/17 8:05 PM, Jaikiran Pai wrote: The next few days, I'll probably try and see if I can get a Linux based job to run alongside this Windows job for PRs. We now have a Linux one too for the PRs https://builds.apache.org/job/Ant%20Github-PR-Linux/. It has the same characteristics

Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

2017-12-12 Thread Jaikiran Pai
Do let me know if there's anything I can do to help investigate this. I'm curious myself to see what's causing this. -Jaikiran On 13/12/17 2:56 AM, Stefan Bodewig wrote: On 2017-12-12, Stefan Bodewig wrote: On 2017-12-12, Jaikiran Pai wrote: So the one final test that's still failing

Re: Ant support for users who use JUnit5

2017-12-14 Thread Jaikiran Pai
by changing the internal implementation detail of this task (and maybe removing support for certain attributes). Either way, I would still like to hear others thoughts on this. -Jaikiran On 14/12/17 3:39 PM, Jaikiran Pai wrote: I've started some experiments in adding support for the recently

Ant support for users who use JUnit5

2017-12-14 Thread Jaikiran Pai
  [1] http://junit.org/junit5/ [2] https://bz.apache.org/bugzilla/show_bug.cgi?id=61796 [3] https://github.com/jaikiran/ant/commit/42c7f221a8cd0848df0a2d6cac2897c07d446bda -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...

Re: ant git commit: logs say "link has been created", is it a timing issue?

2017-12-19 Thread Jaikiran Pai
which check that file1 exists. Furthermore, given that this is manifesting for all the links in that properties file, it looks a very generic issue and not just to this specific "link1" symlink. To make it much more weird, if I run this exact same state of "master" branch, by jus

Re: [2/2] ant-ivy git commit: No need to synchronise a concurrent map

2017-11-01 Thread Jaikiran Pai
removed, it no longer guarantees the entire block to be done serially by a single thread anymore. -Jaikiran On 02/11/17 2:50 AM, gin...@apache.org wrote: No need to synchronise a concurrent map Project: http://git-wip-us.apache.org/repos/asf/ant-ivy/repo Commit: http://git-wip-us.apache.org

Re: ant-ivy git commit: tidy up the code

2017-12-08 Thread Jaikiran Pai
inconsistent when someone adding new code using a different construct (like not using explicit brackets), but it's not that big a deal, IMO. -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For a

Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

2017-12-10 Thread Jaikiran Pai
You are right, that indeed was the issue (for one of that failing test). I have pushed a commit with this change to fix that one. -Jaikiran On 10/12/17 3:13 PM, Stefan Bodewig wrote: On 2017-12-10, Stefan Bodewig wrote: testCreateDoubleHanging is related to https://bz.apache.org/bugzilla

Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

2017-12-10 Thread Jaikiran Pai
I'll investigate why this is failing (local tests pass for me) and fix it. -Jaikiran On 10/12/17 2:29 PM, Apache Jenkins Server wrote: See <https://builds.apache.org/job/Ant-Build-Matrix-master-Linux/jdk=JDK%201.8%20(latest)/977/display/redirect?page=chan

Potential breaking change to symlink task [ was Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977]

2017-12-10 Thread Jaikiran Pai
On 10/12/17 3:09 PM, Stefan Bodewig wrote: On 2017-12-10, Jaikiran Pai wrote: I'll investigate why this is failing (local tests pass for me) and fix it. Target testCreateOverFile in the antunit test explicitly tries to replace a file with a link, doing exactly what the bugzilla report says

Re: Potential breaking change to symlink task [ was Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977]

2017-12-11 Thread Jaikiran Pai
of changes, I am willing to undo them and go back to the original state that was before I started these changes. [1] https://github.com/apache/ant/commit/b3c7d5dc451960986a94d24785a2c1d24b0b0d6a -Jaikiran On 10/12/17 5:15 PM, Stefan Bodewig wrote: [@Steve I'm trying to drag you

Re: Potential breaking change to symlink task [ was Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977]

2017-12-11 Thread Jaikiran Pai
. Done. The documentation of symlink task is now updated https://github.com/apache/ant/commit/485b92fe7494c5473e019329cbf7a33e556acad6 -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e

Github ant repo now integrated with Jenkins for pull request testing

2017-12-12 Thread Jaikiran Pai
/ -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

Re: Please ignore the github emails for the next hour or so

2017-12-12 Thread Jaikiran Pai
My experiments have completed [1] and any new mails from github/jenkins jobs are genuine mails. Hopefully, the next time I try something around this, it won't take these many spurious mails. [1] https://www.mail-archive.com/dev@ant.apache.org/msg46284.html -Jaikiran On 12/12/17 7:05 PM

Re: Jenkins build became unstable: Ant-Build-Matrix-master-Linux » JDK 1.8 (latest) #977

2017-12-12 Thread Jaikiran Pai
/org.apache.tools.ant.taskdefs.optional.unix/SymlinkTest/testRecreate/ -Jaikiran On 10/12/17 3:13 PM, Stefan Bodewig wrote: On 2017-12-10, Stefan Bodewig wrote: testCreateDoubleHanging is related to https://bz.apache.org/bugzilla/show_bug.cgi?id=38199 judging from the history. Here the link points to a non-existent file

Please ignore the github emails for the next hour or so

2017-12-12 Thread Jaikiran Pai
Sorry about the continuous mails from github/ant repo. I'm (yet again) trying to get the Jenkins job integrated with Ant github repo. I don't have a way to disable these mails while I experiment with it to get it right. Hopefully, it should be sorted out in the next hour or so. -Jaikiran

Re: ant-ivy git commit: IVY-1420 document current implementation [Forced Update!]

2017-10-21 Thread Jaikiran Pai
Let's not force update the upstream repo please, especially the real branches like the master branch. -Jaikiran On 21/10/17 10:22 PM, gin...@apache.org wrote: Repository: ant-ivy Updated Branches: refs/heads/master 744c31824 -> 2074889ec (forced update) IVY-1420 document curr

delete task with a wildcard "file"

2017-12-20 Thread Jaikiran Pai
s expected that it should work even with file="*.something" then let me know, I'll undo this change and see how I can fix the regression. -Jaikiran On 21/12/17 10:21 AM, jaiki...@apache.org wrote: Repository: ant Updated Branches: refs/heads/master 1a2c33fd0 -> ca91b859f Fix a

Re: delete task with a wildcard "file"

2017-12-20 Thread Jaikiran Pai
On 21/12/17 10:42 AM, Stefan Bodewig wrote: On 2017-12-21, Jaikiran Pai wrote: I committed this change below, to use a resource collection to allow the build to pass, which had started failing on Windows, after I did a recent change to the delete task to use Java 7 java.nio.file.Files API

Re: ant depends task fails for JDK10 module-info.class

2018-05-12 Thread Jaikiran Pai
Looks like a bug. Can you file a bug in the Ant bugzilla? I can take a look at it later tonight. -Jaikiran On 12/05/18 4:45 PM, Simon IJskes wrote: Hi, Just checking if this bug is known? I could not find it in bugzilla. https://issues.apache.org/jira/browse/NETBEANS-781 Groeten, Simon

Re: ant depends task fails for JDK10 module-info.class

2018-05-12 Thread Jaikiran Pai
should be available here[2]. [1] https://github.com/apache/ant/commit/d0f9c2e121e2b3a18b679705c2f2164426e7e6fb [2] https://builds.apache.org/job/Ant_Nightly/lastSuccessfulBuild/artifact/distribution/ it works! Glad to hear that :) -Jaikiran

Re: ant depends task fails for JDK10 module-info.class

2018-05-12 Thread Jaikiran Pai
://github.com/apache/ant/commit/d0f9c2e121e2b3a18b679705c2f2164426e7e6fb [2] https://builds.apache.org/job/Ant_Nightly/lastSuccessfulBuild/artifact/distribution/ -Jaikiran On 12/05/18 5:30 PM, Jaikiran Pai wrote: Looks like a bug. Can you file a bug in the Ant bugzilla? I can take a look at it later

Re: [GitHub] ant pull request #:

2018-05-13 Thread Jaikiran Pai
No problem. That change to WHATSNEW is fine, I don't mind. -Jaikiran On 13/05/18 1:03 PM, Gintautas Grigelionis wrote: Thanks, great work! I hope you don't mind me taking the liberty to adjust WHATSNEW. Gintas 2018-05-13 6:01 GMT+02:00 Jaikiran Pai <jai.forums2...@gmail.com>: I di

Re: [GitHub] ant pull request #:

2018-05-12 Thread Jaikiran Pai
on. -Jaikiran On 12/05/18 9:19 PM, twogee wrote: Github user twogee commented on the pull request: https://github.com/apache/ant/commit/d0f9c2e121e2b3a18b679705c2f2164426e7e6fb#commitcomment-28953469 In src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-18 Thread Jaikiran Pai
0ae82f0d11171b2#diff-21eb59eaf9f2b5d0b487aeb5e5022ccdL888 [5] https://github.com/apache/ant/commit/070c3bc86f85e8f01cb624fe50ae82f0d11171b2#diff-21eb59eaf9f2b5d0b487aeb5e5022ccdL1359 [6] https://github.com/apache/ant/commit/070c3bc86f85e8f01cb624fe50ae82f0d11171b2#diff-b98a3d2097d6a9b5d7e0fc2eac033f24L348 -Jaikiran

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-17 Thread Jaikiran Pai
it into some other form (thus additional code plus additional objects allocated in the process), all this to iterate over it and run some logic on it - all of which was already possible with the enumeration that was already available. -Jaikiran On 18/05/18 12:22 AM, Gintautas Grigelionis

Re: [1/2] ant git commit: Deprecate CollectionUtils and Enumerations; reduce explicit use of Enumeration

2018-05-17 Thread Jaikiran Pai
I agree. Especially when it's being done on something like for archive entries which can betoo many depending on the archive that is being dealt with. -Jaikiran On 17/05/18 12:04 PM, Maarten Coene wrote: Converting an Enumeration to a List just for iterating it doesn't seem performance

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-16 Thread Jaikiran Pai
Thanks Stefan, I'll fix these issues and send out a new voting mail. -Jaikiran On Saturday, June 16, 2018, Stefan Bodewig wrote: > Hi > > please add your PGP key to dist.apache.org/release/ant/KEYS > > * checksums and signatures are good > * for the files in updatesite it s

[CANCEL] [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-16 Thread Jaikiran Pai
Given some of the valid issues that Stefan has raised with this released instance, I'm cancelling this vote. This is a first release after a long time and I plan to have this as clean as possible. I will send out a new vote mail once I sort out these issues. -Jaikiran On 16/06/18 6:48 PM

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-14 Thread Jaikiran Pai
On 14/06/18 11:50 AM, Stefan Bodewig wrote: On 2018-06-13, Jaikiran Pai wrote: You can download the distribution from this URL: https://dist.apache.org/repos/dist/dev/ant/ivyde/2.3.0-rc1 Be the releas policy that is in place now SHA1 is deprecated, MD5 is frowned upon and at least SHA256

Re: thinking about new releases

2018-06-18 Thread Jaikiran Pai
I am willing to test and vote on an AntUnit release. -Jaikiran On 18/06/18 12:45 PM, Stefan Bodewig wrote: OK, then I'll revert the antunit change so the source release ships with a released version of it and prepare release candidates sometime the coming days. The alternative would

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-18 Thread Jaikiran Pai
+1. Tried the installation and used a basic Ivy based project for dependency resolution. Also checked some of the Ivy plugin screens to make sure all is fine. -Jaikiran On 17/06/18 12:15 PM, Jaikiran Pai wrote: This is a newer vote mail that I'm initiating for the 2.3.0-rc1 release

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-18 Thread Jaikiran Pai
Thanks for testing this Nicolas. This indeed is a big enough issue to be considered a blocker. I'll take a look at this. I'll also include the sha and rev in a newer vote and update our release instructions. -Jaikiran On Tuesday, June 19, 2018, Nicolas Lalevée wrote: > First, thank you v

[CANCEL] [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-18 Thread Jaikiran Pai
Given the nature of this issue, I'm cancelling this vote. A new one will be initiated this week. -Jaikiran On 19/06/18 5:05 AM, Jaikiran Pai wrote: Thanks for testing this Nicolas. This indeed is a big enough issue to be considered a blocker. I'll take a look at this. I'll also include

Proposing Apache IvyDE release

2018-06-13 Thread Jaikiran Pai
to call this release 2.3.0-rc1. -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-13 Thread Jaikiran Pai
for the release of these binaries? -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-13 Thread Jaikiran Pai
Gintas, When and where do you see these messages? What activity triggers it? -Jaikiran On 14/06/18 12:36 AM, Gintautas Grigelionis wrote: I am testing on Oxygen 3.A and seeing errors like org.xml.sax.SAXParseException; systemId: http://ant.apache.org/ivy/ivyde/updatesite/p2-mirrors--xml.cgi

[VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-17 Thread Jaikiran Pai
: Support for storing credentials securely Do you vote for the release of these binaries? -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

Re: thinking about new releases

2018-06-17 Thread Jaikiran Pai
+1. I don't have anything in a state that I can push to either of these branches, in the immediate future. -Jaikiran On 16/06/18 9:38 PM, Stefan Bodewig wrote: Hi all given https://dev.snyk.io/research/zip-slip-vulnerability lists Ant 1.9.12 as a release fixing a security problem it might

Re: [VOTE] Apache IvyDE 2.3.0-rc1 release

2018-06-17 Thread Jaikiran Pai
I pushed a bunch of commits to address these issues and have now released newer binaries for 2.3.0-rc1 release and initiated a separate VOTE mail for it. -Jaikiran On 16/06/18 6:48 PM, Stefan Bodewig wrote: Hi please add your PGP key to dist.apache.org/release/ant/KEYS * checksums

Re: svn commit: r27516 - /release/ant/KEYS

2018-06-17 Thread Jaikiran Pai
Thank you Stefan, I forgot to add it to this location and added only in the git repo. -Jaikiran On 17/06/18 2:00 PM, bode...@apache.org wrote: Author: bodewig Date: Sun Jun 17 08:30:47 2018 New Revision: 27516 Log: Add Jaikiran's key Modified: release/ant/KEYS Modified: release/ant

Re: Bz 62324

2018-06-09 Thread Jaikiran Pai
this commit, it used to print just the stacktrace. I don't see how this change would solve what's being discussed in that bugzilla. If this isn't the proposed solution, is there some other place I can read up on what's being proposed? -Jaikiran

Re: Bz 62324

2018-06-09 Thread Jaikiran Pai
On 09/06/18 5:22 PM, Gintautas Grigelionis wrote: Thanks for review, Jaikiran. You're correct, that is the proposed solution, adding a separator (a newline followed by an exception name for clarity -- mind that exception is logged only in debug mode). The exception class name would already

Re: ClassLoaders in JUnit Launcher Task

2018-06-03 Thread Jaikiran Pai
On 03/06/18 3:13 PM, Jaikiran Pai wrote: I have now added a section in the junitlauncher task's manual The section's titled "Using the classpath element to include test engines". -Jaikiran to include an example which shows how to setup the classpath element to include thet

Re: InputHandler and end-of-stream

2018-06-03 Thread Jaikiran Pai
an empty input and maybe fall back to the default value? Given that the null return value happens when the stream, from which we are reading, has ended earlier than expected, IMO we should consider it an error case and throw a more legible exception inste

Re: ClassLoaders in JUnit Launcher Task

2018-06-03 Thread Jaikiran Pai
to reply with details if there's something else you are looking for. [1] https://raw.githubusercontent.com/apache/ant/master/manual/Tasks/junitlauncher.html -Jaikiran On 02/06/18 8:39 AM, Jaikiran Pai wrote: HelloLucas, On 01/06/18 10:46 PM, Lucas Bullen wrote: However, when attempting

Re: AntUnit Bug Causing Jenkins Failures

2018-06-04 Thread Jaikiran Pai
Sounds fine to me. -Jaikiran On 04/06/18 1:08 PM, Stefan Bodewig wrote: Hi all one of the recurring issues that make Jenkins builds fail is a thread-safety bug in AntUnit's log capturing code. This is supposed to be fixed in AntUnit's master branch. I propose to build an alpha version

Re: ClassLoaders in JUnit Launcher Task

2018-06-01 Thread Jaikiran Pai
been able to come up with a solution. I'll look more into this in the upcoming days and see how we can improve this. If I misunderstood your use case, please do let us know. [1] https://ant.apache.org/manual/Tasks/junitlauncher.html -Jaikiran

Re: FileUtils.normalize/isLeadingPath have bitten me

2018-07-02 Thread Jaikiran Pai
not even be valid. I'm going to build the latest changes of Ant give it a try against a bunch of my theoretical use cases and see if my suspicions are really valid or not. [1] https://github.com/apache/ant/commit/6a41d62cb9ab4e640b72cb4de42a6c211dea645d -Jaikiran On 01/07/18 2:57 PM

Re: [VOTE] Release AntUnit 1.4 Based on RC1

2018-06-19 Thread Jaikiran Pai
tml repo link typo to be a blocker. I don't know if the copyright year issue should warrant a new vote. If it doesn't, then it's a +1 for this release from me. -Jaikiran On 19/06/18 1:27 AM, Stefan Bodewig wrote: On 2018-06-18, Stefan Bodewig wrote: Hi all there haven't been big chan

Re: .git(modules|attributes|ignore) files in source dists?

2018-06-19 Thread Jaikiran Pai
hing about files like .gitignore being packaged into the archive. So I looked into the generated source tar and those are indeed present. I actually can't think of a reason why we should exclude these files. [1] https://github.com/apache/ant-ivyde/blob/master/build.xml -Jaikiran On 19/06/

Re: [VOTE] Release Ant 1.9.12 based on RC1

2018-06-19 Thread Jaikiran Pai
+1. - Downloaded the .tar.gz binary - Installed locally, checked the NOTICE and some tasks' manuals. Look fine. - Built some random existing Ant based projects using this new version. All went fine. -Jaikiran On 19/06/18 12:38 PM, Stefan Bodewig wrote: Hi all I've created a new release

Re: ant git commit: Inline buildfile names, make search easier

2018-04-29 Thread Jaikiran Pai
What purpose is this change serving? -Jaikiran On 30/04/18 10:08 AM, gin...@apache.org wrote: Repository: ant Updated Branches: refs/heads/master 0add85310 -> f3dfb7779 Inline buildfile names, make search easier Project: http://git-wip-us.apache.org/repos/asf/ant/repo Commit: http://

Re: ant git commit: Inline buildfile names, make search easier

2018-04-29 Thread Jaikiran Pai
se commits anymore and just stay away from them and stop sending this frustrated and rude sounding mails. -Jaikiran The point is that these names are used exactly once, and need not to be put in a field which is named inconsistently. Deviations from this rule of thumb indicate that tests are par

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Jaikiran Pai
t ways a certain thing can be implemented. I hope you do realize that what we are discussing in this thread (and others) is much more broader than finding copy/paste errors due to usage of one API over other. -Jaikiran - To unsub

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 Thread Jaikiran Pai
has moved to TIMTOWTDIBSCINABTE? Sorry, I really don't know what that means or how that relates to what we are discussing. -Jaikiran Gintas 2018-04-30 5:56 GMT+00:00 Jaikiran Pai <jai.forums2...@gmail.com>: On 30/04/18 11:12 AM, Gintautas Grigelionis wrote: Names of buildfiles used in tests can b

Re: FileUtils.normalize/isLeadingPath have bitten me

2018-07-03 Thread Jaikiran Pai
someone else sees any issues, I think we can go ahead and do the release that you had planned for. -Jaikiran On 03/07/18 1:16 PM, Stefan Bodewig wrote: On 2018-07-02, Stefan Bodewig wrote: On 2018-07-02, Jaikiran Pai wrote: I just checked the commits related to this and it looks mostly correct

Re: Ivy-2.5.0

2018-01-09 Thread Jaikiran Pai
Thanks Maarten, I'll look this. -Jaikiran On 09/01/18 5:53 PM, Maarten Coene wrote: The change to the URLHandler class (TimoutConstraint) is also backwards incompatible.The IvyIdea plugin (IntelliJ) breaks on this which contains an extension of AbstractURLHandler. I didn't look into it yet

Re: [PATCH]

2018-01-24 Thread Jaikiran Pai
are using and the exception stacktrace that you got) and attach the proposed patch there? -Jaikiran On 24/01/18 4:57 PM, Adam Retter wrote: If you previously used the Saxon XSLT Processor within you would get an error as the XSLT stylesheets provided with Ant do not work with Saxon, they in fact

Re: Cutting new releases?

2018-01-26 Thread Jaikiran Pai
I just remembered - we probably have to investigate that image task test failure on Java 9 and see if its some setup issue or whether that task is genuinely broken against that runtime. I haven't yet found the time to dig deeper on that one. -Jaikiran On Friday, January 26, 2018, Stefan Bodewig

Re: Cutting new releases?

2018-01-26 Thread Jaikiran Pai
that it can be used for the basic minimal functionality and then keep adding anything more that we want in this task in future releases. More details about this are in the other thread. [1] https://github.com/apache/ant/compare/master...jaikir

Re: Ant support for users who use JUnit5

2018-01-26 Thread Jaikiran Pai
eedback reports) For those of you curious to see what the task usage is going to look like, here's an example[2] build file which shows its many usages. That file will be cleaned up a bit, before I send a PR for review/merge. [1] https://github.com/apache/ant/compare/master...jaikiran:junit5

Re: Ant support for users who use JUnit5

2018-01-26 Thread Jaikiran Pai
One minor but important detail - this feature/task will only be available in the 1.10.x releases (whichever release we decide to include this in) and won't be available in 1.9.x releases of Ant. -Jaikiran On 27/01/18 8:40 AM, Jaikiran Pai wrote: Here's an update on where this effort now

Re: [VOTE] Release Apache Ant 1.10.2 based on RC1

2018-02-05 Thread Jaikiran Pai
+1. - Downloaded the .tar.gz and installed locally. Setup ANT_HOME to this new version. - Ran some existing projects against this new version - Checked some documentation in the manual. Tested the projects using this version of Ant against both Java 8 and Java 9. -Jaikiran On 03/02/18

Re: ant-ivy git commit: IVY-1569 Avoid reflection warnings (or worse) in Java 9+

2018-02-04 Thread Jaikiran Pai
I think we should use java.specification.version system property instead which is the recommended one as per the JEP http://openjdk.java.net/jeps/223. We use this property in Ant too to determine the Java version. -Jaikiran - To u

Re: [VOTE] Release Ant 1.9.10 based on RC1

2018-02-04 Thread Jaikiran Pai
. Checked the presence of source files. All above tests done on Java 8 setup. -Jaikiran On 03/02/18 10:02 PM, Stefan Bodewig wrote: Hi all I've created a release candidate for 1.9.10: git tag: ANT_1_9_10_RC1 on commit: 528c94e tarballs: https://dist.apache.org/repos/dist/dev/ant

Re: ant git commit: Generate manifest files and add automatic module names for JPMS

2018-02-05 Thread Jaikiran Pai
I agree. -1. On a related note, I don't think we should be doing any of these commits especially when there's a RC out which we plan to release. IMO, only blocker issues need to be addressed when the RC is out. -Jaikiran On 06/02/18 1:41 AM, Stefan Bodewig wrote: Generate manifest files

Re: Ivy-2.5.0

2018-02-07 Thread Jaikiran Pai
and see if it solves the issue? -Jaikiran On 09/01/18 5:53 PM, Maarten Coene wrote: The change to the URLHandler class (TimoutConstraint) is also backwards incompatible.The IvyIdea plugin (IntelliJ) breaks on this which contains an extension of AbstractURLHandler. I didn't look into it yet

Re: github PR builds

2018-02-06 Thread Jaikiran Pai
g about github users who belong to the apache organization. P.S: There are a few other keywords that the plugin recognizes and is documented at [1]. [1] https://wiki.jenkins.io/display/JENKINS/GitHub+pull+request+builder+plugin -Jaikiran On 06/02/18 4:59 PM, Stefan Bodewig wrote:

Re: github PR builds

2018-02-06 Thread Jaikiran Pai
So it looks like, although I did send a mail about this PR integration a while back[1], I did not include the details about this plugin which was used for the integration. Sorry about that. [1] https://www.mail-archive.com/dev@ant.apache.org/msg46284.html -Jaikiran On 06/02/18 5:12 PM

Re: Release Notes for 1.10.2 and 1.9.10

2018-02-06 Thread Jaikiran Pai
Maybe the new task is worth highlighting. But other than that I don't have anything specific. -Jaikiran On 06/02/18 11:18 PM, Stefan Bodewig wrote: Hi all as you can witness in https://svn.apache.org/viewvc/ant/site/ant/sources/antnews.xml?r1=1823368=1823367=1823368 I don't really know

Re: Mapped resources NPEs - Potential fix causes a failure in one specific test

2018-02-09 Thread Jaikiran Pai
Thanks everyone for the inputs. Based on those, I have now updated the test to not expect a build failure exception and also have updated our release notes to mention this change in behaviour. -Jaikiran On 09/02/18 11:00 PM, Stefan Bodewig wrote: Jaikiran, just to avoid duplicate work, I'm

Include user mailing list for RC release?

2018-02-09 Thread Jaikiran Pai
the RC, so that issues like these can hopefully be caught before we actually do a release. [1] https://bz.apache.org/bugzilla/show_bug.cgi?id=62086 -Jaikiran - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional

Re: Mapped resources NPEs - Potential fix causes a failure in one specific test

2018-02-09 Thread Jaikiran Pai
Sure Stefan. -Jaikiran On 09/02/18 11:00 PM, Stefan Bodewig wrote: Jaikiran, just to avoid duplicate work, I'm currently running tests on the 1.9.x branch where I fix a bunch a FileNameMapper implementations that wouldn't handle null sourceFileNames (which could happen for resources

Re: Need a Second Pair of Eyes

2018-02-13 Thread Jaikiran Pai
indeed introduces a different behaviour. [1] https://github.com/jaikiran/ant/commit/f57b9d5fbca6e9648695bc9d37a27000c0b4aff2#diff-585ed59cf64ef6930e5148094adc322aR21 -Jaikiran On 13/02/18 11:20 PM, Stefan Bodewig wrote: Hi all I'm currently reviewing the big change that introduced

Re: Need a Second Pair of Eyes

2018-02-13 Thread Jaikiran Pai
I forgot to add that, as you note, as a result of the change, the new created path will retain all elements from destPath that aren't in dependClassPath, which is unlike the behaviour before the change. -Jaikiran On 14/02/18 9:59 AM, Jaikiran Pai wrote: Hi Stefan, You are right. The change

Mapped resources NPEs - Potential fix causes a failure in one specific test

2018-02-09 Thread Jaikiran Pai
://bz.apache.org/bugzilla/show_bug.cgi?id=39960 [6] https://builds.apache.org/job/Ant-Build-Matrix-1.9.x-Linux/OS=xenial,jdk=JDK%201.5%20(latest)/lastCompletedBuild/testReport/src.tests.antunit.taskdefs/copy-test_xml/testResourceWithoutName/ -Jaikiran

Re: ant git commit: Generate manifest files and add automatic module names for JPMS

2018-02-06 Thread Jaikiran Pai
Just to be clear, my -1 was meant for both this commit as well as a subsequent commit where some specific jars have been tagged as JPMS modules. I think adding this automatic module names just for the sake of it isn't a good thing. -Jaikiran On 06/02/18 9:38 AM, Jaikiran Pai wrote: I agree

Re: Ivy-2.5.0

2018-02-08 Thread Jaikiran Pai
amount of bug fixes that have been done since 2.4.0 and I think we should start looking at what it takes to do the release formalities. -Jaikiran On 09/01/18 12:29 PM, Jaikiran Pai wrote: Hi Jan, My efforts to resolve IVY-1485 have taken longer than I expected, mainly due to not finding enough

Re: github PR builds

2018-02-08 Thread Jaikiran Pai
On 06/02/18 10:10 PM, Stefan Bodewig wrote: On 2018-02-06, Jaikiran Pai wrote: The PR build on Jenkins is backed by the github PR integration plugin[1]. One of the features of that plugin is to prevent some malicious/rogue PR (imagine someone creating a PR with code which does some odd things

Re: Ant support for users who use JUnit5

2018-02-15 Thread Jaikiran Pai
I just realized that the manual that I linked in my mail isn't accessible to everyone. So here's an alternative link to the same https://home.apache.org/~jaikiran/temp_workspace/manual/Tasks/junitlauncher.html -Jaikiran On 15/02/18 7:21 PM, Jaikiran Pai wrote: I'm now done with the initial

Re: Ant support for users who use JUnit5

2018-02-15 Thread Jaikiran Pai
n memory, during the report writing and will be immediately garbage collected once that's done. Please review the PR - mostly the Ant specific constructs and implementation details. [1] https://github.com/apache/ant/pull/60 [2] https://builds.apache.org/job/Ant-Build-Jaikiran/ws/manual/Tasks/jun

Re: Ant support for users who use JUnit5

2018-02-15 Thread Jaikiran Pai
the regressions that we have found in our latest releases. -Jaikiran On 15/02/18 7:21 PM, Jaikiran Pai wrote: I'm now done with the initial goals that I had in mind for this task. I've opened a PR[1] for review. I've included a manual for this task and it can be currently found here[2]. I would

Re: Ant support for users who use JUnit5

2018-02-17 Thread Jaikiran Pai
On 17/02/18 12:51 AM, Stefan Bodewig wrote: On 2018-02-15, Jaikiran Pai wrote: I'm now done with the initial goals that I had in mind for this task. I've opened a PR[1] for review. I've included a manual for this task and it can be currently found here[2]. I would suggest reading the manual

Re: Ant support for users who use JUnit5

2018-02-18 Thread Jaikiran Pai
On 19/02/18 1:37 AM, Stefan Bodewig wrote: On 2018-02-15, Jaikiran Pai wrote: I'm now done with the initial goals that I had in mind for this task. I've opened a PR[1] for review. I've included a manual for this task and it can be currently found here[2]. I would suggest reading the manual

Ivy release this month?

2018-02-18 Thread Jaikiran Pai
that. There are few PRs open, but except for this one https://github.com/apache/ant-ivy/pull/62 I don't plan to merge the rest given the nature of the changes. There's no release instructions that I could find, so I am not sure what's going to be involved in the actual release process. -Jaikiran

Re: Ant support for users who use JUnit5

2018-02-23 Thread Jaikiran Pai
On 19/02/18 9:23 AM, Jaikiran Pai wrote: On 19/02/18 1:37 AM, Stefan Bodewig wrote: On 2018-02-15, Jaikiran Pai wrote: We have 3 pre-defined formatters all of which are capable of receiving this streamed sysout/syserr data. Each of these do _not_ hold on to this sysout/syserr data in-memory

Re: [GitHub] ant pull request #:

2017-12-20 Thread Jaikiran Pai
No specific reason, just that I'm more used to using the javadoc variant of @deprecated since it allows explaining what's deprecated and why. I have now added the @Deprecated annotation too and pushed a commit. -Jaikiran On 20/12/17 11:08 PM, twogee wrote: Github user twogee commented

Re: [CANCELLED] Release AntUnit 1.4 Based on RC2

2018-06-21 Thread Jaikiran Pai
I think moving to Ant 1.8.x would be a better option, given the relatively low chances of it causing any issues. -Jaikiran On 21/06/18 2:47 PM, Stefan Bodewig wrote: On 2018-06-21, Gintautas Grigelionis wrote: POM template has inconsistent Ant versions, 1.7.1 in compile scope and 1.8.1

Re: Jenkins-Builds failing

2018-07-29 Thread Jaikiran Pai
I would like to test/import a few more projects (that Nicolas mentioned in one the mails) locally into the latest upstream version of the IDE, before starting a release. I have only tested a few so far. -Jaikiran On 28/07/18 2:28 PM, Gintautas Grigelionis wrote: > Thanks, Jaikiran. Would

<    1   2   3   4   5   6   7   8   >