Github user jaikiran closed the pull request at:
https://github.com/apache/ant/pull/60
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/5aa1e8eff81ad6005e62587cdaaa962fce1105ea#commitcomment-27929054
In src/tests/junit/org/apache/tools/ant/taskdefs/RmicAdvancedTest.java:
In
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/5aa1e8eff81ad6005e62587cdaaa962fce1105ea#commitcomment-27928590
In src/tests/junit/org/apache/tools/ant/taskdefs/RmicAdvancedTest.java:
In
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/e06168ca78b819a21924f3716b99e3621b4855ef#commitcomment-27927813
It's not quite appropriate here, but we need a new release of Ivy... :cry:
---
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/5aa1e8eff81ad6005e62587cdaaa962fce1105ea#commitcomment-27927763
In src/tests/junit/org/apache/tools/ant/taskdefs/RmicAdvancedTest.java:
In
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r172044906
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java
---
@@ -0,0 +1,508 @@
+package
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r172044717
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java
---
@@ -0,0 +1,295 @@
+package
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r172044665
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java
---
@@ -0,0 +1,295 @@
+package
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r172044509
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java
---
@@ -0,0 +1,295 @@
+package
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r172043964
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java
---
@@ -0,0 +1,508 @@
+package
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r172043835
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java
---
@@ -0,0 +1,295 @@
+package
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r172043778
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java
---
@@ -0,0 +1,295 @@
+package
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r169626791
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java
---
@@ -0,0 +1,508 @@
+package
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r169625878
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java
---
@@ -0,0 +1,508 @@
+package
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r169624865
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java
---
@@ -0,0 +1,508 @@
+package
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r169624837
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java
---
@@ -0,0 +1,508 @@
+package
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r169624475
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java
---
@@ -0,0 +1,508 @@
+package
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r169248698
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java
---
@@ -0,0 +1,508 @@
+package
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r169248048
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java
---
@@ -0,0 +1,508 @@
+package
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r169247383
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java
---
@@ -0,0 +1,508 @@
+package
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r169245116
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java
---
@@ -0,0 +1,508 @@
+package
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r169243988
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/JUnitLauncherTask.java
---
@@ -0,0 +1,508 @@
+package
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r168983237
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java
---
@@ -0,0 +1,139 @@
+package
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r168983118
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java
---
@@ -0,0 +1,139 @@
+package
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r168964381
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java
---
@@ -0,0 +1,139 @@
+package
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r168964295
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java
---
@@ -0,0 +1,139 @@
+package
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/60#discussion_r168963955
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/AbstractJUnitResultFormatter.java
---
@@ -0,0 +1,139 @@
+package
GitHub user reudismam opened a pull request:
https://github.com/apache/ant/pull/62
Use char notation to represent a character to improve performance.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/reudismam/ant character
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/61
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
GitHub user reudismam opened a pull request:
https://github.com/apache/ant/pull/61
Use the isEmpty method instead of comparing the value of size() to 0.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/reudismam/ant size
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant/pull/60
JUnit 5 support - A new junitlauncher task
This is the initial working version of a new `junitlauncher` task that
support using JUnit 5 framework for testing, within Ant build files. The commit
in
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/57
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/59
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
GitHub user jpountz opened a pull request:
https://github.com/apache/ant/pull/59
Fix NPE in ChainedMapper.
This NPE happens whenever any of the sub mappers returns `null`, which may
happen eg. with `GlobPatternMapper`.
You can merge this pull request into a Git repository by
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/58#discussion_r166217627
--- Diff: src/main/org/apache/tools/ant/taskdefs/Parallel.java ---
@@ -377,7 +377,7 @@ public synchronized void run() {
}
// now
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/58#discussion_r166216151
--- Diff: src/main/org/apache/tools/ant/listener/MailLogger.java ---
@@ -102,7 +102,7 @@
private static final String DEFAULT_MIME_TYPE = "text/plain";
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/58#discussion_r166183671
--- Diff: src/main/org/apache/tools/ant/taskdefs/Parallel.java ---
@@ -377,7 +377,7 @@ public synchronized void run() {
}
// now
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/58#discussion_r166183611
--- Diff: src/main/org/apache/tools/ant/listener/MailLogger.java ---
@@ -102,7 +102,7 @@
private static final String DEFAULT_MIME_TYPE = "text/plain";
GitHub user reudismam opened a pull request:
https://github.com/apache/ant/pull/58
Use StringBuilder instead of StringBuffer as it offers high performanâ¦
â¦ce in single thread places as it is generally the case.
You can merge this pull request into a Git repository by running:
GitHub user adamretter opened a pull request:
https://github.com/apache/ant/pull/57
Make junitreport with Saxon
Previously the XSLT(s) used in `junitreport` were only compatible with
Xalan 2. Whilst you could specify a different `TransformerFactory`, and that
could be Saxon, it
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/56
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
GitHub user reudismam opened a pull request:
https://github.com/apache/ant/pull/56
Use equals method of a string literal to prevent NPE and isEmpty() meâ¦
â¦thod instead of comparing a String object with an empty string.
This change has already been done for some
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/55
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
GitHub user reudismam opened a pull request:
https://github.com/apache/ant/pull/55
Use valueOf method instead of constructor since valueOf has higher peâ¦
â¦rformance.
You can merge this pull request into a Git repository by running:
$ git pull
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/1465c4581ace84548ec9dfc487d62cfec14d84ad#commitcomment-27040705
we should try whether the bridge between 1.x and 2.x works and recommend
our users to use that if it does.
I don't think we
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/1465c4581ace84548ec9dfc487d62cfec14d84ad#commitcomment-27040319
What about upgrading to 2.x with 1.x compatibility API? (ditto for Commons
Logging). Any comments, @bodewig?
---
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/538b7c9ffee7a18064f7726c8b20faf681adb218#commitcomment-27018577
I'd rather upgrade to Log4j 2.x :smile:
---
-
To unsubscribe,
Github user jaikiran closed the pull request at:
https://github.com/apache/ant/pull/52
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/d43d83e0198f86c9233631bcb443da132e394d65#commitcomment-26506626
You're welcome.
That's why I try to make changes that are target for both branches just to
the 1.9.x branch and merge it to
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/d43d83e0198f86c9233631bcb443da132e394d65#commitcomment-26504265
Thanks for catching this one up, a slip of attention while backporting
changes in master.
---
GitHub user twogee opened a pull request:
https://github.com/apache/ant/pull/54
Letâs use Ivy (properly!) and drop Maven Ant tasks, Commons OpenPGP, â¦
⦠Python, etc. The implementation is incomplete, please comment.
I put extraneous stuff in `attic` subdirectory for
Github user twogee closed the pull request at:
https://github.com/apache/ant/pull/53
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/1a2c33fd0ef9dfc042044277707d7f38b0cfa0b0#commitcomment-26409414
Somebody with a sense of humour has a `@Deprecated` account on GitHub
:rofl:
---
No specific reason, just that I'm more used to using the javadoc variant
of @deprecated since it allows explaining what's deprecated and why. I
have now added the @Deprecated annotation too and pushed a commit.
-Jaikiran
On 20/12/17 11:08 PM, twogee wrote:
Github user twogee commented on
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/242d661161ddf2b28e6df23847c1471ee788bab7#commitcomment-26396824
In src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java:
In src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java on line
GitHub user twogee opened a pull request:
https://github.com/apache/ant/pull/53
Optional libraries for Ant 1.10
A bit unsure about JRuby: should we stay with 1.7 for a while or go for 9?
In any case, would jruby-core be sufficient, or should jruby-stdlib be added,
too?
You can
Github user twogee closed the pull request at:
https://github.com/apache/ant/pull/50
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/6f5db5e0689c0bea88f16f018be875ef9840825b#commitcomment-26342106
you are certainly right, thank you for catching this.
---
-
To
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/6f5db5e0689c0bea88f16f018be875ef9840825b#commitcomment-26338779
Shouldn't we use HTML entities (eg )? Is HTML 3 is a requirement,
too? :confused:
---
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant/pull/52
[master] Fix BZ-58451 BZ-58833
The commit here fixes the issues reported in:
https://bz.apache.org/bugzilla/show_bug.cgi?id=58833
https://bz.apache.org/bugzilla/show_bug.cgi?id=58451
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/51
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user jaikiran closed the pull request at:
https://github.com/apache/ant/pull/38
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user jaikiran closed the pull request at:
https://github.com/apache/ant/pull/51
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
GitHub user jaikiran reopened a pull request:
https://github.com/apache/ant/pull/51
[master] Changes for BZ-19516
As suggested in https://bz.apache.org/bugzilla/show_bug.cgi?id=19516, the
change in this PR uses `java.io.BufferedInputStream` which can take an
underlying
Github user jaikiran closed the pull request at:
https://github.com/apache/ant/pull/51
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
GitHub user jaikiran reopened a pull request:
https://github.com/apache/ant/pull/51
[master] Changes for BZ-19516
As suggested in https://bz.apache.org/bugzilla/show_bug.cgi?id=19516, the
change in this PR uses `java.io.BufferedInputStream` which can take an
underlying
GitHub user jaikiran reopened a pull request:
https://github.com/apache/ant/pull/38
Do not merge
Testing Jenkins integration. Do not merge this PR
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaikiran/ant dummy
Alternatively
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant/pull/51
[master] Changes for BZ-19516
As suggested in https://bz.apache.org/bugzilla/show_bug.cgi?id=19516, the
change in this PR uses `java.io.BufferedInputStream` which can take an
underlying
Github user jaikiran closed the pull request at:
https://github.com/apache/ant/pull/49
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155941358
--- Diff: src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java ---
@@ -30,6 +30,8 @@
* a symbolic link based on the absent support for them in Java.
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155941213
--- Diff: src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java ---
@@ -30,6 +30,8 @@
* a symbolic link based on the absent support for them in Java.
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155941155
--- Diff: src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java
---
@@ -500,18 +502,12 @@ private void doLink(String res, String lnk) throws
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155941101
--- Diff: src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java
---
@@ -448,49 +432,67 @@ private void handleError(String msg) {
/**
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155941095
--- Diff: src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java
---
@@ -207,26 +198,30 @@ public void recreate() throws BuildException {
Github user jaikiran commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155941080
--- Diff: manual/Tasks/symlink.html ---
@@ -26,7 +26,7 @@
Symlink
Description
- Manages symbolic links on Unix based platforms. Can be used
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155928363
--- Diff: src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java ---
@@ -30,6 +30,8 @@
* a symbolic link based on the absent support for them in Java.
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155928313
--- Diff: src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java
---
@@ -500,18 +502,12 @@ private void doLink(String res, String lnk) throws
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155928143
--- Diff: src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java
---
@@ -448,49 +432,67 @@ private void handleError(String msg) {
/**
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155928069
--- Diff: src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java
---
@@ -207,26 +198,30 @@ public void recreate() throws BuildException {
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155927463
--- Diff: src/main/org/apache/tools/ant/taskdefs/optional/unix/Symlink.java
---
@@ -207,26 +198,30 @@ public void recreate() throws BuildException {
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155927271
--- Diff: manual/Tasks/symlink.html ---
@@ -26,7 +26,7 @@
Symlink
Description
- Manages symbolic links on Unix based platforms. Can be used
Github user bodewig commented on a diff in the pull request:
https://github.com/apache/ant/pull/49#discussion_r155927252
--- Diff: WHATSNEW ---
@@ -27,6 +27,11 @@ Fixed bugs:
copy happened to be the same source file (symlinked back
to itself).
+ * Bugzilla
GitHub user twogee opened a pull request:
https://github.com/apache/ant/pull/50
Use newer Maven Ant tasks
The initial aim was to avoid NPE when retrieving jasper and automate
retrieval of ant-antunit (with exclusion of ant/ant-launcher).
Then I started wondering whether it
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant/pull/49
[master branch] - Fix BZ-58683
The commit here fixes the issue reported at
https://bz.apache.org/bugzilla/show_bug.cgi?id=58683.
This commit along with fixing the issue reported in that bug,
Github user bodewig commented on the pull request:
https://github.com/apache/ant/commit/68b846a4c27361cce2b6d7e9c60ca697f980913e#commitcomment-25935605
In src/main/org/apache/tools/ant/taskdefs/Javac.java:
In src/main/org/apache/tools/ant/taskdefs/Javac.java on line 778:
Github user twogee commented on the pull request:
https://github.com/apache/ant/commit/68b846a4c27361cce2b6d7e9c60ca697f980913e#commitcomment-25932714
In src/main/org/apache/tools/ant/taskdefs/Javac.java:
In src/main/org/apache/tools/ant/taskdefs/Javac.java on line 778:
For
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/48
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant/pull/48
BZ-61718 Upgrade to 0.1.54 of Jsch library
The commit here upgrades Jsch library dependency to `0.1.54` (which is the
latest released version) as requested in
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/47
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/44
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/46
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
GitHub user BruceKuiLiu opened a pull request:
https://github.com/apache/ant/pull/47
Add the "final" modifier to a public static field.
This static field public but not final, and could be changed by malicious
code or by accident from another package. The field could be made final
GitHub user BruceKuiLiu opened a pull request:
https://github.com/apache/ant/pull/46
Remove the redundant nullcheck of non-null values.
These statements contain redundant check of known non-null values against
the constant null.
GitHub user BruceKuiLiu opened a pull request:
https://github.com/apache/ant/pull/45
Consider returning a zero length array rather than null.
It is often a better design to return a length zero array rather than a
null reference to indicate that there are no results (i.e., an empty
GitHub user BruceKuiLiu opened a pull request:
https://github.com/apache/ant/pull/44
Remove the 'protected' modifier to make fields package protected.
The three mutable static fields could be changed by malicious code or by
accident. These fields could be made package protected to
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/43
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/42
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
GitHub user BruceKuiLiu opened a pull request:
https://github.com/apache/ant/pull/43
Fix the problem of using '+=' operator to concatenate strings in a loop
The method is building a String using concatenation in a loop.
In each iteration, the String is converted to a
GitHub user BruceKuiLiu opened a pull request:
https://github.com/apache/ant/pull/42
Fix the inefficient use of keySet iterator with entrySet iterator.
The current source code accesses the key and value of a Hashtable entry,
using a key that is retrieved from a keySet
Github user BruceKuiLiu closed the pull request at:
https://github.com/apache/ant/pull/41
---
-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org
101 - 200 of 342 matches
Mail list logo
