Github user bodewig commented on the pull request:
https://github.com/apache/ant/pull/8#issuecomment-95677851
I think this is something we should make configurable via a task attribute
rather than hardcode new default values.
---
If your project is set up for it, you can reply to
Just my 2 cents...
In the year 2015, a 1K buffer is quite small. It is a bottleneck. I personally
default to using 64K buffers unless I know for a fact that I am going to be
transferring more than 1GB in which case I bump to a 1M or larger buffer.
64K or 128K was a lot of RAM back in 1982. I
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/ant/commit/1a584200e27de7867d7f613ff9c910dc0cc9730a#commitcomment-10875019
In manual/Tasks/tar.html:
In manual/Tasks/tar.html on line 155:
Shouldn't this be since 1.9.5?
---
If your project
Github user bodewig commented on the pull request:
https://github.com/apache/ant/pull/8#issuecomment-95691366
github pull requests are an option that we haven't used heavily, but it is
fine. The canonical aproach would have been a Bugzilla issue with attachment
(that's what we've
Github user ajmas commented on the pull request:
https://github.com/apache/ant/pull/8#issuecomment-95704421
May want to look at this for a perspective:
http://stackoverflow.com/questions/236861/how-do-you-determine-the-ideal-buffer-size-when-using-fileinputstream
while
---
If your
Github user ajmas commented on the pull request:
https://github.com/apache/ant/pull/8#issuecomment-95706031
Last comment got cut short. How did you come about the 100k value? Has this
been tested on networks with smaller through put? Consider the nature of data
packet sizes. Not
Github user pkures commented on the pull request:
https://github.com/apache/ant/pull/8#issuecomment-95718851
I was thinking along the lines of ... the transfer speed is 1MB/s but
theoretically on 1 Gbit network you should see up to 100MB/s transfer speed
ideally, so I tried to
Github user bodewig commented on the pull request:
https://github.com/apache/ant/pull/8#issuecomment-95794438
I appreciate the offer of doing more research, but it's not necessary.
The argument about the ftp task made me look into the other tasks we use
for transferring files
GitHub user pkures opened a pull request:
https://github.com/apache/ant/pull/8
increase buffer size to improve transfer speed
1024 byte buffer size is insufficient for transfering large files over
faster ( 100Mbit) networks. We are transfering files tens or hundreds MB in
size and
GitHub user pkures opened a pull request:
https://github.com/apache/ant/pull/9
increase buffer size to improve transfer speed
1024 byte buffer size is insufficient for transfering large files over
faster ( 100Mbit) networks. We are transfering files tens or hundreds MB in
size and
Github user ajmas commented on a diff in the pull request:
https://github.com/apache/ant/pull/8#discussion_r28864296
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/ssh/ScpToMessage.java ---
@@ -36,7 +36,7 @@
public class ScpToMessage extends AbstractSshMessage {
Github user pkures commented on a diff in the pull request:
https://github.com/apache/ant/pull/8#discussion_r28864813
--- Diff:
src/main/org/apache/tools/ant/taskdefs/optional/ssh/ScpToMessage.java ---
@@ -36,7 +36,7 @@
public class ScpToMessage extends AbstractSshMessage {
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled
Github user bodewig commented on the pull request:
https://github.com/apache/ant/pull/7#issuecomment-76888501
I'm not an Eclipse use at all, so I can't help. Maybe you should ask your
question on the Ant user mailing list.
---
If your project is set up for it, you can reply to this
Github user rayhanul commented on the pull request:
https://github.com/apache/ant/pull/7#issuecomment-76885905
i am using Ant 1.7 to analyze the code metrics for my thesis. actually i am
new in git. i don't know much more about how to manage files in git. i can
only commit and
GitHub user rayhanul opened a pull request:
https://github.com/apache/ant/pull/7
Ant 17 branch
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/ant ANT_17_BRANCH
Alternatively you can review and apply these changes as the
Github user bodewig commented on the pull request:
https://github.com/apache/ant/pull/7#issuecomment-76733818
I don't understand the purpose of this PR (or #2), is this an accident?
Please explain what you are trying to do or close it.
---
If your project is set up for it, you can
GitHub user razzius opened a pull request:
https://github.com/apache/ant/pull/6
Clean up whitespace in build.xml example
The original author did a good job making readable xml using the HTML
escape syntax, but I just noticed a few stray spaces when I copied the
build.xml to start
Github user changgengli commented on the pull request:
https://github.com/apache/ant/pull/5#issuecomment-68926469
Michael,
Have you got a chance to review the code?
Thanks,
Changgeng
---
If your project is set up for it, you can reply to this email and have your
Github user changgengli commented on the pull request:
https://github.com/apache/ant/pull/5#issuecomment-68461038
I've add an antunit test. Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mc1arke commented on the pull request:
https://github.com/apache/ant/pull/5#issuecomment-68174716
Your changes look reasonable from a quick scan of them, and I'm impressed
with the speed you made them. I'll give it a more thorough review once you've
got some tests in.
Github user mc1arke commented on the pull request:
https://github.com/apache/ant/pull/5#issuecomment-67930586
Some pointers for you:
* You're introducing a runtime dependency on JUnit 4 by referencing a JUnit
class directly. There are still users of Ant who only use JUnit 3, so
Github user changgengli commented on the pull request:
https://github.com/apache/ant/pull/5#issuecomment-67999297
Hello Michael,
Except for some tests that prove this feature and protect it in future
changes, all other concerns should have been addressed.
Please let
GitHub user changgengli opened a pull request:
https://github.com/apache/ant/pull/5
My 194
Hello,
This PR is to randomize the excution order the junit test method in the
same class. I came to this idea during the work we are upgrading from java 6 to
java 8. A lot of test
Github user gagern commented on the pull request:
https://github.com/apache/ant/pull/3#issuecomment-64760699
Thanks for the quick merge!
I also have [a
patch](https://issues.apache.org/bugzilla/attachment.cgi?id=23476) lying around
for [issue
Github user bodewig commented on the pull request:
https://github.com/apache/ant/pull/4#issuecomment-64855476
Personally I'd prefer to have the discussion about this pull request in a
single place - see https://issues.apache.org/bugzilla/show_bug.cgi?id=47003
---
If your project
GitHub user gagern opened a pull request:
https://github.com/apache/ant/pull/3
junitreport: Expose classpath and factory of internal XSLTProcess task.
Trying to revive [bug
47002](https://issues.apache.org/bugzilla/show_bug.cgi?id=47002) by filing a
pull request for it.
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled
Github user bodewig commented on the pull request:
https://github.com/apache/ant/pull/3#issuecomment-64702076
Thanks!
One of the tests failed, after I merged your commit - I fixed the test as
it didn't work the way Ant would create the corresponding task anyway.
---
If your
Github user bodewig commented on the pull request:
https://github.com/apache/ant/pull/1#issuecomment-63479967
OK, I think I get that. So it is not as much about long paths but rather
paths with spaces in them.
---
If your project is set up for it, you can reply to this email and
Github user bodewig commented on the pull request:
https://github.com/apache/ant/pull/1#issuecomment-63494396
I've taken the liberty and only committed the subset actually related to
the path changes.
---
If your project is set up for it, you can reply to this email and have your
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled
Github user bodewig commented on the pull request:
https://github.com/apache/ant/pull/1#issuecomment-63274385
I'm not familiar with how Python works on Windows at all, so please bear
with me. How does stripping quotes and explicitly adding them later help with
long path?
Github user vit1251 commented on the pull request:
https://github.com/apache/ant/pull/1#issuecomment-63275249
Magic here:
-cmdline = ('%s %s -classpath %s -Dant.home=%s %s ' + \
+cmdline = ('%s %s -classpath %s -Dant.home=%s %s ' + \
Github user bodewig commented on the pull request:
https://github.com/apache/ant/pull/2#issuecomment-61364763
I don't understand this PR, is this just a mistake - if so, please close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user Dele87 opened a pull request:
https://github.com/apache/ant/pull/2
Ant 18 branch
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/ant ANT_18_BRANCH
Alternatively you can review and apply these changes as the
GitHub user vit1251 opened a pull request:
https://github.com/apache/ant/pull/1
Update runant.py
Resolve long path problem when starting antrun.py on Windows 7
os.system is bad idea to use
You can merge this pull request into a Git repository by running:
$ git pull
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled
Github user vlajos closed the pull request at:
https://github.com/apache/ant/pull/4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled
GitHub user vlajos opened a pull request:
https://github.com/apache/ant/pull/4
typofixes
Typo fixes. Mostly non living code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vlajos/ant typofixes-20140218
Alternatively you can
Github user vlajos closed the pull request at:
https://github.com/apache/ant/pull/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled
301 - 342 of 342 matches
Mail list logo
