Re: sendfile in darwin

2008-05-07 Thread Jim Jagielski
Just a quick FYI: Simply using the FreeBSD logic flow for sendfile (ie: adding || defined(DARWIN) and pulling out the existing DARWIN-specific section) clears up the problems I saw with the getfile tests... So I guess I need to dig deeper on this... BTW: This is on OS X 10.5.2 (Darwin 9.2.2)

Re: sendfile in darwin

2008-05-07 Thread Jim Jagielski
On May 7, 2008, at 9:14 AM, Jim Jagielski wrote: Just a quick FYI: Simply using the FreeBSD logic flow for sendfile (ie: adding || defined(DARWIN) and pulling out the existing DARWIN-specific section) clears up the problems I saw with the getfile tests... So I guess I need to dig deeper on

Re: sendfile in darwin

2008-05-07 Thread Jim Jagielski
On May 7, 2008, at 9:25 AM, Jim Jagielski wrote: On May 7, 2008, at 9:14 AM, Jim Jagielski wrote: Just a quick FYI: Simply using the FreeBSD logic flow for sendfile (ie: adding || defined(DARWIN) and pulling out the existing DARWIN-specific section) clears up the problems I saw with the

Re: sendfile in darwin

2008-05-07 Thread Jim Jagielski
On May 7, 2008, at 9:31 AM, Jim Jagielski wrote: On May 7, 2008, at 9:25 AM, Jim Jagielski wrote: On May 7, 2008, at 9:14 AM, Jim Jagielski wrote: Just a quick FYI: Simply using the FreeBSD logic flow for sendfile (ie: adding || defined(DARWIN) and pulling out the existing

Re: sendfile in darwin

2008-05-07 Thread Jim Jagielski
On May 7, 2008, at 1:29 PM, Jim Jagielski wrote: Squashed... Spent a LOT of time on this (even ported the Linux impl to Darwin, which actually is nicer since it uses apr_socket_sendv() and does things like checking partial header/footer stuff, which I may eventually commit to trunk) and the

Re: sendfile in darwin

2008-05-07 Thread Dirk-Willem van Gulik
Hmm - Jim - that does not quite solve the issue I was discussing on IRC; I think below is needed (which does solve the TimeOut issue). -- diff with your version -- anticipate nbytes set to 0 (which has whole file semantics on BSD and Darwin). Does that make sense ? Dw Index:

Re: sendfile in darwin

2008-05-07 Thread Jim Jagielski
On May 7, 2008, at 2:31 PM, Dirk-Willem van Gulik wrote: Hmm - Jim - that does not quite solve the issue I was discussing on IRC; On IRC? What happened to onlist discussions?? :) I think below is needed (which does solve the TimeOut issue). -- diff with your version -- anticipate nbytes

Re: sendfile in darwin

2008-05-07 Thread Jim Jagielski
On May 7, 2008, at 2:42 PM, Jim Jagielski wrote: On May 7, 2008, at 2:31 PM, Dirk-Willem van Gulik wrote: Hmm - Jim - that does not quite solve the issue I was discussing on IRC; On IRC? What happened to onlist discussions?? :) To clarify: I have no idea what you are referring to as

Re: sendfile in darwin

2008-05-07 Thread Mads Toftum
On Wed, May 07, 2008 at 02:50:46PM -0400, Jim Jagielski wrote: To clarify: I have no idea what you are referring to as far as what issue you were discussing. This is because it was on IRC. For myself and everyone else who did not happen to be on IRC at that moment of time, we have no idea

Re: svn commit: r654185 - in /apr/apr/trunk: CHANGES network_io/unix/sendrecv.c

2008-05-07 Thread William A. Rowe, Jr.
[EMAIL PROTECTED] wrote: Author: jim Date: Wed May 7 10:32:31 2008 New Revision: 654185 URL: http://svn.apache.org/viewvc?rev=654185view=rev Log: Make Darwin's sendfile() really work :) I forgot about that CHANGES entry... Jim would you also please add Geoff Greer angryparsley mipsisrisc.com

Re: sendfile in darwin

2008-05-07 Thread Dirk-Willem van Gulik
On May 7, 2008, at 8:42 PM, Jim Jagielski wrote: On May 7, 2008, at 2:31 PM, Dirk-Willem van Gulik wrote: Hmm - Jim - that does not quite solve the issue I was discussing on IRC; On IRC? What happened to onlist discussions?? :) Sorry - I was debugging something totally different (I

Re: sendfile in darwin

2008-05-07 Thread Dirk-Willem van Gulik
On May 7, 2008, at 8:58 PM, Mads Toftum wrote: On Wed, May 07, 2008 at 02:50:46PM -0400, Jim Jagielski wrote: To clarify: I have no idea what you are referring to as far as what issue you were discussing. This is because it was on IRC. For myself and everyone else who did not happen to be on

Re: svn commit: r654185 - in /apr/apr/trunk: CHANGES network_io/unix/sendrecv.c

2008-05-07 Thread Jim Jagielski
Is it better to combine them both into 1 ?? On May 7, 2008, at 3:04 PM, William A. Rowe, Jr. wrote: [EMAIL PROTECTED] wrote: Author: jim Date: Wed May 7 10:32:31 2008 New Revision: 654185 URL: http://svn.apache.org/viewvc?rev=654185view=rev Log: Make Darwin's sendfile() really work :) I

Re: svn commit: r654247 - in /apr/apr/trunk: CHANGES network_io/unix/sendrecv.c

2008-05-07 Thread Ruediger Pluem
On 05/07/2008 10:07 PM, [EMAIL PROTECTED] wrote: Author: jim Date: Wed May 7 13:07:52 2008 New Revision: 654247 URL: http://svn.apache.org/viewvc?rev=654247view=rev Log: Oops... forgot to combine the CHANGES :) Modified: apr/apr/trunk/CHANGES apr/apr/trunk/network_io/unix/sendrecv.c

Re: sendfile in darwin

2008-05-07 Thread Geoff Greer
OK, so there are two problems here: 1. Timeout sockets are broken in r654185. To test this cd to apr/test, make, then run ./sendfile server ./sendfile client timeout Of course reverting the change (adding the rv=0 line again) causes the httpd tests to fail. I don't have the httpd tests set up