On Sat, 2008-05-17 at 20:43 -0400, Tom Donovan wrote:
I would be happy to take care of it as soon as I receive commit access. I'm
a new committer, and
the instructions advised patience - so I expect this usually takes some time
to get processed.
I committed something that _may_ work in
On 05/18/2008 10:54 AM, [EMAIL PROTECTED] wrote:
Author: bojan
Date: Sun May 18 01:54:09 2008
New Revision: 657516
URL: http://svn.apache.org/viewvc?rev=657516view=rev
Log:
Make sure PGSQL and MySQL drivers count rows from 1, not 0
Modified:
apr/apr-util/trunk/dbd/apr_dbd_mysql.c
On Sun, 2008-05-18 at 11:24 +0200, Ruediger Pluem wrote:
I guess this should now be 0?
Depends, really. If we want things to break when users pass in 0, then
it should be the way it is, provided MySQL returns an error when row it
is given is -1. If we just want to not seek at all, then yes -
On 05/18/2008 11:39 AM, Bojan Smojver wrote:
On Sun, 2008-05-18 at 11:24 +0200, Ruediger Pluem wrote:
I guess this should now be 0?
Depends, really. If we want things to break when users pass in 0, then
it should be the way it is, provided MySQL returns an error when row it
is given is
On Sun, 2008-05-18 at 12:02 +0200, Ruediger Pluem wrote:
Maybe we should return a driver independent error code in the case that the
row number is 1. A MySQL specific error code might be somewhat confusing
to the user as it might tell him that he used -1 as a row number.
BTW: As far as I see
On Sat, 2008-05-17 at 09:07 -0400, Bob Rossi wrote:
I've been using sqlite3 dbd for some time now. I find that the function
apr_dbd_get_row,
http://apr.apache.org/docs/apr-util/trunk/group___a_p_r___util___d_b_d.html#gd4cdc5f4e8981b93f5a467a8c8a768f1
is 1 based. That is, 1 is the first
Any problems I backport the
http://svn.apache.org/viewvc?rev=657500view=rev
to 1.2 and 1.3 ?
Regards
--
^(TM)
Mladen Turk wrote:
Any problems I backport the
http://svn.apache.org/viewvc?rev=657500view=rev
to 1.2 and 1.3 ?
I'm only worried about misuse; could you add a doxygen note that removing
the shm while in-use is absolutely not portable?
Otherwise no issues with adding an implementation - please
