On Tue, May 20, 2008 at 01:49:45PM +1000, Bojan Smojver wrote:
Here is a patch I've been toying with. Essentially, it does these
things:
- cleans up PostgreSQL detection a bit more
- uses APRUTIL_PRIV_INCLUDES for all CPPFLAGS driver stuff (i.e. we
don't need to expose that to users of
Are we planning on doing the APR 1.2 and/or 1.3 releases soon?
Let me know what I can do to help to get this along.
[EMAIL PROTECTED] wrote:
Author: wrowe
Date: Tue May 20 08:31:53 2008
New Revision: 658279
URL: http://svn.apache.org/viewvc?rev=658279view=rev
Log:
Protect unlocks within GLOBAL_PREPARED_STATEMENTS blocks, as this is where
they were initially obtained.
Submitted by: Chris Darroch chrisd
William A. Rowe, Jr. wrote:
Ok, I've done committed both, the fix to trunk, and the reversion of this
feature from trunk and 1.3 per the list discussion. Don't be shy about
picking up this particular rev if the feature interests you and you want
to round it out. But please, don't coopt
On Tue, 2008-05-20 at 06:55 -0400, Bob Rossi wrote:
OK, I can try this, however, this patch still doesn't work on windows. I
get link errors on windows because the the libs aren't linked in.
$ ./pg_config --libs
-lpgport -lm -lSecur32 -lws2_32 -lshfolder
$ ./pg_config --libdir
On Wed, 2008-05-21 at 06:59 +1000, Bojan Smojver wrote:
OK, not a problem. We'll whack libs in there too.
Done. Hopefully that should be it.
--
Bojan
I'm getting this (APR 1.2.x):
-
strings/apr_snprintf.c: In function 'apr_vformatter':
strings/apr_snprintf.c:1253: warning: comparison with string literal
results in unspecified behavior
-
The line is:
On Wed, May 21, 2008 at 07:14:44AM +1000, Bojan Smojver wrote:
On Wed, 2008-05-21 at 06:59 +1000, Bojan Smojver wrote:
OK, not a problem. We'll whack libs in there too.
Done. Hopefully that should be it.
Okay, this still doesn't work on windows, there are a couple changes I
would suggest,
On Tue, 2008-05-20 at 19:34 -0400, Bob Rossi wrote:
--- apr-util-1.3.x-2008-05-19-svn/build/dbd.m4 Tue May 20 17:15:38 2008
+++ apr-util-1.3.x-2008-05-19-svn.changed/build/dbd.m4 Tue May 20 19:18:23
2008
@@ -53,7 +53,8 @@
AC_PATH_PROG([PGSQL_CONFIG],[pg_config],,[$withval/bin])
On Wed, May 21, 2008 at 09:49:37AM +1000, Bojan Smojver wrote:
On Tue, 2008-05-20 at 19:34 -0400, Bob Rossi wrote:
--- apr-util-1.3.x-2008-05-19-svn/build/dbd.m4 Tue May 20 17:15:38 2008
+++ apr-util-1.3.x-2008-05-19-svn.changed/build/dbd.m4 Tue May 20 19:18:23
2008
@@ -53,7 +53,8 @@
On Tue, 2008-05-20 at 20:04 -0400, Bob Rossi wrote:
I noticed you changed everything but the AC_CHECK_LIB, do you believe
that is unnecessary, or are you thinking about it?
Not required. We set LDFLAGS specifically for the test (hence the
APR_ADDTO(LDFLAGS, [$pgsql_LDFLAGS])) and then we
On Wed, May 21, 2008 at 10:07:25AM +1000, Bojan Smojver wrote:
On Tue, 2008-05-20 at 20:04 -0400, Bob Rossi wrote:
I noticed you changed everything but the AC_CHECK_LIB, do you believe
that is unnecessary, or are you thinking about it?
Not required. We set LDFLAGS specifically for the
On Tue, 2008-05-20 at 20:26 -0400, Bob Rossi wrote:
That's because as you can see the -lpq went at the
end which is incorrect.
The real problem is that we're adding libraries to LDFLAGS. We should be
adding them to LIBS. I meant to fix that long time ago, but I always get
put off by the fact
On Wed, May 21, 2008 at 11:36:55AM +1000, Bojan Smojver wrote:
On Tue, 2008-05-20 at 20:26 -0400, Bob Rossi wrote:
That's because as you can see the -lpq went at the
end which is incorrect.
The real problem is that we're adding libraries to LDFLAGS. We should be
adding them to LIBS. I
On Tue, 2008-05-20 at 21:47 -0400, Bob Rossi wrote:
That worked on windows! I don't have time to test linux now.
Thanks for testing. It works on Linux.
--
Bojan
15 matches
Mail list logo
