Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Philip M. Gollucci
Bojan Smojver wrote: On Mon, 2009-06-08 at 23:16 -0400, Philip M. Gollucci wrote: -ldb* is never added to APRUTIL_EXPORT_LIBS so that apu-config.in - apu-1-config can report on whats there using (i.e. from subversion) Probably the result of moving the DBM (not DBD) to DSO. right Berkley DB

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Philip M. Gollucci
William A. Rowe, Jr. wrote: Bojan Smojver wrote: On Mon, 2009-06-08 at 23:16 -0400, Philip M. Gollucci wrote: -ldb* is never added to APRUTIL_EXPORT_LIBS so that apu-config.in - apu-1-config can report on whats there using (i.e. from subversion) Probably the result of moving the DBM (not DBD)

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Philip M. Gollucci
The question I need answered is 1.3.3/1.3.4: apu-1-config --libs -ldb -lgdbm ... 1.3.5/1.3.7: apu-1-config --libs ... What is the 'new' appropriate way to determine in 'autotools' that apu has bdb support by a third party ?

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Philip M. Gollucci
Philip M. Gollucci wrote: The question I need answered is 1.3.3/1.3.4: apu-1-config --libs -ldb -lgdbm ... 1.3.5/1.3.7: apu-1-config --libs ... What is the 'new' appropriate way to determine in 'autotools' that apu has bdb support by a third party ? I've duplicate the situation

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Bojan Smojver
On Tue, 2009-06-09 at 02:24 -0400, Philip M. Gollucci wrote: No I just want SUBVERSION to be able to tell that APR-UTIL was compiled with ANY BDB support. If I do 'grep -rl apr_dbm *' in subversion-1.6.2 source, I don't get any hits. You sure SVN actually uses that? BTW, have you tried

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Philip M. Gollucci
Bojan Smojver wrote: On Tue, 2009-06-09 at 02:24 -0400, Philip M. Gollucci wrote: No I just want SUBVERSION to be able to tell that APR-UTIL was compiled with ANY BDB support. If I do 'grep -rl apr_dbm *' in subversion-1.6.2 source, I don't get any hits. You sure SVN actually uses that?

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Philip M. Gollucci
Bojan Smojver wrote: On Tue, 2009-06-09 at 02:24 -0400, Philip M. Gollucci wrote: No I just want SUBVERSION to be able to tell that APR-UTIL was compiled with ANY BDB support. If I do 'grep -rl apr_dbm *' in subversion-1.6.2 source, I don't get any hits. You sure SVN actually uses that?

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Bojan Smojver
On Tue, 2009-06-09 at 03:18 -0400, Philip M. Gollucci wrote: libsvn_fs_base is compiled if BDB support is detected. I think it calls Berkeley DB API directly, not via APU. Hence, the fact that -ldb was part of apu-1-config --libs, was just a historical accident. If a program calls apr_dbm*(),

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Philip M. Gollucci
Bojan Smojver wrote: On Tue, 2009-06-09 at 03:18 -0400, Philip M. Gollucci wrote: libsvn_fs_base is compiled if BDB support is detected. I think it calls Berkeley DB API directly, not via APU. Hence, the fact that -ldb was part of apu-1-config --libs, was just a historical accident. If a

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Bojan Smojver
On Tue, 2009-06-09 at 03:35 -0400, Philip M. Gollucci wrote: Excellent, Bojan, now I've got the history and why, and understand whats happened. I don't think teaching subversion about this fact will be sufficient -- There are over 56 apps in the freebsd ports tree with over 900 depends

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Branko Čibej
Bojan Smojver wrote: PS. Subversion itself depends on Berkeley DB directly, not through APU, so passing that to ./configure there should be sufficient to build it. At least it worked for me (although the syntax of the argument itself can be daunting:

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Philip M. Gollucci
Bojan Smojver wrote: So, there are apps out there that specifically depend on -ldb being returned by apu-1-config? Can you give me an example so that I can get my head around this better? PS. Subversion itself depends on Berkeley DB directly, not through APU, so passing that to ./configure

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Bojan Smojver
On Tue, 2009-06-09 at 17:29 +1000, Bojan Smojver wrote: PS. We do have a workaround for ldap along these lines, where we report ldap in --libs, unless --avoid-ldap is passed to the config script. Maybe we should do this here, to avoid breaking compilation compatibility. Opinions? Quick and

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Bojan Smojver
On Tue, 2009-06-09 at 18:01 +1000, Bojan Smojver wrote: Quick and dirty... Or to preserve the original order, this one. -- Bojan Index: apu-config.in === --- apu-config.in (revision 782876) +++ apu-config.in (working copy) @@

Re: Darwin and poll()

2009-06-09 Thread Jeff Trawick
On Sun, Jun 7, 2009 at 10:59 PM, William A. Rowe, Jr. wr...@rowe-clan.netwrote: Jeff Trawick wrote: Can anyone recreate problems with poll() on any of the branches, using that patch with 1.3.x? As of a few minutes ago, trunk and 1.4.x will use poll(), but 1.3.x needs a tweak to

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread William A. Rowe, Jr.
Bojan Smojver wrote: On Tue, 2009-06-09 at 17:29 +1000, Bojan Smojver wrote: PS. We do have a workaround for ldap along these lines, where we report ldap in --libs, unless --avoid-ldap is passed to the config script. Maybe we should do this here, to avoid breaking compilation compatibility.

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Joe Orton
On Tue, Jun 09, 2009 at 09:03:16AM -0500, William Rowe wrote: As a packager, I can see how you might view 1.3.4- as a minor version rev, but from the perspective of any user deploying a package linked against 1.3.4 and migrating to 1.3.7, no packages need to be recompiled. That is binary

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread William A. Rowe, Jr.
Joe Orton wrote: On Tue, Jun 09, 2009 at 09:03:16AM -0500, William Rowe wrote: As a packager, I can see how you might view 1.3.4- as a minor version rev, but from the perspective of any user deploying a package linked against 1.3.4 and migrating to 1.3.7, no packages need to be recompiled.

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Joe Orton
On Tue, Jun 09, 2009 at 10:58:24AM -0500, William Rowe wrote: Joe Orton wrote: On Tue, Jun 09, 2009 at 09:03:16AM -0500, William Rowe wrote: As a packager, I can see how you might view 1.3.4- as a minor version rev, but from the perspective of any user deploying a package linked against

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread William A. Rowe, Jr.
Joe Orton wrote: On Tue, Jun 09, 2009 at 10:58:24AM -0500, William Rowe wrote: Joe Orton wrote: On Tue, Jun 09, 2009 at 09:03:16AM -0500, William Rowe wrote: As a packager, I can see how you might view 1.3.4- as a minor version rev, but from the perspective of any user deploying a package

Odd thing in apr_procattr_io_set

2009-06-09 Thread Ruediger Pluem
While investigating PR47355 for httpd (https://issues.apache.org/bugzilla/show_bug.cgi?id=47335) I came across an odd thing in apr_procattr_io_set: if ((out != APR_NO_PIPE) (out != APR_NO_FILE)) { if ((rv = apr_file_pipe_create_ex(attr-parent_out, attr-child_out,

Re: Odd thing in apr_procattr_io_set

2009-06-09 Thread William A. Rowe, Jr.
Ruediger Pluem wrote: While investigating PR47355 for httpd (https://issues.apache.org/bugzilla/show_bug.cgi?id=47335) I came across an odd thing in apr_procattr_io_set: if ((out != APR_NO_PIPE) (out != APR_NO_FILE)) { if ((rv = apr_file_pipe_create_ex(attr-parent_out,

Re: ports/135396: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Philip M. Gollucci
-ldb* is never added to APRUTIL_EXPORT_LIBS so that apu-config.in - apu-1-config can report on whats there using (i.e. from subversion) A patch, waiting on upstream decision (T-1 one day before I just drop in for now) --

Re: svn commit: r783048 - /apr/apr-util/branches/1.4.x/build/dso.m4

2009-06-09 Thread Philip M. Gollucci
jor...@apache.org wrote: Author: jorton Date: Tue Jun 9 15:44:09 2009 New Revision: 783048 URL: http://svn.apache.org/viewvc?rev=783048view=rev Log: Merge r783046 from 1.3.x (sorry, doing this backwards): Doesn't doing this wreak havoc on the svn:mergeinfo ? --

Re: ports/135396: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread William A. Rowe, Jr.
Philip M. Gollucci wrote: -ldb* is never added to APRUTIL_EXPORT_LIBS so that apu-config.in - apu-1-config can report on whats there using (i.e. from subversion) A patch, waiting on upstream decision (T-1 one day before I just drop in for now) Foolish question, but for reference is

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Bojan Smojver
On Tue, 2009-06-09 at 10:58 -0500, William A. Rowe, Jr. wrote: You are not missing anything, and solutions are welcomed. I'm not sure that I'm addressing the right problem here. So, limit yourself to rocks of no more than 2kg when throwing. Obviously, there is no guarantee that int's are

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Bojan Smojver
On Wed, 2009-06-10 at 10:53 +1000, Bojan Smojver wrote: also initialise it from apr_initialize() Eh, which is already the case. -- Bojan

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread William A. Rowe, Jr.
Bojan Smojver wrote: On Tue, 2009-06-09 at 10:58 -0500, William A. Rowe, Jr. wrote: You are not missing anything, and solutions are welcomed. I'm not sure that I'm addressing the right problem here. So, limit yourself to rocks of no more than 2kg when throwing. :) Obviously, there is no

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread William A. Rowe, Jr.
Bojan Smojver wrote: On Wed, 2009-06-10 at 10:53 +1000, Bojan Smojver wrote: also initialise it from apr_initialize() Eh, which is already the case. In trunk, you mean :)

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Bojan Smojver
On Tue, 2009-06-09 at 20:01 -0500, William A. Rowe, Jr. wrote: In trunk, you mean :) You are right. Fooled again by grep (also returns things within comments :-). -- Bojan

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Bojan Smojver
On Wed, 2009-06-10 at 10:53 +1000, Bojan Smojver wrote: so we can replace the int's with apr_uint32_t Just for the record. -- Bojan Index: misc/apu_dso.c === --- misc/apu_dso.c (revision 783165) +++ misc/apu_dso.c (working copy)

Re: ports/135396: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Philip M. Gollucci
William A. Rowe, Jr. wrote: Philip M. Gollucci wrote: -ldb* is never added to APRUTIL_EXPORT_LIBS so that apu-config.in - apu-1-config can report on whats there using (i.e. from subversion) A patch, waiting on upstream decision (T-1 one day before I just drop in for now) Foolish

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Bojan Smojver
On Wed, 2009-06-10 at 11:13 +1000, Bojan Smojver wrote: Just for the record. Or, maybe even this. Compiles and passes make check (surprisingly!). -- Bojan Index: misc/apu_dso.c === --- misc/apu_dso.c (revision 783165) +++

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Bojan Smojver
On Wed, 2009-06-10 at 11:34 +1000, Bojan Smojver wrote: Or, maybe even this. Compiles and passes make check (surprisingly!). Here is a go-crazy patch. Deals with LDAP, DBD, DBM and DSO init itself. -- Bojan Index: ldap/apr_ldap_stub.c

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Bojan Smojver
On Wed, 2009-06-10 at 12:19 +1000, Bojan Smojver wrote: Deals with LDAP, DBD, DBM and DSO init itself. Actually, that LDAP thing is not required. -- Bojan

Re: [MAINTAINER] devel/apr-gdbm-db42: apr-util 1.3.7 breaks dbd support

2009-06-09 Thread Bojan Smojver
On Wed, 2009-06-10 at 13:51 +1000, Bojan Smojver wrote: Actually, that LDAP thing is not required. So, here are the two patches. One for trunk (for now, until this gets fixed properly) and one for 1.3.x/1.4.x. -- Bojan Index: dbd/apr_dbd.c