RE: svn commit: r1231605 - /apr/apr/trunk/tables/apr_hash.c

2012-01-16 Thread Bojan Smojver
On Sun, 2012-01-15 at 18:06 +0100, Bert Huijben wrote: If the timer has enough detail we could just use the time, ptr combination as the seed here. See whether you like r1231858. -- Bojan

Re: svn commit: r1231605 - /apr/apr/trunk/tables/apr_hash.c

2012-01-16 Thread Ruediger Pluem
Bojan Smojver wrote: On Sun, 2012-01-15 at 18:06 +0100, Bert Huijben wrote: If the timer has enough detail we could just use the time, ptr combination as the seed here. See whether you like r1231858. r1231605 and r1231858 cause massive regressions and test case failures in httpd. Not

Re: Hash collision vectors in APR?

2012-01-16 Thread Joe Orton
On Thu, Jan 05, 2012 at 01:35:50PM -0500, Jeff Trawick wrote: We don't want to say go fish to APR applications if our hash plus their vector results in an exploit. I'll bite. 1) Chained hash tables have quadratic worst case insertion time, O(n**2). The APR hash table (apr_hash_*)

Re: svn commit: r1231605 - /apr/apr/trunk/tables/apr_hash.c

2012-01-16 Thread Bojan Smojver
--- Original message --- From: Ruediger Pluem r1231605 and r1231858 cause massive regressions and test case failures in httpd. I won't be able to commit for a while. Please feel free to revert both. Sorry about the breakage. :-( -- Bojan

Re: svn commit: r1231605 - /apr/apr/trunk/tables/apr_hash.c

2012-01-16 Thread Bojan Smojver
--- Original message --- From: Bojan Smojver Sent: 17.1.'12, 5:18 --- Original message --- From: Ruediger Pluem r1231605 and r1231858 cause massive regressions and test case failures in httpd. I won't be able to commit for a while. Please feel free to revert both. Sorry

Re: svn commit: r1231605 - /apr/apr/trunk/tables/apr_hash.c

2012-01-16 Thread Bojan Smojver
--- Original message --- From: Bojan Smojver Sent: 17.1.'12, 5:18 --- Original message --- From: Ruediger Pluem r1231605 and r1231858 cause massive regressions and test case failures in httpd. I won't be able to commit for a while. Please feel free to revert both. Sorry