Re: svn commit: r1917099 - /apr/apr/trunk/test/testldap.c

2024-04-18 Thread Ivan Zhakov via dev
On Thu, 18 Apr 2024 at 09:58, Graham Leggett via dev wrote: > On 18 Apr 2024, at 08:48, minf...@apache.org wrote: > > > URL: http://svn.apache.org/viewvc?rev=1917099=rev > > Log: > > Add the LDAP test case. > > I am getting a failure on Windows about a missing symbol, I am assuming > the changes

Re: Release APR 1.7.3 ?

2023-03-25 Thread Ivan Zhakov via dev
On Fri, 24 Mar 2023 at 17:56, Ruediger Pluem wrote: > Is someone opposed if I put an APR 1.7.x release for vote on the beginning > of next week? > It would be my first APR release, but I think I should be able to do it > with the instructions in release.sh (thanks Eric). > Otherwise I will ask

Re: svn commit: r1906889 - in /apr/apr/trunk: ./ build/ include/ include/arch/win32/ test/ threadproc/beos/ threadproc/netware/ threadproc/os2/ threadproc/unix/ threadproc/win32/

2023-03-16 Thread Ivan Zhakov via dev
Hello Rainer, I have very little knowledge about autoconf stuff. The autoconf part was suggest by Yann in [1] Yann: do you have any ideas why it does not work? Thanks! [1] https://lists.apache.org/thread/6j6zm4x15ng04y3tws4w0zoc7vhx3fp8 On Thu, 16 Mar 2023 at 16:01, Rainer Jung wrote: >

Re: Added switch_thread_getname and switch_thread_setname

2023-02-16 Thread Ivan Zhakov via dev
On Sun, 15 Jan 2017 at 18:43, Sergey Safarov wrote: > Hello > For process monitoring and troubleshooting i prefer have individual name > for each thread. > I submitted pull request with added unix implementation of > apr_thread_setname and apr_thread_getname. > > Could you please review this

Re: svn commit: r1907634 - /apr/apr/trunk/include/apr_buckets.h

2023-02-14 Thread Ivan Zhakov via dev
On Tue, 14 Feb 2023 at 10:58, wrote: > Author: jailletc36 > Date: Tue Feb 14 07:56:50 2023 > New Revision: 1907634 > > URL: http://svn.apache.org/viewvc?rev=1907634=rev > Log: > Re-order the fields of 'struct apr_bucket_file' to avoid a hole and some > padding. > > Before the patch, pahole

Re: Subversion reports status fault on substituted drive

2023-02-06 Thread Ivan Zhakov via dev
On Thu, 16 Jun 2022 at 21:06, Ivan Zhakov wrote: > On Wed, 5 Jan 2022 at 21:37, Ivan Zhakov wrote: > >> On Mon, 13 Sept 2021 at 11:57, Johan Corveleyn wrote: >> > >> > On Tue, Sep 7, 2021 at 3:58 PM Johan Corveleyn >> wrote: >> > > >> > > On Tue, Feb 23, 2021 at 9:59 AM Mariusz W wrote: >> >

Re: [RFC] Add apr_thread_name_get()/apr_thread_name_set() API

2023-01-21 Thread Ivan Zhakov via dev
On Tue, 12 Jul 2022 at 12:01, Ivan Zhakov wrote: > I have implemented new apr_thread_name_get()/apr_thread_name_set() API in > branch 'thread-name': > https://svn.apache.org/repos/asf/apr/apr/branches/thread-name/ > > Implementation is based on patch in issue 60587 [1]. Currently it supports >

Re: VOTE: Release apr-1.7.1-rc2 as 1.7.1

2023-01-21 Thread Ivan Zhakov via dev
On Fri, 20 Jan 2023 at 03:44, Eric Covener wrote: > 1.7.1-rc1 is here: > > https://apr.apache.org/dev/dist/ > > For the release of apr-1.7.1 > [X ] +1 looks great! > [ ] -1 something is broken > > +1 (Windows) -- Ivan Zhakov

Re: Remaining breakage on apr-1.7.x branch

2022-09-13 Thread Ivan Zhakov via dev
On Mon, 12 Sept 2022 at 17:21, William A Rowe Jr wrote: > After deep study of the whole ring strict alias issue, I've come to > the conclusion that > the -resulting- binary is effectively the same, and my test case was > swapping the > apr .so files between builds of httpd 2.4.54 / apr 1.7.0 and

Re: Remaining breakage on apr-1.7.x branch

2022-08-08 Thread Ivan Zhakov via dev
On Thu, 28 Jul 2022 at 19:59, William A Rowe Jr wrote: > Hello friends and collaborators, > > I'm still rather certain this change is ABI and API contract-breaking > on the apr-1.7.x branch, which holds the project hostage for providing > a well-understood security fix on the legacy branch. Such

Re: Issues with shipping apr_thread_current() in APR 1.8.0 and an alternative approach for PCRE2 allocations in HTTPD

2022-07-12 Thread Ivan Zhakov via dev
On Wed, 29 Jun 2022 at 01:28, Yann Ylavic wrote: > > On Tue, Jun 28, 2022 at 6:08 PM Ivan Zhakov wrote: > > > > On Tue, 28 Jun 2022 at 00:24, Yann Ylavic wrote: > > > > > > Hi Ivan, > > > > > > On Mon, Jun 27, 2022 at 8:19 PM Ivan Zhakov wrote: > > > > > > > > For the longer version, let me

[RFC] Add apr_thread_name_get()/apr_thread_name_set() API

2022-07-12 Thread Ivan Zhakov via dev
I have implemented new apr_thread_name_get()/apr_thread_name_set() API in branch 'thread-name': https://svn.apache.org/repos/asf/apr/apr/branches/thread-name/ Implementation is based on patch in issue 60587 [1]. Currently it supports the posix platform that supports pthread_setname_np and

Re: [PATCH] Rewrite ap_regexec() without using thread-local storage and malloc()/free() (was: Issues with shipping apr_thread_current() in APR 1.8.0 and an alternative approach for PCRE2 allocations i

2022-07-11 Thread Ivan Zhakov via dev
On Fri, 8 Jul 2022 at 19:15, Ivan Zhakov wrote: > > On Thu, 30 Jun 2022 at 20:14, Ivan Zhakov wrote: > > > > > > > I think that we could try an alternative approach for that part of > > > > > the problem. The alternative approach would have the same > > > > > characteristics as the approach

Re: [PATCH] Rewrite ap_regexec() without using thread-local storage and malloc()/free() (was: Issues with shipping apr_thread_current() in APR 1.8.0 and an alternative approach for PCRE2 allocations i

2022-07-08 Thread Ivan Zhakov via dev
On Thu, 30 Jun 2022 at 20:14, Ivan Zhakov wrote: > > > > > I think that we could try an alternative approach for that part of the > > > > problem. The alternative approach would have the same characteristics > > > > as the approach that had been used for PCRE1: > > > > > > > > -- Supply PCRE2

Re: svn commit: r1902378 - in /apr/apr/branches/1.8.x: ./ CHANGES file_io/win32/readwrite.c test/testfile.c

2022-07-01 Thread Ivan Zhakov via dev
On Fri, 1 Jul 2022 at 01:10, Yann Ylavic wrote: > > On Fri, Jul 1, 2022 at 12:00 AM Yann Ylavic wrote: > > > > On Thu, Jun 30, 2022 at 7:28 PM wrote: > > > > > > Author: ivan > > > Date: Thu Jun 30 17:28:50 2022 > > > New Revision: 1902378 > > > > > > URL:

Re: GitHub Actions CI

2022-06-30 Thread Ivan Zhakov via dev
On Fri, 24 Jun 2022 at 14:21, Yann Ylavic wrote: > > On Wed, Jun 22, 2022 at 2:26 PM Ivan Zhakov via dev > wrote: > > > > Suggestions and improvements are welcome. > > I don't see any warning left in trunk and 1.8.x, possibly we'd have a > Windows /Werror build

[PATCH] Rewrite ap_regexec() without using thread-local storage and malloc()/free() (was: Issues with shipping apr_thread_current() in APR 1.8.0 and an alternative approach for PCRE2 allocations in HT

2022-06-30 Thread Ivan Zhakov via dev
> > > I think that we could try an alternative approach for that part of the > > > problem. The alternative approach would have the same characteristics as > > > the approach that had been used for PCRE1: > > > > > > -- Supply PCRE2 with a custom context with malloc and free > > >

Re: svn commit: r1902297 - in /apr/apr/branches/thread-name: include/ include/arch/win32/ test/ threadproc/beos/ threadproc/netware/ threadproc/os2/ threadproc/unix/ threadproc/win32/

2022-06-28 Thread Ivan Zhakov via dev
On Tue, 28 Jun 2022 at 14:45, Yann Ylavic wrote: > > On Tue, Jun 28, 2022 at 1:13 AM wrote: > > > > Author: ivan > > Date: Mon Jun 27 23:13:52 2022 > > New Revision: 1902297 > > > > URL: http://svn.apache.org/viewvc?rev=1902297=rev > > Log: > > On 'thread-name' branch: Add apr_thread_name_get()

Re: Issues with shipping apr_thread_current() in APR 1.8.0 and an alternative approach for PCRE2 allocations in HTTPD

2022-06-28 Thread Ivan Zhakov via dev
On Tue, 28 Jun 2022 at 00:24, Yann Ylavic wrote: > > Hi Ivan, > > On Mon, Jun 27, 2022 at 8:19 PM Ivan Zhakov wrote: > > > > For the longer version, let me first outline a few problems with the > > current apr_thread_current() API: > > > > 1) apr_thread_current_create() leaks the memory

Re: svn commit: r1902312 - /apr/apr/trunk/network_io/win32/sendrecv.c

2022-06-28 Thread Ivan Zhakov via dev
On Tue, 28 Jun 2022 at 14:08, wrote: > > Author: ylavic > Date: Tue Jun 28 11:08:32 2022 > New Revision: 1902312 > > URL: http://svn.apache.org/viewvc?rev=1902312=rev > Log: > apr_socket_sendv: WIN32: Limit the number of WSABUFs allocated for a single > call. > > * network_io/win32/sendrecv.c():

Re: svn commit: r1902285 - /apr/apr/trunk/test/testencode.c

2022-06-27 Thread Ivan Zhakov via dev
On Mon, 27 Jun 2022 at 21:40, Yann Ylavic wrote: > On Mon, Jun 27, 2022 at 8:35 PM Ivan Zhakov wrote: > > > > On Mon, 27 Jun 2022 at 21:14, Yann Ylavic wrote: > >> > >> On Mon, Jun 27, 2022 at 8:08 PM Ivan Zhakov wrote: > >> > > >> > On Mon, 27 Jun 2022 at 21:01, wrote: > >> >> > >> >>

Re: svn commit: r1902285 - /apr/apr/trunk/test/testencode.c

2022-06-27 Thread Ivan Zhakov via dev
On Mon, 27 Jun 2022 at 21:14, Yann Ylavic wrote: > On Mon, Jun 27, 2022 at 8:08 PM Ivan Zhakov wrote: > > > > On Mon, 27 Jun 2022 at 21:01, wrote: > >> > >> +#ifdef WIN32 > >> +typedef apr_status_t (__stdcall *encdec_fn)(char*, const char*, > apr_ssize_t, int, apr_size_t*); > >> +#else > >>

Issues with shipping apr_thread_current() in APR 1.8.0 and an alternative approach for PCRE2 allocations in HTTPD

2022-06-27 Thread Ivan Zhakov via dev
Hi, I have some concerns about the apr_thread_current() functionality that is a part of the APR 1.8.x branch, but is not yet released. The short version is: I think that the apr_thread_current() API has multiple problems and that shipping it in 1.8.0 in its current state would be a mistake. As

Re: svn commit: r1902285 - /apr/apr/trunk/test/testencode.c

2022-06-27 Thread Ivan Zhakov via dev
On Mon, 27 Jun 2022 at 21:01, wrote: > Author: ylavic > Date: Mon Jun 27 18:01:27 2022 > New Revision: 1902285 > > URL: http://svn.apache.org/viewvc?rev=1902285=rev > Log: > testencode: Follow up to r1902281: Correct call convention for encdec_fn > (try 2). > > > Modified: >

Re: Spurious testreslist failures on Windows (was Re: GitHub Actions CI)

2022-06-22 Thread Ivan Zhakov via dev
On Wed, 22 Jun 2022 at 19:26, Yann Ylavic wrote: > On Wed, Jun 22, 2022 at 5:57 PM Ivan Zhakov wrote: > > > > On Wed, 22 Jun 2022 at 17:29, Yann Ylavic wrote: > > > >> > >> PS: now the macos guys have some work > >> (https://github.com/apache/apr/runs/7004338300?check_suite_focus=true) > >> :)

Spurious testreslist failures on Windows (was Re: GitHub Actions CI)

2022-06-22 Thread Ivan Zhakov via dev
On Wed, 22 Jun 2022 at 17:29, Yann Ylavic wrote: > PS: now the macos guys have some work > (https://github.com/apache/apr/runs/7004338300?check_suite_focus=true) > :) > Also testreslist fails sometimes on Windows: https://github.com/apache/apr/runs/7003387964?check_suite_focus=true [[[ 48/77

GitHub Actions CI

2022-06-22 Thread Ivan Zhakov via dev
As far I understand Apache Infra recommends to migrate Continuous Integration builds from Travis to GitHub Actions. I've added initial configuration for GitHub Actions for APR project: https://svn.apache.org/repos/asf/apr/apr/trunk/.github/workflows/ GitHub supports Linux, macOS and Windows

Re: svn commit: r1902143 - /apr/apr/trunk/.github/workflows/linux.yml

2022-06-21 Thread Ivan Zhakov via dev
On Tue, 21 Jun 2022 at 19:56, Yann Ylavic wrote: > On Tue, Jun 21, 2022 at 6:21 PM Ivan Zhakov wrote: > > > > On Tue, 21 Jun 2022 at 19:16, Yann Ylavic wrote: > >> > >> On Tue, Jun 21, 2022 at 5:58 PM Ivan Zhakov wrote: > >> > > >> > On Tue, 21 Jun 2022 at 18:33, Yann Ylavic > wrote: > >> >>

Re: svn commit: r1902143 - /apr/apr/trunk/.github/workflows/linux.yml

2022-06-21 Thread Ivan Zhakov via dev
On Tue, 21 Jun 2022 at 18:33, Yann Ylavic wrote: > Hi Ivan, > > I'm responding randomly to one of your ci commits, first to say > thanks, really nice and valuable work! > > I have a question too :) Sorry if it's premature, but I'm also > wondering why we don't see the outputs of the jobs in the

Re: svn commit: r1902120 - in /apr/apr/branches/1.8.x: ./ test/testfile.c

2022-06-21 Thread Ivan Zhakov via dev
On Tue, 21 Jun 2022 at 17:57, Yann Ylavic wrote: > On Mon, Jun 20, 2022 at 11:57 PM wrote: > > > > Author: ivan > > Date: Mon Jun 20 21:57:13 2022 > > New Revision: 1902120 > > > > URL: http://svn.apache.org/viewvc?rev=1902120=rev > > > [] > > --- apr/apr/branches/1.8.x/test/testfile.c

Re: Subversion reports status fault on substituted drive

2022-06-16 Thread Ivan Zhakov via dev
On Wed, 5 Jan 2022 at 21:37, Ivan Zhakov wrote: > On Mon, 13 Sept 2021 at 11:57, Johan Corveleyn wrote: > > > > On Tue, Sep 7, 2021 at 3:58 PM Johan Corveleyn > wrote: > > > > > > On Tue, Feb 23, 2021 at 9:59 AM Mariusz W wrote: > > > > On 2021/01/26 14:54:04, Johan Corveleyn wrote: > > > >

Re: Build errors in branches/1.8.x on Windows

2022-06-15 Thread Ivan Zhakov via dev
ully not support those calls, > conditionally, when the function > doesn't exist on an older version of the OS. > > I checked, it's building fine here, did you forget to mention your > arguments to the cmake > invocation so we can sort this out? Which MSVC and which Windows SDK? >

Build errors in branches/1.8.x on Windows

2022-06-14 Thread Ivan Zhakov via dev
When building using CMake: C:\PROGRA~1\MIB055~1\2022\PROFES~1\VC\Tools\MSVC\1432~1.313\bin\Hostx64\x64\cl.exe /nologo -DAPR_APP -DWINNT -IC:\Ivan\SVN\apr\apr-1.8.x\out\build\x64-Debug -IC:\Ivan\SVN\apr\apr-1.8.x\include -IC:\Ivan\SVN\apr\apr-1.8.x\include\arch\win32