notroj opened a new pull request, #56:
URL: https://github.com/apache/apr/pull/56
```
* file_io/unix/pipe.c (file_pipe_create): Use pipe2(,O_NONBLOCK) by
default unless APR_FULL_BLOCK was used; unconditionally set the
blocking state later. Saves two syscalls per invocation for
asfgit closed pull request #55: Add support for pipe2() on Linux.
URL: https://github.com/apache/apr/pull/55
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
notroj opened a new pull request, #55:
URL: https://github.com/apache/apr/pull/55
```
* configure.in: Test for working pipe2().
* file_io/unix/pipe.c (file_pipe_create): Use pipe2(,O_NONBLOCK) if
APR_FULL_NONBLOCK is requested.
* test/testpipe.c (nonblock_pipe): New test.
ylavic commented on PR #42:
URL: https://github.com/apache/apr/pull/42#issuecomment-1994544494
Thanks for the patch, now in
https://github.com/apache/apr/commit/96f9855f4f80cf831fb7c9a8379ab4490f17f378
(https://svn.apache.org/repos/asf/apr/apr/trunk@1916276)
--
This is an automated
asfgit closed pull request #42: filelock is not unlocked
URL: https://github.com/apache/apr/pull/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kanavin opened a new pull request, #54:
URL: https://github.com/apache/apr/pull/54
The disabled tests rely on timing to pass correctly. On a virtualized system
under heavy load, these tests randomly fail because they miss a timer or other
timing related issues.
--
This is an automated
Biswa96 closed pull request #48: configure: Add bcrypt library for Windows
target
URL: https://github.com/apache/apr/pull/48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
asfgit closed pull request #53: apr_brigade_split_line fix for LF handling
URL: https://github.com/apache/apr/pull/53
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
notroj opened a new pull request, #53:
URL: https://github.com/apache/apr/pull/53
```
* buckets/apr_brigade.c (apr_brigade_split_line): After finding an LF,
only split the bucket if the LF is not the last character in the
data.
* test/testbuckets.c
notroj closed pull request #52: Fix handling of metadata buckets in
apr_brigade_*
URL: https://github.com/apache/apr/pull/52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
notroj commented on PR #52:
URL: https://github.com/apache/apr/pull/52#issuecomment-1862414137
Fixed in 2adcf636fe92572905283835c75ec6e44f5eee5e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
notroj opened a new pull request, #52:
URL: https://github.com/apache/apr/pull/52
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ylavic commented on PR #51:
URL: https://github.com/apache/apr/pull/51#issuecomment-1841330815
Thanks, now in r1914368 (bd6e07290c9cb555069b78b77fc5276d911d7159)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
asfgit closed pull request #51: dbd & dso: ensure functions are declared
correctly according to C spec
URL: https://github.com/apache/apr/pull/51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
igalic opened a new pull request, #51:
URL: https://github.com/apache/apr/pull/51
apr_dbd_mutex_lock/unlock() and apr_status_t apu_dso_mutex_lock/unlock()
functions were declared without a (void). This causes warnings like:
> dbd/apr_dbd.c:50:45: warning: a function declaration
notroj commented on PR #50:
URL: https://github.com/apache/apr/pull/50#issuecomment-1780988424
Thanks @uhliarik
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
asfgit closed pull request #50: Fix test failure on i686 due to too big map size
URL: https://github.com/apache/apr/pull/50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
uhliarik opened a new pull request, #50:
URL: https://github.com/apache/apr/pull/50
On i686 vt_lmdb_open() was failing, because UINT32_MAX (4GB) was incorrectly
used as database size instead of INT32_MAX (2GB).
--
This is an automated message from the Apache Git Service.
To respond to
ylavic commented on code in PR #49:
URL: https://github.com/apache/apr/pull/49#discussion_r1370436413
##
dbm/apr_dbm_lmdb.c:
##
@@ -156,14 +168,16 @@ static void vt_lmdb_close(apr_dbm_t *dbm)
{
real_file_t *f = dbm->file;
-if (f->cursor) {
-
asfgit closed pull request #49: apr_dbm_lmdb.c: better error handling and better
URL: https://github.com/apache/apr/pull/49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
notroj commented on code in PR #49:
URL: https://github.com/apache/apr/pull/49#discussion_r1370260493
##
dbm/apr_dbm_lmdb.c:
##
@@ -216,9 +230,14 @@ static apr_status_t vt_lmdb_store(apr_dbm_t *dbm,
apr_datum_t key,
if ((rv = mdb_put(f->txn, f->dbi, , , 0)) == 0) {
uhliarik commented on code in PR #49:
URL: https://github.com/apache/apr/pull/49#discussion_r1370095013
##
dbm/apr_dbm_lmdb.c:
##
@@ -216,9 +230,14 @@ static apr_status_t vt_lmdb_store(apr_dbm_t *dbm,
apr_datum_t key,
if ((rv = mdb_put(f->txn, f->dbi, , , 0)) == 0) {
notroj commented on PR #49:
URL: https://github.com/apache/apr/pull/49#issuecomment-1776804513
Also just a comment on code style - use `if (blah) {` rather than `if
(blah){` without a space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
notroj commented on code in PR #49:
URL: https://github.com/apache/apr/pull/49#discussion_r1369834921
##
dbm/apr_dbm_lmdb.c:
##
@@ -237,9 +256,14 @@ static apr_status_t vt_lmdb_del(apr_dbm_t *dbm,
apr_datum_t key)
if ((rv = mdb_del(f->txn, f->dbi, , NULL)) == 0) {
uhliarik opened a new pull request, #49:
URL: https://github.com/apache/apr/pull/49
checking of return values of mdb* functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Biswa96 opened a new pull request, #48:
URL: https://github.com/apache/apr/pull/48
bcrypt library is required for BCryptGenRandom function which is used
in misc/win32/rand.c file. This commit fixes the following linker error
misc/win32/rand.c:32:(.text+0x13):
asfgit closed pull request #47: sdbm: Fix old style function prototype warning
with clang
URL: https://github.com/apache/apr/pull/47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
notroj commented on PR #47:
URL: https://github.com/apache/apr/pull/47#issuecomment-1742526596
Thanks for the PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Biswa96 opened a new pull request, #47:
URL: https://github.com/apache/apr/pull/47
This fixes the following warning with clang
../dbm/sdbm/sdbm_pair.c:63:1: warning: a function definition without a
prototype is
deprecated in all versions of C and is not supported
notroj commented on PR #46:
URL: https://github.com/apache/apr/pull/46#issuecomment-1740939720
Thanks a lot for the contribution, @uhliarik
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
asfgit closed pull request #46: WIP: lmdb support
URL: https://github.com/apache/apr/pull/46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
uhliarik commented on PR #46:
URL: https://github.com/apache/apr/pull/46#issuecomment-1738905002
Thanks Joe for reviewing my changes. Previously, I was configurating the
lmdb driver with:
```
./configure --with-lmdb --with-dbm=lmdb
```
And I was having troubles with
notroj commented on PR #46:
URL: https://github.com/apache/apr/pull/46#issuecomment-1738859328
I've tested this with mod_dav and it seems to work well. As well as the
changes described above I changed the `_usednames` implementation to pass back
the "-lock" file as well:
notroj commented on PR #46:
URL: https://github.com/apache/apr/pull/46#issuecomment-1738652639
With the line marked in my review above removed, and
e147886e92b2858895fe9fff30fccf9dba678cad reverted, I can build with:
```sh
"./configure" \
"--with-lmdb" \
"--with-berkeley-db"
notroj commented on code in PR #46:
URL: https://github.com/apache/apr/pull/46#discussion_r1339682434
##
build.conf:
##
@@ -22,6 +22,7 @@ paths =
crypto/crypt_blowfish.c
dbm/apr_dbm_sdbm.c
dbm/apr_dbm.c
+ dbm/apr_dbm_lmdb.c
Review Comment:
This should be removed,
uhliarik commented on PR #46:
URL: https://github.com/apache/apr/pull/46#issuecomment-1737663511
Since I had to rebase this code to the trunk, I'm no longer able to run
tests. If anyone can see where I'm missing linking the library, feel free to
review the commit.
--
This is an
minfrin commented on PR #46:
URL: https://github.com/apache/apr/pull/46#issuecomment-1737357677
Not had a chance to review, but definite +1 in principle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
uhliarik opened a new pull request, #46:
URL: https://github.com/apache/apr/pull/46
There is still WIP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
setharnold commented on PR #45:
URL: https://github.com/apache/apr/pull/45#issuecomment-1703534387
Awesome, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jk2 commented on PR #45:
URL: https://github.com/apache/apr/pull/45#issuecomment-1703108180
Reconnect is MySQL specific option not affecting functionality of any other
code in APR whether enabled or disabled. Apache dbd and authn_dbd modules that
use APR correctly identified lost
setharnold commented on PR #45:
URL: https://github.com/apache/apr/pull/45#issuecomment-1701686823
It looks like it's been since `MYSQL_VERSION_ID >= 50013` that the automatic
reconnection behaviour has been in place. I could imagine since then that
there's new code in APR that isn't
jk2 opened a new pull request, #45:
URL: https://github.com/apache/apr/pull/45
The MySQL client library currently supports performing an automatic
reconnection to the server if it finds that the connection is down and an
application attempts to send a statement to the server to be
notroj commented on PR #44:
URL: https://github.com/apache/apr/pull/44#issuecomment-1609581760
Thanks Lubos!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
asfgit closed pull request #44: Fix socket creation when APR_UNSPEC is used
URL: https://github.com/apache/apr/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
uhliarik commented on code in PR #44:
URL: https://github.com/apache/apr/pull/44#discussion_r1243494966
##
memcache/apr_memcache.c:
##
@@ -346,18 +346,37 @@ APR_DECLARE(apr_status_t)
apr_memcache_disable_server(apr_memcache_t *mc, apr_me
return make_server_dead(mc, ms);
uhliarik commented on code in PR #44:
URL: https://github.com/apache/apr/pull/44#discussion_r1243494966
##
memcache/apr_memcache.c:
##
@@ -346,18 +346,37 @@ APR_DECLARE(apr_status_t)
apr_memcache_disable_server(apr_memcache_t *mc, apr_me
return make_server_dead(mc, ms);
uhliarik commented on code in PR #44:
URL: https://github.com/apache/apr/pull/44#discussion_r1243494966
##
memcache/apr_memcache.c:
##
@@ -346,18 +346,37 @@ APR_DECLARE(apr_status_t)
apr_memcache_disable_server(apr_memcache_t *mc, apr_me
return make_server_dead(mc, ms);
rpluem commented on code in PR #44:
URL: https://github.com/apache/apr/pull/44#discussion_r1243488779
##
memcache/apr_memcache.c:
##
@@ -346,18 +346,37 @@ APR_DECLARE(apr_status_t)
apr_memcache_disable_server(apr_memcache_t *mc, apr_me
return make_server_dead(mc, ms);
}
notroj commented on code in PR #44:
URL: https://github.com/apache/apr/pull/44#discussion_r1243279746
##
memcache/apr_memcache.c:
##
@@ -346,18 +346,37 @@ APR_DECLARE(apr_status_t)
apr_memcache_disable_server(apr_memcache_t *mc, apr_me
return make_server_dead(mc, ms);
}
uhliarik commented on PR #44:
URL: https://github.com/apache/apr/pull/44#issuecomment-1608549840
Altered the way how conn_connect() creates a socket connection. It should go
now through all addresses returned by apr_sockaddr_info_get().
--
This is an automated message from the Apache
uhliarik commented on PR #44:
URL: https://github.com/apache/apr/pull/44#issuecomment-1607292016
> Ah, hmm. I think this is still incorrect. The proper way is to loop over
the returned addresses until a connect() succeeds. e.g. this:
>
>
notroj commented on PR #44:
URL: https://github.com/apache/apr/pull/44#issuecomment-1606965126
Ah, hmm. I think this is still incorrect. The proper way is to loop over the
returned addresses until a connect() succeeds. e.g. this:
uhliarik commented on PR #44:
URL: https://github.com/apache/apr/pull/44#issuecomment-1605050843
Reproducer:
run:
$ ./memcachecon 127.0.0.1 11211
$ ./memcachecon ::1 11211
```#include
#include
#include
int main(int argc, char **argv)
{
uhliarik commented on PR #44:
URL: https://github.com/apache/apr/pull/44#issuecomment-1605047355
Follow up to https://svn.apache.org/repos/asf/apr/apr/trunk@1907242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
uhliarik opened a new pull request, #44:
URL: https://github.com/apache/apr/pull/44
When APR_UNSPEC is used, socket family is automaticaly set to APR_INET6 in
apr_socket_create() and therefore if apr_sockaddr_info_get() finds out that the
given address is in IPv4 format, it fails when
avkarenow opened a new pull request, #43:
URL: https://github.com/apache/apr/pull/43
From MySQL 8.0.2 changelog:
The my_init() function is no longer included in the list of symbols exported
from libmysqlclient. It need not be called explicitly by client programs
because it is called
jimying commented on PR #13:
URL: https://github.com/apache/apr/pull/13#issuecomment-1562415488
hi, I think it's better use cmake which can specify a build system
generator.
```bash
# To generate ninja build
cmake -G Ninja
```
Now cmake is already used in project, but it's
ylavic commented on PR #34:
URL: https://github.com/apache/apr/pull/34#issuecomment-1534446159
apr_global_mutex_child_init() is not supposed to be called with `*mutex ==
NULL` (it should have been allocated with apr_global_mutex_create() first), so
this is a usage/user error (i.e. don't do
crrodriguez commented on PR #34:
URL: https://github.com/apache/apr/pull/34#issuecomment-1532164651
> > > Is ignoring these the right answer? Or should we set ourselves in a
5-retry loop? With sleeps?
> >
> >
> > I was thinking about that, maybe a retry loop (hybrid-ish
crrodriguez commented on PR #34:
URL: https://github.com/apache/apr/pull/34#issuecomment-1532160099
> > Is ignoring these the right answer? Or should we set ourselves in a
5-retry loop? With sleeps?
>
> I was thinking about that, maybe a retry loop (hybrid-ish spinlock?)
296995966 opened a new pull request, #42:
URL: https://github.com/apache/apr/pull/42
If the lock is not unlocked, it will be deadlocked
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gmbeard commented on PR #40:
URL: https://github.com/apache/apr/pull/40#issuecomment-1517338685
I've
[discovered](https://github.com/void-linux/void-packages/pull/42972#discussion_r1171791976)
that the reason this test fails is because `dlclose` is a no-op on musl, so
maybe the test
tumatanquang opened a new pull request, #41:
URL: https://github.com/apache/apr/pull/41
As these topics:
[Apache 2.2 build with new VC++ 2008
RTM](https://www.apachelounge.com/viewtopic.php?t=2095)
[apr 1.7.0 build issues](https://www.apachelounge.com/viewtopic.php?t=8260)
From
gmbeard opened a new pull request, #40:
URL: https://github.com/apache/apr/pull/40
The voidlinux package for **apr** on musl fails the `test_unload_library`
test in `testdso.c` without this `NULL` check. The test unloads the dso and
then immediately tries to read a symbol from the unloaded
notroj commented on PR #39:
URL: https://github.com/apache/apr/pull/39#issuecomment-1416008746
Thanks @uhliarik !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
asfgit closed pull request #39: Don't force IPv4 use
URL: https://github.com/apache/apr/pull/39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
uhliarik commented on code in PR #39:
URL: https://github.com/apache/apr/pull/39#discussion_r1095715926
##
memcache/apr_memcache.c:
##
@@ -328,7 +328,7 @@ mc_conn_construct(void **conn_, void *params, apr_pool_t
*pool)
apr_pool_t *tp;
apr_memcache_server_t *ms =
notroj commented on code in PR #39:
URL: https://github.com/apache/apr/pull/39#discussion_r1094223656
##
memcache/apr_memcache.c:
##
@@ -328,7 +328,7 @@ mc_conn_construct(void **conn_, void *params, apr_pool_t
*pool)
apr_pool_t *tp;
apr_memcache_server_t *ms =
uhliarik opened a new pull request, #39:
URL: https://github.com/apache/apr/pull/39
Code in apr_memcache.c is forcing to use IPv6 by setting protocol family to
APR_INET instead of APR_UNSPEC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
asfgit closed pull request #38: propose fix for PR 66435
URL: https://github.com/apache/apr/pull/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
70 matches
Mail list logo
