Re: [PATCH] bucket debugging.

2003-08-14 Thread Cliff Woolley
On Wed, 13 Aug 2003, Jean-Jacques Clar wrote: Am I missing something in the patch I have? I don't find the implementation of the two APR_RING_CHECK macros. cvs up. :)

Re: [PATCH] bucket debugging.

2003-08-14 Thread Jean-Jacques Clar
thanks, now building... Cliff Woolley [EMAIL PROTECTED] 8/13/2003 5:42:17 PM On Wed, 13 Aug 2003, Jean-Jacques Clar wrote: Am I missing something in the patch I have? I don't find the implementation of the two APR_RING_CHECK macros.cvs up. :)

[PATCH] bucket debugging.

2003-08-13 Thread Cliff Woolley
Any objections to the following patch? All you do is pass -DAPR_BUCKET_DEBUG to ./configure and then several things happen: 1) the brigades get checked for consistency at various strategic points 2) and apr_bucket_free() calls are checked for double-free conditions (eg, you destroyed

Re: [PATCH] bucket debugging.

2003-08-13 Thread Greg Stein
On Tue, Aug 12, 2003 at 11:20:13PM -0400, Cliff Woolley wrote: Any objections to the following patch? All you do is pass -DAPR_BUCKET_DEBUG to ./configure and then several things happen: 1) the brigades get checked for consistency at various strategic points 2) and apr_bucket_free()

Re: [PATCH] bucket debugging.

2003-08-13 Thread Cliff Woolley
On Tue, 12 Aug 2003, Greg Stein wrote: +while (curr) { +if (node == curr) { +return 0; +} +curr = curr-next; +} +return 1; Forget the return code. Just stick an abort() in here. return 0 to pop the assert, abort, same difference.

Re: [PATCH] bucket debugging.

2003-08-13 Thread Greg Stein
On Wed, Aug 13, 2003 at 02:08:57AM -0400, Cliff Woolley wrote: On Tue, 12 Aug 2003, Greg Stein wrote: +while (curr) { +if (node == curr) { +return 0; +} +curr = curr-next; +} +return 1; Forget the return code. Just stick

Re: [PATCH] bucket debugging.

2003-08-13 Thread Jeff Trawick
Cliff Woolley wrote: Any objections to the following patch? All you do is pass -DAPR_BUCKET_DEBUG to ./configure and then several things happen: is --enable-bucket-debug preferable? a couple of positive aspects of that: a) natural place for help text (apr-util/configure --help) b) after

RE: [PATCH] bucket debugging.

2003-08-13 Thread Sander Striker
From: Jeff Trawick [mailto:[EMAIL PROTECTED] Sent: Wednesday, August 13, 2003 12:39 PM Cliff Woolley wrote: Any objections to the following patch? All you do is pass -DAPR_BUCKET_DEBUG to ./configure and then several things happen: is --enable-bucket-debug preferable? a couple of

RE: [PATCH] bucket debugging.

2003-08-13 Thread Cliff Woolley
On Wed, 13 Aug 2003, Sander Striker wrote: compiler command lines even longer more work though :) You can probably reuse what I did with --enable-pool-debug in APR. Aww crap, now I gotta figure out autoconf? :-) Sure, that sounds like a reasonable request. --Cliff