Re: [PATCH] apr_dir_read doesn't return requested information

2002-12-19 Thread Branko ibej
William A. Rowe, Jr. wrote: At 11:48 AM 12/18/2002, William A. Rowe, Jr. wrote: At 08:14 AM 12/18/2002, Philip Martin wrote: This is for dir.c version 1.71 with the patch reverted. The Subversion code is svn_io_get_dirents in subversion/libsvn_subr/io.c, it passes APR_FINFO_TYPE |

Re: [PATCH] apr_dir_read doesn't return requested information

2002-12-19 Thread William A. Rowe, Jr.
As much as I agree 0 might be a valid inode... I strongly suspect that 0 would be reserved for the boot sector or other filesystem tables. I'm not too worried that 0 is a valid file of anything other than '/' Bill At 07:19 PM 12/18/2002, =?UTF-8?B?QnJhbmtvIMSMaWJlag==?= wrote: William A. Rowe,

Re: [PATCH] apr_dir_read doesn't return requested information

2002-12-18 Thread Branko ibej
Philip Martin wrote: Philip Martin [EMAIL PROTECTED] writes: Eeek! I've just upgraded to apache/apr/apr-util to HEAD and now I can reproduce this. $ svnadmin create repo $ svn mkdir file://`pwd`/repo/foo $ svn co file://`pwd`/repo wc $ svn up wc

Re: [PATCH] apr_dir_read doesn't return requested information

2002-12-18 Thread William A. Rowe, Jr.
I'm sorry... this patch dir not come through to [EMAIL PROTECTED] for me today (although I watched for it...) but it's simply WRONG. At 07:04 PM 12/17/2002, =?UTF-8?B?QnJhbmtvIMSMaWJlag==?= wrote: --- apr/file_io/unix/dir.c 15 Dec 2002 05:17:51 - 1.69 +++ apr/file_io/unix/dir.c

Re: [PATCH] apr_dir_read doesn't return requested information

2002-12-18 Thread rbb
On Tue, 17 Dec 2002, William A. Rowe, Jr. wrote: I'm sorry... this patch dir not come through to [EMAIL PROTECTED] for me today (although I watched for it...) but it's simply WRONG. At 07:04 PM 12/17/2002, =?UTF-8?B?QnJhbmtvIMSMaWJlag==?= wrote: --- apr/file_io/unix/dir.c 15 Dec 2002

Re: [PATCH] apr_dir_read doesn't return requested information

2002-12-18 Thread Branko ibej
William A. Rowe, Jr. wrote: I'm sorry... this patch dir not come through to [EMAIL PROTECTED] for me today (although I watched for it...) but it's simply WRONG. At 07:04 PM 12/17/2002, =?UTF-8?B?QnJhbmtvIMSMaWJlag==?= wrote: --- apr/file_io/unix/dir.c 15 Dec 2002 05:17:51 -

Re: [PATCH] apr_dir_read doesn't return requested information

2002-12-18 Thread William A. Rowe, Jr.
At 10:42 PM 12/17/2002, =?UTF-8?B?QnJhbmtvIMSMaWJlag==?= wrote: Obviously, the type at least did not make it into the fle info. Looking at this code again, the patch may indeed be wrong; but I find it really, really hard to follow that code. In fact, I can't understand it at all. If you can

Re: [PATCH] apr_dir_read doesn't return requested information

2002-12-18 Thread Philip Martin
William A. Rowe, Jr. [EMAIL PROTECTED] writes: What I would like to know (if you can track it...) Is it possible to dump the finfo structure within gdb at the point this request fails? I'd pay especially close attention to the .valid bits, since those are the identifiers that will help us

Re: [PATCH] apr_dir_read doesn't return requested information

2002-12-18 Thread William A. Rowe, Jr.
At 08:14 AM 12/18/2002, Philip Martin wrote: William A. Rowe, Jr. [EMAIL PROTECTED] writes: What I would like to know (if you can track it...) Is it possible to dump the finfo structure within gdb at the point this request fails? I'd pay especially close attention to the .valid bits, since

Re: [PATCH] apr_dir_read doesn't return requested information

2002-12-18 Thread Philip Martin
William A. Rowe, Jr. [EMAIL PROTECTED] writes: Philip... thanks. Now for the oddball question, looking at dirent.h or it's associate sys/ includes, what symbol DT_xxx (DT_REG, etc) do you find for value 0? /usr/include/dirent.h /* File types for `d_type'. */ enum { DT_UNKNOWN = 0,

Re: [PATCH] apr_dir_read doesn't return requested information

2002-12-18 Thread William A. Rowe, Jr.
At 11:48 AM 12/18/2002, William A. Rowe, Jr. wrote: At 08:14 AM 12/18/2002, Philip Martin wrote: This is for dir.c version 1.71 with the patch reverted. The Subversion code is svn_io_get_dirents in subversion/libsvn_subr/io.c, it passes APR_FINFO_TYPE | APR_FINFO_NAME to apr_dir_read. The first

[PATCH] apr_dir_read doesn't return requested information

2002-12-17 Thread Philip Martin
Philip Martin [EMAIL PROTECTED] writes: Eeek! I've just upgraded to apache/apr/apr-util to HEAD and now I can reproduce this. $ svnadmin create repo $ svn mkdir file://`pwd`/repo/foo $ svn co file://`pwd`/repo wc $ svn up wc ../svn/subversion/libsvn_wc/adm_crawler.c:315:

[Patch] apr_dir_read

2001-01-23 Thread William A. Rowe, Jr.
Guys... a biggish patch, and the three specific apr_dir_read implementations are not complete or optimal. I am taking a bit of a break, so I thought I would toss this out while folks are still awake. To avoid big stat() requirements unless that's exactly what we aim to accomplish, I've