There seems to be a mismatch in how the #define APU_DSO_BUILD is being used.
APU_DSO_BUILD has been defined as a boolean yet much of the code is simply
checking for the definition rather than the boolean state. Therefore setting
APU_DSO_BUILD to 0 doesn't actually turn off the code
Brad Nicholes wrote:
There seems to be a mismatch in how the #define APU_DSO_BUILD is being used.
APU_DSO_BUILD has been defined as a boolean yet much of the code is simply
checking for the definition rather than the boolean state. Therefore setting
APU_DSO_BUILD to 0 doesn't actually
William A. Rowe, Jr. wrote:
Eric Covener wrote:
+1 on wrapping it all in 2.0, but I don't think the versioning
restrictions allow apr-util to stop linking against LDAP in 1.3 -- for
example applications that load ldap symbols privately (not at all
shouldn't be an issue because they can't do
On Thu, 2008-05-22 at 17:52 -0500, William A. Rowe, Jr. wrote:
Please, review. Thanks.
Gettin' these:
misc/apu_dso.c: In function 'apu_dso_init':
misc/apu_dso.c:84: warning: suggest parentheses around assignment used
as truth value
Bojan Smojver wrote:
Gettin' these:
misc/apu_dso.c: In function 'apu_dso_init':
misc/apu_dso.c:84: warning: suggest parentheses around assignment used
as truth value
misc/apu_dso.c:84: warning: statement with no effect
misc/apu_dso.c: In function
On Thu, 2008-05-22 at 22:06 -0500, William A. Rowe, Jr. wrote:
Can you recheck from the branch? should have been fixed in r659343
Check. All is well :-)
--
Bojan
