On Wed, May 21, 2008 at 07:50:02AM +1000, Bojan Smojver wrote:
I'm getting this (APR 1.2.x):
-
strings/apr_snprintf.c: In function 'apr_vformatter':
strings/apr_snprintf.c:1253: warning: comparison with string literal
results in unspecified behavior
and S_NULL defined as null.
We really want to do this here, right? Just checking...
Interesting - is that gcc 4.3? The code is bogus because it assumes all
the expansions of the macro result in a string with the same address;
does this patch fix the warning?
Index: strings/apr_snprintf.c
On Fri, 2008-05-23 at 13:12 +0100, Joe Orton wrote:
Interesting - is that gcc 4.3?
Yep, Fedora 9.
The code is bogus because it assumes all
the expansions of the macro result in a string with the same address;
does this patch fix the warning?
Yes, it does.
--
Bojan
On Wed, 2008-05-21 at 07:50 +1000, Bojan Smojver wrote:
I'm getting this (APR 1.2.x):
-
strings/apr_snprintf.c: In function 'apr_vformatter':
strings/apr_snprintf.c:1253: warning: comparison with string literal
results in unspecified behavior
I'm getting this (APR 1.2.x):
-
strings/apr_snprintf.c: In function 'apr_vformatter':
strings/apr_snprintf.c:1253: warning: comparison with string literal
results in unspecified behavior
-
The line