Re: sqlite3 and postgresql

2008-05-21 Thread Bob Rossi
the query. This should now be fixed in both the trunk and 1.3.x branch. We really _do_ appreciate your testing and suggestions! I can confirm that the latest 1.3.x snapshot on linux, for both sqlite3 and postgresql use a 1 based row index. I removed my hack, and things work great. I'm

Re: sqlite3 and postgresql

2008-05-21 Thread Bob Rossi
that apr_dbd_get_row is 0 based. That is, 0 is the first row returned from the query. This should now be fixed in both the trunk and 1.3.x branch. We really _do_ appreciate your testing and suggestions! I can confirm that the latest 1.3.x snapshot on linux, for both sqlite3

Re: sqlite3 and postgresql

2008-05-21 Thread Bojan Smojver
On Wed, 2008-05-21 at 10:13 -0400, Bob Rossi wrote: OK, I have confirmed 1 bug. If you pass '0' to apr_dbd_get_row, with postgresql as the driver, the function returns 0, instead of -1 as it should. My unit tests happen to test the cases that should fail, that's how I caught this. Try now. I

Re: sqlite3 and postgresql

2008-05-21 Thread Bob Rossi
On Thu, May 22, 2008 at 05:43:27AM +1000, Bojan Smojver wrote: On Wed, 2008-05-21 at 10:13 -0400, Bob Rossi wrote: OK, I have confirmed 1 bug. If you pass '0' to apr_dbd_get_row, with postgresql as the driver, the function returns 0, instead of -1 as it should. My unit tests happen to

Re: sqlite3 and postgresql

2008-05-21 Thread Bojan Smojver
On Wed, 2008-05-21 at 16:29 -0400, Bob Rossi wrote: Ok, all my unit tests pass on linux and windows. Thanks a million! You are welcome. Thank you for testing! -- Bojan

Re: sqlite3 and postgresql

2008-05-19 Thread Bob Rossi
On Mon, May 19, 2008 at 08:58:32AM +1000, Bojan Smojver wrote: On Sat, 2008-05-17 at 09:07 -0400, Bob Rossi wrote: I've been using sqlite3 dbd for some time now. I find that the function apr_dbd_get_row,

Re: sqlite3 and postgresql

2008-05-19 Thread Bob Rossi
. We really _do_ appreciate your testing and suggestions! I can confirm that the latest 1.3.x snapshot on linux, for both sqlite3 and postgresql use a 1 based row index. I removed my hack, and things work great. I'm going to test windows now, could take some time. (perhaps get results tomorrow

Re: sqlite3 and postgresql

2008-05-18 Thread Bojan Smojver
On Sat, 2008-05-17 at 20:43 -0400, Tom Donovan wrote: I would be happy to take care of it as soon as I receive commit access. I'm a new committer, and the instructions advised patience - so I expect this usually takes some time to get processed. I committed something that _may_ work in

Re: sqlite3 and postgresql

2008-05-18 Thread Bojan Smojver
On Sat, 2008-05-17 at 09:07 -0400, Bob Rossi wrote: I've been using sqlite3 dbd for some time now. I find that the function apr_dbd_get_row, http://apr.apache.org/docs/apr-util/trunk/group___a_p_r___util___d_b_d.html#gd4cdc5f4e8981b93f5a467a8c8a768f1 is 1 based. That is, 1 is the first

sqlite3 and postgresql

2008-05-17 Thread Bob Rossi
Hi, I've been using sqlite3 dbd for some time now. I find that the function apr_dbd_get_row, http://apr.apache.org/docs/apr-util/trunk/group___a_p_r___util___d_b_d.html#gd4cdc5f4e8981b93f5a467a8c8a768f1 is 1 based. That is, 1 is the first row returned from a query. However, I just started

Re: sqlite3 and postgresql

2008-05-17 Thread Tom Donovan
Bob Rossi wrote: Hi, I've been using sqlite3 dbd for some time now. I find that the function apr_dbd_get_row, http://apr.apache.org/docs/apr-util/trunk/group___a_p_r___util___d_b_d.html#gd4cdc5f4e8981b93f5a467a8c8a768f1 is 1 based. That is, 1 is the first row returned from a query. However,

Re: sqlite3 and postgresql

2008-05-17 Thread Bojan Smojver
On Sat, 2008-05-17 at 10:03 -0400, Tom Donovan wrote: I think this is a valid bug. I agree. -- Bojan

Re: sqlite3 and postgresql

2008-05-17 Thread William A. Rowe, Jr.
Bojan Smojver wrote: On Sat, 2008-05-17 at 10:03 -0400, Tom Donovan wrote: I think this is a valid bug. I agree. +1 and I concur with Tom's suggestion w.r.t. a preferred row offset 1.

Re: sqlite3 and postgresql

2008-05-17 Thread Bojan Smojver
On Sat, 2008-05-17 at 18:29 -0500, William A. Rowe, Jr. wrote: +1 and I concur with Tom's suggestion w.r.t. a preferred row offset 1. Tom, do you want to fix this one or do you want me to do it? -- Bojan

Re: sqlite3 and postgresql

2008-05-17 Thread Tom Donovan
Bojan Smojver wrote: On Sat, 2008-05-17 at 18:29 -0500, William A. Rowe, Jr. wrote: +1 and I concur with Tom's suggestion w.r.t. a preferred row offset 1. Tom, do you want to fix this one or do you want me to do it? I would be happy to take care of it as soon as I receive commit access.

Re: sqlite3 and postgresql

2008-05-17 Thread Bob Rossi
On Sun, May 18, 2008 at 10:17:34AM +1000, Bojan Smojver wrote: On Sat, 2008-05-17 at 18:29 -0500, William A. Rowe, Jr. wrote: +1 and I concur with Tom's suggestion w.r.t. a preferred row offset 1. Tom, do you want to fix this one or do you want me to do it? Aren't you worried about how

Re: sqlite3 and postgresql

2008-05-17 Thread Tom Donovan
Bob Rossi wrote: On Sun, May 18, 2008 at 10:17:34AM +1000, Bojan Smojver wrote: On Sat, 2008-05-17 at 18:29 -0500, William A. Rowe, Jr. wrote: +1 and I concur with Tom's suggestion w.r.t. a preferred row offset 1. Tom, do you want to fix this one or do you want me to do it? Aren't you

Re: sqlite3 and postgresql

2008-05-17 Thread Bojan Smojver
Quoting Bob Rossi [EMAIL PROTECTED]: Aren't you worried about how that will break all the existing programs out there using this interface? This is one of those damned if we fix it, damned if we don't things :-) That being said, this is clearly a bug, as APU's DBD is supposed to be