Re: [PATCH]: Introduce apr_dbd_transaction_rollback

2006-04-30 Thread Chris Darroch
Bojan: Nice. Do you want me to do a prototype patch or do you have something already? Thanks! Alas, I have nada in the way of an implementation; I'm still trying to finish up my scoreboard/slow child_init/etc. fixes for httpd. I've also been away from the keyboard much of the previous

Re: [PATCH]: Introduce apr_dbd_transaction_rollback

2006-04-30 Thread Ronen Mizrahi
Jut a small comment, if you do go ahead with the flag and not add a rollback funciton (which I think is much cleaner) then please be aware that the caller will need to know if the result was successful commit, successful rollback, or some other failure. Chris Darroch wrote: Bojan:

Re: Patch for checking expat on Solaris

2006-04-30 Thread Henry Jen
William A. Rowe, Jr. wrote: Henry Jen wrote: -L and -R should be redundant, no? No, they are not. -L is for link time, -R for runtime. For the default linker on Solaris, the -R is taking the value from -L as gnu ld. I meant to say Solaris default linker does not behave the

Re: Makefile.in does not take external LIBS LDFLAGS

2006-04-30 Thread Henry Jen
Ryan Bloom wrote: Didn't we solve this problem by adding EXTRA_LIBS and EXTRA_LDFLAGS? I haven't looked at the code, but I remember (from years past), that we didn't want people to set CFLAGS, LIBS, LDFLAGS, etc for some reason. Instead, we asked people to set EXTRA_CFLAGS, etc and we picked

Bug report for APR [2006/04/30]

2006-04-30 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Re: [PATCH]: Introduce apr_dbd_transaction_rollback

2006-04-30 Thread Bojan Smojver
Quoting Chris Darroch [EMAIL PROTECTED]: So, like this: switch (trans-mode) { case APR_DBD_TRANSACTION_COMMIT: res = PQexec(trans-handle-conn, COMMIT); break; case APR_DBD_TRANSACTION_COMMIT_ON_SUCCESS: if (trans-errnum) {

Re: [PATCH]: Introduce apr_dbd_transaction_rollback

2006-04-30 Thread Bojan Smojver
Quoting Ronen Mizrahi [EMAIL PROTECTED]: Jut a small comment, if you do go ahead with the flag and not add a rollback funciton (which I think is much cleaner) then please be aware that the caller will need to know if the result was successful commit, successful rollback, or some other failure.

Re: [PATCH]: Introduce apr_dbd_transaction_rollback

2006-04-30 Thread Nick Kew
On Sunday 30 April 2006 23:05, Chris Darroch wrote: OK, I started working on this (skeleton of of the patch is ready), but before I go any further, could you give me a hint on the semantics of the above. What I'm not getting is APR_DBD_TRANS_COMMIT v. APR_DBD_TRANS_COMMIT_ON_SUCCESS.

[PATCH]: Introduce APR DBD transaction mode

2006-04-30 Thread Bojan Smojver
Here is the patch along the lines of setting the modes of the transaction. It doesn't have force commit, but if the list decides that it's the right thing to do, I'll rework. I didn't test this - it's just a prototype. A patch for folks using MySQL is included as well. -- Bojan Index:

Re: [PATCH]: Introduce APR DBD transaction mode

2006-04-30 Thread Bojan Smojver
Quoting Bojan Smojver [EMAIL PROTECTED]: A patch for folks using MySQL is included as well. Sorry about the traling comma after dbd_mysql_transaction_mode_set - lazy cut/paste :-( -- Bojan

Re: Patch for checking expat on Solaris

2006-04-30 Thread William A. Rowe, Jr.
Henry Jen wrote: I mean, based on my limited platform experience, gcc supports -R and Windows is not using autotools, right? And if you built with the -L path, isn't it should be the same for -R? What on earth do windows, or gcc, have to do with anything? We are talking about Solaris, and

Re: Patch for checking expat on Solaris

2006-04-30 Thread William A. Rowe, Jr.
Henry Jen wrote: William A. Rowe, Jr. wrote: The issue I have is that your -enforcing- -R destroys my -portability-. We need to find a happy comprimize to build to a manditory -prefix versus the usual -prefix, yet relocatable (with LD_LIBRARY_PATH). Hmm, I am curious what portability is