Re: Thread handle leak in APR

2010-08-20 Thread Erik Huelsmann
On Fri, Aug 20, 2010 at 8:30 PM, William A. Rowe Jr. wr...@rowe-clan.net wrote: On 8/20/2010 1:08 PM, Guenter Knauf wrote: Hi Prathima, Am 20.08.2010 09:04, schrieb Prathima Dandapani -X (pdandapa - HCL at Cisco): Steps used to compile Apache is as follows. Run Setenv.cmd  from the

Re: poll/select process's IO on windows

2009-06-17 Thread Erik Huelsmann
Hi Jack, Regardless of the portability library that you're using, Windows doesn't allow select() operations on any other than socket handles. I don't have personal experience how to work around that issue with APR though, I'm sorry. With kind regards, Erik. On Tue, Jun 16, 2009 at 8:42 PM,

Re: apr pools memory leaks

2008-10-01 Thread Erik Huelsmann
On Wed, Oct 1, 2008 at 8:31 PM, Mark Phippard [EMAIL PROTECTED] wrote: On Wed, Oct 1, 2008 at 2:11 PM, Ben Collins-Sussman [EMAIL PROTECTED] wrote: I have interesting memory leak data to share with these two lists (crossposting to both svn and apr dev lists). Ever since we launched

Re: Opaque structures in general (was Re: Opaque apr_pool_t structure)

2008-06-06 Thread Erik Huelsmann
On 6/6/08, Ryan Bloom [EMAIL PROTECTED] wrote: I don't think that there is any reason to not have a sizeof() function, other than any code that does play with the pointers will be non-portable code. The reason that I originally went with opaque data structures (I did it before giving the code

Request for inclusion in 1.2.13/.14 or 1.3.0: Win32 file copy efficiency

2008-04-23 Thread Erik Huelsmann
Bug #44193 includes a (one line!) patch and describes a situation where network apr_file_copy() results in very bad performance for network mounted filesystems. The issue is that APR uses a 512 bytes large buffer (BUFSIZ) to read and write data in the copy operation. Performance would benefit

Re: [patch] creating directories with long names

2008-03-22 Thread Erik Huelsmann
On Tue, Feb 5, 2008 at 8:57 PM, William A. Rowe, Jr. [EMAIL PROTECTED] wrote: Stefan Küng wrote: Anyone looked at this yet? http://mail-archives.apache.org/mod_mbox/apr-dev/200801.mbox/[EMAIL PROTECTED] The patch/argument made perfect sense, although I'm leaning towards a switch to

misc/win32/rand.c needs to include apr.h *before* windows.h

2007-11-02 Thread Erik Huelsmann
I thought I'd forward the APR bugreport in the PS in the message below to the APR list (as the Subversion list won't be able to address the issue). Bye, Erik. -- Forwarded message -- From: Stefan Küng [EMAIL PROTECTED] Date: Nov 2, 2007 4:53 PM Subject: [PATCH] fix build with

Re: [1.2.x Win32] apr.dsp references non-existing buffer.c?

2007-10-08 Thread Erik Huelsmann
On 10/8/07, William A. Rowe, Jr. [EMAIL PROTECTED] wrote: Erik Huelsmann wrote: While (for the first time in a looong time) trying to build APR, I built the 1.2.x branch on Win32 tonight. I'm however getting an error from the DSP file: it expects a file file_io/win32/buffer.c to exist

Re: [1.2.x Win32] apr.dsp references non-existing buffer.c?

2007-10-08 Thread Erik Huelsmann
On 10/8/07, William A. Rowe, Jr. [EMAIL PROTECTED] wrote: Erik Huelsmann wrote: 1Build log was saved at file://c:\Users\Erik\Documents\apr-1.2.x\LibD\BuildLog.htm Hope you can help! svn status apr.dsp svn info apr.dsp Turned out there were some unversioned files left behind after all

Re: [vote] apr 1.2.x win32 compatibility

2007-10-05 Thread Erik Huelsmann
On 10/5/07, William A. Rowe, Jr. [EMAIL PROTECTED] wrote: Paul Querna wrote: Revert. New Macros are new APIs, and must wait for 1.3.x. Ok, as people are totally missing the point, that I was calling a vote for a modest versioning rules change that was in the spirit of both the versioning

Re: EISDIR / EPERM not categorised in APR_STATUS_IS_* macros

2007-09-25 Thread Erik Huelsmann
On 9/13/07, Joe Orton [EMAIL PROTECTED] wrote: On Tue, Sep 11, 2007 at 11:25:20PM +0200, Erik Huelsmann wrote: While working on changing some of the working copy library in Subversion, I'm trying to eliminate stat() calls (apr_stat()) in order to speed up overall operation. Very often

EISDIR / EPERM not categorised in APR_STATUS_IS_* macros

2007-09-11 Thread Erik Huelsmann
While working on changing some of the working copy library in Subversion, I'm trying to eliminate stat() calls (apr_stat()) in order to speed up overall operation. Very often, Subversion libsvn_wc uses this pattern: svn_io_check_path() - retrieves a path kind using apr_stat() if (kind ==

Re: question about APR_IS_DEV_VERSION

2007-08-08 Thread Erik Huelsmann
On 8/8/07, Guenter Knauf [EMAIL PROTECTED] wrote: Hi all, regardless at which APR version I look at - everywhere I find: /** * This symbol is defined for internal, development copies of APR. This * symbol will be #undef'd for releases. */ #undef APR_IS_DEV_VERSION so it seems to me

Re: apr_filepath_encoding on Darwin

2007-08-05 Thread Erik Huelsmann
- if Darwin has a configurable locale, does *not* set this up by default such that nl_langinfo(CODESET) returns UTF-8, but does by policy require filenames in UTF-8, regardless of locale, I would agree with changing apr_filepath_encoding as Erik proposed. That is the case? I

Re: SVN CLI and Windows security

2007-07-29 Thread Erik Huelsmann
On 7/25/07, Brad Stiles [EMAIL PROTECTED] wrote: I ran into a situation today concerning the command line client and windows security. The problem is that the user (a build user performing automated builds on a Windows 2003 VM) attempted to check out a file to a network share and couldn't,

Re: SVN CLI and Windows security

2007-07-29 Thread Erik Huelsmann
On 7/29/07, William A. Rowe, Jr. [EMAIL PROTECTED] wrote: Erik Huelsmann wrote: On 7/25/07, Brad Stiles [EMAIL PROTECTED] wrote: I ran into a situation today concerning the command line client and windows security. The problem is that the user (a build user performing automated builds

apr_filepath_encoding on Darwin

2007-07-17 Thread Erik Huelsmann
Reading [1], I conclude that applications should pass UTF-8 to BSD functions such as stat() at all times. This suggests to me that apr_filepath_encoding() should return APR_FILEPATH_ENCODING_UTF8. Yet, looking at the sources, on any Unixy system, it returns APR_FILEPATH_ENCODING_LOCALE. Is this

Re: apr_filepath_encoding on Darwin

2007-07-17 Thread Erik Huelsmann
On 7/17/07, Joe Orton [EMAIL PROTECTED] wrote: On Tue, Jul 17, 2007 at 02:14:25PM +0200, Erik Huelsmann wrote: Reading [1], I conclude that applications should pass UTF-8 to BSD functions such as stat() at all times. This suggests to me that apr_filepath_encoding() should return

Re: apr_filepath_encoding on Darwin

2007-07-17 Thread Erik Huelsmann
On 7/17/07, Joe Orton [EMAIL PROTECTED] wrote: On Tue, Jul 17, 2007 at 02:31:27PM +0200, Erik Huelsmann wrote: On 7/17/07, Joe Orton [EMAIL PROTECTED] wrote: This is deliberate; on Unix the character set used for filenames is dictated by the locale settings (e.g. LC_CTYPE), by convention

Re: apr_filepath_encoding on Darwin

2007-07-17 Thread Erik Huelsmann
On 7/17/07, Lucian Adrian Grijincu [EMAIL PROTECTED] wrote: On 7/17/07, Erik Huelsmann [EMAIL PROTECTED] wrote: On 7/17/07, Lucian Adrian Grijincu [EMAIL PROTECTED] wrote: APR holds everything in locale encoding on UNIX and UTF8 on Windows. As far as I know UNIX system calls must accept

Re: apr_filepath_encoding on Darwin

2007-07-17 Thread Erik Huelsmann
On 7/17/07, Lucian Adrian Grijincu [EMAIL PROTECTED] wrote: On 7/17/07, Erik Huelsmann [EMAIL PROTECTED] wrote: No, I can't confirm: I'm trying to find out why Subversion is the only app complaining there's no locale set when interacting with the filesystem while the rest of the world seems

Re: apr_filepath_encoding on Darwin

2007-07-17 Thread Erik Huelsmann
On 7/17/07, Wilfredo Sánchez Vega [EMAIL PROTECTED] wrote: On Jul 17, 2007, at 5:25 AM, Joe Orton wrote: On Tue, Jul 17, 2007 at 02:14:25PM +0200, Erik Huelsmann wrote: Reading [1], I conclude that applications should pass UTF-8 to BSD functions such as stat() at all times. This suggests

Re: apr-util/misc/apr_thread_pool.c compile failure in VC6

2007-05-01 Thread Erik Huelsmann
On 5/1/07, Curt Arnold [EMAIL PROTECTED] wrote: apr_thread_pool.c did not appear in the VC6 project in 1.2.8, but has been added in the SVN HEAD and it fails to compile under VC6 in debug mode due to a C++ style variable declaration. The following change fixes the compile error. Shouldn't the

Re: Fix writing large chunks to consoles/pipes

2007-03-24 Thread Erik Huelsmann
On 3/22/07, Jonathan Gilbert [EMAIL PROTECTED] wrote: At 10:51 AM 3/21/2007 +0100, you wrote: There's a thread about fixing some issue in Subversion w.r.t. writing large amounts of data to a console handle. This issue is an example of a broader issue: Windows doesn't support arbitrary amounts

Fix writing large chunks to consoles/pipes

2007-03-21 Thread Erik Huelsmann
There's a thread about fixing some issue in Subversion w.r.t. writing large amounts of data to a console handle. This issue is an example of a broader issue: Windows doesn't support arbitrary amounts of data to be written to all of its handle types. Smaller writes *are* supported, but it doesn't

Re: [PATCH] Fix for Subversion issue #1789

2007-03-15 Thread Erik Huelsmann
My gut says the extensive additional code to flip to buffered mode merits it's very own function (internal to apr would be fine, for now, but the fact that we need to trigger it hints that others might want to too, in some future 1.3.0 release.) We can't return 0 bytes written, too many apps

Re: [PATCH] Fix for Subversion issue #1789

2007-03-14 Thread Erik Huelsmann
On 2/23/07, William A. Rowe, Jr. [EMAIL PROTECTED] wrote: Jonathan Gilbert wrote: The updated version of the patch only enforces chunked writes specifically for console output, and it does it using the existing buffering functionality, so no new code is required, unlike the original patch.

Re: [PATCH] Fix for Subversion issue #1789

2007-03-14 Thread Erik Huelsmann
On 3/14/07, Jonathan Gilbert [EMAIL PROTECTED] wrote: At 02:22 PM 3/14/2007 +0100, Eric Huelsmann wrote: Jonathan, Any progress on the matter? I'd love to be able to close the issue in Subversion by pointing to the right APR version! My feeling at the moment is that the patch is ready to be

Re: [PATCH] Fix for Subversion issue #1789

2007-03-14 Thread Erik Huelsmann
(but note: I don't have a Windows dev environment!). Not having an environment to test shows: as it turns out, WriteFile returns a BOOL, not a DWORD, meaning that the patch below is much more applicable. I hope it's good enough now. (BTW, the patch requires the '-p2' parameter for patch(1) to

Fwd: Win32 build files and eol-style

2005-11-14 Thread Erik Huelsmann
Sorry, ended up sending my reply to Mladen personally instead of the lists. bye, Erik. -- Forwarded message -- From: Erik Huelsmann [EMAIL PROTECTED] Date: Nov 14, 2005 1:10 PM Subject: Re: Win32 build files and eol-style To: Mladen Turk [EMAIL PROTECTED] On 11/14/05, Mladen

Re: [PATCH] Fix loop termination in apr_file_write

2005-08-21 Thread Erik Huelsmann
On 8/20/05, Joe Orton [EMAIL PROTECTED] wrote: I promissed Karl Fogel a reproduction recipe, but didn't succeed in creating one. OTOH, I think it's clear the line needs changing... I've committed this with a test case (trying to write to a file which was opened read-only), thanks Erik.

[PATCH] Fix loop termination in apr_file_write

2005-08-19 Thread Erik Huelsmann
Sometimes Subversion ends in an unterminated loop when checking out to a full device. Looking at the Windows and OS/2 code, the unix code seems to be missing a line which changes the loop termination variable rv. I promissed Karl Fogel a reproduction recipe, but didn't succeed in creating one.

Re: confusion about largefile support

2005-05-31 Thread Erik Huelsmann
On 5/31/05, Ben Collins-Sussman [EMAIL PROTECTED] wrote: On May 31, 2005, at 11:49 AM, Ben Collins-Sussman wrote: Funny, KDE is using fsfs, and I would have expected them to run into a 2GB revision file. Well, whattya know. Now Timothee Besset (ttimo) in IRC has just reported the

Re: Move apr_xlate from apr-util to apr-iconv?

2005-05-30 Thread Erik Huelsmann
On 5/30/05, Mladen Turk [EMAIL PROTECTED] wrote: Jeff Trawick wrote: Can we move the entire apr_xlate API from apr-utils to the apr-iconv? no; apr_xlate works just fine without apr-iconv (when system provides a suitable iconv) It does not. Did you read what he said?

Win32: Ruby APR; build problems for Ruby Subversion SWIG bindings

2005-04-20 Thread Erik Huelsmann
Having taken upon me the task to provide a Windows build for Subversion, I run into a problem with the Ruby SWIG bindings. The problem is with APR and Ruby Win32 header files though. For those who don't know any of the terms used: Subversion: the next generation of centralised version control