Re: Include CASSANDRA-18464 in 5.0-beta1 (direct I/O support for commitlog write)

2023-11-28 Thread Jacek Lewandowski
Should I assume it's an agreement? - - -- --- - - Jacek Lewandowski wt., 28 lis 2023 o 12:05 Mick Semb Wever napisał(a): > > > So, assuming beta2, can it be merged to cassandra-5.0 now? >> > > > Yes from me. > And I would interpret Brandon and Maxwell's statements as

Re: Include CASSANDRA-18464 in 5.0-beta1 (direct I/O support for commitlog write)

2023-11-28 Thread Mick Semb Wever
So, assuming beta2, can it be merged to cassandra-5.0 now? > Yes from me. And I would interpret Brandon and Maxwell's statements as supporting too.

Re: Include CASSANDRA-18464 in 5.0-beta1 (direct I/O support for commitlog write)

2023-11-28 Thread Jacek Lewandowski
So, assuming beta2, can it be merged to cassandra-5.0 now? - - -- --- - - Jacek Lewandowski pon., 27 lis 2023 o 16:02 Mick Semb Wever napisał(a): > > I don't want to veto the 5.0-beta1 release for this. > > I would rather cut and include it in the next: 5.0-beta2;

Re: Include CASSANDRA-18464 in 5.0-beta1 (direct I/O support for commitlog write)

2023-11-27 Thread Mick Semb Wever
I don't want to veto the 5.0-beta1 release for this. I would rather cut and include it in the next: 5.0-beta2; release. Given it's an add-on and does not change default behaviour, I believe this would be ok – if we agree. I feel this would be a better use of our time. And would mean, yes commit

Re: Include CASSANDRA-18464 in 5.0-beta1 (direct I/O support for commitlog write)

2023-11-27 Thread guo Maxwell
+1  Brandon Williams 于2023年11月27日周一 22:25写道: > As long as it's disabled by default that's an easy +1 from me. > > Kind Regards, > Brandon > > On Mon, Nov 27, 2023 at 7:03 AM Jacek Lewandowski > wrote: > > > > Hey, > > > > I'd like to ask if we can include >

Re: Include CASSANDRA-18464 in 5.0-beta1 (direct I/O support for commitlog write)

2023-11-27 Thread Brandon Williams
As long as it's disabled by default that's an easy +1 from me. Kind Regards, Brandon On Mon, Nov 27, 2023 at 7:03 AM Jacek Lewandowski wrote: > > Hey, > > I'd like to ask if we can include > https://issues.apache.org/jira/browse/CASSANDRA-18464 in the 5.0-beta1 > release. This introduces the