Re: upgrade guava on trunk before 9/1?

2018-09-01 Thread Sumanth Pasupuleti
Thanks to Andy for suggestions on working around the issues, I now have build and UTs passing with Guava 26, and driver 3.6.0. Not sure if we can accommodate this in 4.0 since this is yet to be reviewed and includes quite a few changes. Updated https://issues.apache.org/jira/browse/CASSANDRA-14655

Re: upgrade guava on trunk before 9/1?

2018-08-17 Thread Sumanth Pasupuleti
Thanks for the confirmation Andy. Created a JIRA to track the guava upgrade https://issues.apache.org/jira/browse/CASSANDRA-14655. I current put target version as 4.x. If a compatible version of the driver happens to be released soon enough, and if there is a consensus that we should merge this

Re: upgrade guava on trunk before 9/1?

2018-08-16 Thread Andy Tolbert
Hi Sumanth, I gave a shot at upgrading to Guava 26.0; resolved build issues; about 63 > Unit Tests fail - a lot of them due to a NPE and another bunch due to > the driver using a method that does not exist in latest Guava. > Unfortunately the driver doesn't currently work with Guava 26.0. We

Re: upgrade guava on trunk before 9/1?

2018-08-16 Thread Sumanth Pasupuleti
I am +1 on upgrading to latest Guava, given that we would be on 4.0 for a while, and we would have a relatively big testing phase that follows the freeze date, which would hopefully iron out (as much as possible) any issues we may have with the upgrade. I gave a shot at upgrading to Guava 26.0;

Re: upgrade guava on trunk before 9/1?

2018-08-16 Thread Jonathan Haddad
Pushing it back means it’s a bigger risk later on. I’m +.5 on upgrading now On Wed, Aug 15, 2018 at 11:46 PM dinesh.jo...@yahoo.com.INVALID wrote: > Jason, > Given that we're so close to the 9/1 date, I would err on the side of > caution especially given the low value prop. If someone does run

Re: upgrade guava on trunk before 9/1?

2018-08-16 Thread dinesh.jo...@yahoo.com.INVALID
Jason, Given that we're so close to the 9/1 date, I would err on the side of caution especially given the low value prop. If someone does run into Guava compatibility issues (and someone somewhere will), we can revisit this question then. Dinesh On Wednesday, August 15, 2018, 11:42:31 PM

Re: upgrade guava on trunk before 9/1?

2018-08-15 Thread Salih Gedik
Hi, Change logs are on Github releases page. It seems like only hash flooding protection which is added to ImmutableMap is relevant to Cassandra code. I haven’t checked whether we use deprecated APIs. But there isn’t much on table from what I see. Salih On 15 Aug 2018 17:55 +0300, Ariel

Re: upgrade guava on trunk before 9/1?

2018-08-15 Thread Ariel Weisberg
Hi, They don't even do release notes after 23. Also no API diffs. I mean I'm fine with it, but it's mostly just changing to another arbitrary version that won't match what is in apps. Ariel On Wed, Aug 15, 2018, at 10:48 AM, Jason Brown wrote: > Hey Ariel, > > Tbqh, not that much. I was

Re: upgrade guava on trunk before 9/1?

2018-08-15 Thread Jason Brown
Hey Ariel, Tbqh, not that much. I was mostly thinking from the "I have conflicts on guava versions in my app because I pull in cassandra and XYZ libraries, and the transitive dependencies on guava use different versions" POV. Further, we'll be on this version of guava for 4.0 for at least two

Re: upgrade guava on trunk before 9/1?

2018-08-15 Thread Ariel Weisberg
Hi, What do we get from Guava in exchange for upgrading? Ariel On Wed, Aug 15, 2018, at 10:19 AM, Jason Brown wrote: > Hey all, > > Does anyone feel strongly about upgrading guava on trunk before the 9/1 > feature freeze for 4.0? We are currently at 23.3 (thanks to > CASSANDRA-13997), and the

upgrade guava on trunk before 9/1?

2018-08-15 Thread Jason Brown
Hey all, Does anyone feel strongly about upgrading guava on trunk before the 9/1 feature freeze for 4.0? We are currently at 23.3 (thanks to CASSANDRA-13997), and the current is 26.0. I took a quick look, and there's about 17 compilation errors. They fall into two categories, both of which