Paging in bytes (CASSANDRA-11745)

2021-10-22 Thread Jacek Lewandowski
Hi I wanted to start working on extending the paging mechanism to support memory based limits. My question is whether such a change requires a CEP or discussion in Jira is enough? Thanks, - - -- --- - - Jacek Lewandowski

Permission to create a CEP for pluggable SSTable formats

2021-10-22 Thread Jacek Lewandowski
I'd like to add a CEP for pluggable SSTable format but I don't have permission to create one - could anybody help me with that? Jacek - To unsubscribe, e-mail: dev-unsubscr...@cassandra.apache.org For additional commands,

[DISCUSS] CEP-17: SSTable format API (CASSANDRA-17056)

2021-10-22 Thread Jacek Lewandowski
I'd like to start a discussion about SSTable format API proposal (CEP-17) Jira: https://issues.apache.org/jira/browse/CASSANDRA-17056 CEP: https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-17%3A+SSTable+format+API Thanks, Jacek

Re: [DISCUSS] Nested YAML configs for new features

2021-11-19 Thread Jacek Lewandowski
With the flat structure it turns into properties file - would it be possible to support both formats - nested yaml and flat properties? - - -- --- - - Jacek Lewandowski On Fri, Nov 19, 2021 at 10:08 PM Caleb Rackliffe wrote: > If it's nested, "track_warning

Re: [DISCUSS] CEP-17: SSTable format API (CASSANDRA-17056)

2021-11-10 Thread Jacek Lewandowski
to maintain the old format (no "if then else" approach) - - -- --- - ----- Jacek Lewandowski On Wed, Nov 10, 2021 at 12:53 AM bened...@apache.org wrote: > > I may be wrong here, but the CEP directly calls out making this api > public for people who wish to replace

Re: Introducing Butler for increased CI visibility

2021-11-10 Thread Jacek Lewandowski
Awesome ! - - -- --- - - Jacek Lewandowski On Wed, Nov 10, 2021 at 6:02 PM Brandon Williams wrote: > TL;DR: https://butler.cassandra.apache.org > > Butler is a (soon to be OSS) companion system that tracks and > integrates Jenkins and Jira, created

Re: [DISCUSS] Nested YAML configs for new features

2021-11-24 Thread Jacek Lewandowski
I am just wondering how to represent in properties things like lists of non-scalar values? - - -- --- - - Jacek Lewandowski On Mon, Nov 22, 2021 at 5:16 PM Joseph Lynch wrote: > Isn't one of the primary reasons to have a YAML configuration instead > of a prop

Re: [DISCUSS] Nested YAML configs for new features

2021-11-24 Thread Jacek Lewandowski
We still have yq, mentioned a couple of posts earlier which does even more than grep, so i suppose it could satisfy both camps :) - - -- --- - - Jacek Lewandowski On Wed, Nov 24, 2021 at 6:13 PM Joseph Lynch wrote: > On Wed, Nov 24, 2021 at 9:00 AM Bowen Song wr

Re: [DISCUSS] CEP-17: SSTable format API (CASSANDRA-17056)

2021-11-15 Thread Jacek Lewandowski
. - - -- --- - - Jacek Lewandowski On Wed, Nov 10, 2021 at 9:01 PM David Capwell wrote: > If this gets descoped to test only (can break all interfaces in a minor) > then my support concerns are no longer valid; I am cool with the CEP scoped > only to improving testing > &

Re: [DISCUSS] Mentoring newcomers

2021-11-15 Thread Jacek Lewandowski
I'm in - - -- --- - - Jacek Lewandowski On Mon, Nov 15, 2021 at 7:34 AM Berenguer Blasi wrote: > I'm in as well > > On 14/11/21 14:55, Joshua McKenzie wrote: > > Sign me up. > > > > > > On Fri, Nov 12, 2021 at 4:38 PM David Capwell

Re: [DISCUSS] CEP-17: SSTable format API (CASSANDRA-17056)

2021-11-02 Thread Jacek Lewandowski
David, I apologize I did not mention those things explicitly. All the places where sstable files are accessed directly would have to be refactored. Regarding TableMetrics - currently it includes many metrics, some of them are unrelated to sstables at all, but there are metrics which are specific

Re: [DISCUSS] Releasable trunk and quality

2021-11-01 Thread Jacek Lewandowski
to limit work in GA releases to bug fixes exclusively. It remains > to be seen if this holds. Are there any precise requirements for supported upgrade and downgrade paths? Thanks - - -- --- - ---- - Jacek Lewandowski On Sat, Oct 30, 2021 at 4:07 PM bened...@apache

Re: [DISCUSS] Releasable trunk and quality

2021-11-02 Thread Jacek Lewandowski
the code which occurs intermittently under some rare conditions - - -- --- - - Jacek Lewandowski On Tue, Nov 2, 2021 at 7:46 AM Berenguer Blasi wrote: > Hi, > > we already have a way to confirm flakiness on circle by running the test > repeatedly N times. Like

Re: [VOTE] Release dtest-api 0.0.11

2021-10-29 Thread Jacek Lewandowski
+1 - - -- --- - - Jacek Lewandowski On Fri, Oct 29, 2021 at 4:48 PM Brandon Williams wrote: > +1 > > On Fri, Oct 29, 2021 at 7:45 AM Mick Semb Wever wrote: > > > > Proposing the test build of in-jvm dtest API 0.0.11 for release. > >

[DISCUSS] How to implement backward compatibility (CASSANDRA-17048)

2021-10-26 Thread Jacek Lewandowski
Hi, In short, we are discussing UUID based sstable generation identifiers in https://issues.apache.org/jira/browse/CASSANDRA-17048. The question which somehow hold us is support for downgrading. Long story short, when we generate new sstables with uuid based ids, they are not readable by

Re: [DISCUSS] How to implement backward compatibility (CASSANDRA-17048)

2021-10-26 Thread Jacek Lewandowski
Though, the user is unable to test the new feature without enabling it. And when it is enabled, the user is unable to revert it. - - -- --- - - Jacek Lewandowski On Tue, Oct 26, 2021 at 12:54 PM Bowen Song wrote: > Personally, I would prefer a transition per

Re: [DISCUSS] How to implement backward compatibility (CASSANDRA-17048)

2021-10-26 Thread Jacek Lewandowski
to force users to migrate, I don’t think there’s any rush, and the > > important thing to avoid is providing users no version buffer to escape new > > bugs – if a major version later we force upgrade, then they have a whole > > range of major versions to downgrade to that still support th

[QUESTION] Should JVM dtests be resistant to System.exit called in the node thread?

2021-10-27 Thread Jacek Lewandowski
I'm testing startup checks and expect them to fail in a certain scenario but the test just exists because when a startup check fails, Cassandra calls System.exit. It is possible to create CassandraDaemon with "runManaged" constructor arg which prevents System.exit and make the code throw

Re: [DISCUSS] How to implement backward compatibility (CASSANDRA-17048)

2021-10-27 Thread Jacek Lewandowski
Yes, I implemented that as mentioned above - cassandra.yaml option, disabled by default, description explaining the reason and consequences. - - -- --- - - Jacek Lewandowski On Wed, Oct 27, 2021 at 3:58 PM David Capwell wrote: > > should we let users enable t

Re: Welcome Aleksandr Sorokoumov as Cassandra committer

2022-03-17 Thread Jacek Lewandowski
Congratulations !!! - - -- --- - - Jacek Lewandowski On Thu, Mar 17, 2022 at 8:49 AM Mick Semb Wever wrote: > > Congrats Aleksandr! 拾 > > On Wed, 16 Mar 2022 at 14:16, Benjamin Lerer wrote: > >> The PMC members are pleased to announce that Ale

Re: Updating our Code Contribution/Style Guide

2022-03-14 Thread Jacek Lewandowski
? - - -- --- - - Jacek Lewandowski On Tue, Mar 15, 2022 at 1:52 AM Dinesh Joshi wrote: > Benedict, I agree. We should not be rigid about applying any style. > stylechecks are meant to bring uniformity in the codebase. I assure you > what I am proposing is neither rigid nor curbs th

Re: Updating our Code Contribution/Style Guide

2022-03-14 Thread Jacek Lewandowski
e. I do not know why they are as they are. > > > > > - define continuation indent - currently it is 0 characters > > > > An opening brace introduces any necessary indentation (from the start of > the line, which is perfect for legibility). I am somewhat inlined to > decla

Re: Updating our Code Contribution/Style Guide

2022-03-14 Thread Jacek Lewandowski
otherwise this effort may have little effect. For the transition, perhaps checkstyle could run on CircleCI just for the modified files? Thanks, jacek - - -- --- - ----- Jacek Lewandowski On Mon, Mar 14, 2022 at 1:10 PM Josh McKenzie wrote: > we should ad

Re: Updating our Code Contribution/Style Guide

2022-03-20 Thread Jacek Lewandowski
/ changed code. thanks - - -- --- - - Jacek Lewandowski On Sun, Mar 20, 2022 at 8:55 PM Mick Semb Wever wrote: > > > On Tue, 15 Mar 2022 at 11:46, Ruslan Fomkin > wrote: > >> … >> I support Jacek’s request to have each argument on a separate

Re: [DISCUSS] Should we deprecate / freeze python dtests

2022-03-28 Thread Jacek Lewandowski
Although I like in-jvm DTests for many scenarios, I can see that they do not test the production code as it is. They use a separate implementation of instance initialization and thus they test the test server rather than the real node. Other than that, it can be problematic to test upgrades when

Re: [VOTE] Release Apache Cassandra 5.0-alpha1 (take3)

2023-09-07 Thread Jacek Lewandowski
Mick, is the documentation / website ok? If so, +1 Best Regards, - - -- --- - - Jacek Lewandowski czw., 7 wrz 2023 o 12:58 Brandon Williams napisał(a): > +1 > > Kind Regards, > Brandon > > On Mon, Sep 4, 2023 at 3:26 PM Mick Semb Wever wrote: >

Re: [VOTE] Release Apache Cassandra 5.0-alpha1 (take3)

2023-09-08 Thread Jacek Lewandowski
Ok, +1 czw., 7 wrz 2023, 21:33 użytkownik Mick Semb Wever napisał: > > > On Thu, 7 Sept 2023 at 13:53, Jacek Lewandowski < > lewandowski.ja...@gmail.com> wrote: > >> Mick, is the documentation / website ok? >> > > > Can you elaborate on what is ok

Re: Push TCM (CEP-21) and Accord (CEP-15) to 5.1 (and cut an immediate 5.1-alpha1)

2023-10-27 Thread Jacek Lewandowski
accordingly to participate in the remaining work. Thanks, - - -- --- - - Jacek Lewandowski pt., 27 paź 2023 o 10:26 Benjamin Lerer napisał(a): > I would be interested in testing Maxim's approach. We need more visibility > on big features and their progress to impro

Re: Slow unit tests with Cassandra 4.x on macOS

2022-06-02 Thread Jacek Lewandowski
Which tests exactly? - - -- --- - - Jacek Lewandowski On Thu, Jun 2, 2022 at 8:39 AM Erick Ramirez wrote: > Johannes, I've copied the Dev ML to hopefully get a wider audience. Cheers! > > On Wed, 1 Jun 2022 at 21:25, Johannes Weißl wrote: > >> Hello

Re: Slow unit tests with Cassandra 4.x on macOS

2022-06-22 Thread Jacek Lewandowski
: InetAddress.getLocalHost() If this is not the case, please share some small reproduction example, I'll try to figure it out Thanks, - - -- --- - - Jacek Lewandowski On Thu, Jun 9, 2022 at 8:49 PM Johannes Weißl wrote: > Hi Jacek, > > The unit tests are from the company I work

Re: [DISCUSS] Making a 4.0.5 release

2022-07-12 Thread Jacek Lewandowski
+1 - - -- --- - - Jacek Lewandowski On Mon, Jul 11, 2022 at 6:59 AM Berenguer Blasi wrote: > +1 > On 8/7/22 18:42, Jeremiah D Jordan wrote: > > 4.0.4 went out mid May, so +1 from me for cutting 4.0.5 soon/now. > > Should we get into a habit of releas

Re: [DISCUSS] CEP-21: Transactional Cluster Metadata

2022-09-06 Thread Jacek Lewandowski
n of everywhere replication strategy, doesn't it? - - -- --- - - Jacek Lewandowski On Tue, Sep 6, 2022 at 9:19 AM Sam Tunnicliffe wrote: > > > > On 5 Sep 2022, at 22:02, Henrik Ingo wrote: > > Mostly I just wanted to ack that at least someone read th

Re: [VOTE] Release Apache Cassandra 4.0.7

2022-10-21 Thread Jacek Lewandowski
+1 - - -- --- - - Jacek Lewandowski On Fri, Oct 21, 2022 at 11:18 AM Benjamin Lerer wrote: > +1 > > Le ven. 21 oct. 2022 à 10:27, Miklosovic, Stefan < > stefan.mikloso...@netapp.com> a écrit : > >> +1 >> >>

Re: [VOTE] Release Apache Cassandra 4.1-beta1

2022-09-30 Thread Jacek Lewandowski
+1 - - -- --- - - Jacek Lewandowski On Fri, Sep 30, 2022 at 11:38 AM Andrés de la Peña wrote: > +1 > > On Fri, 30 Sept 2022 at 09:26, Benjamin Lerer wrote: > >> +1 >> >> Le ven. 30 sept. 2022 à 08:11, Miklosovic, Stefan < >>

[DISCUSS] Clear rules about sstable versioning and downgrade support

2023-01-13 Thread Jacek Lewandowski
with version (X-1)* and X* (which means that all the minor future versions X. Perhaps we could make some commitment to change major sstable format only with new major release? What do you think? Thanks - - -- --- - - Jacek Lewandowski

Re: upgrade sstable selection

2023-01-11 Thread Jacek Lewandowski
like the mentioned compactor would get wrong order. I suggest creating a ticket and fix the upgrader code by explicitly ordering sstables by their id. The comparator for SSTableId is available in SSTableIdFactory.COMPARATOR. Thanks, - - -- --- - - Jacek Lewandowski On Tue

Re: Introducing mockito-inline library among test dependencies

2023-01-12 Thread Jacek Lewandowski
Will it work with Java17? czw., 12 sty 2023, 12:56 użytkownik Brandon Williams napisał: > +1 > > Kind Regards, > Brandon > > On Wed, Jan 11, 2023 at 2:02 PM Miklosovic, Stefan > wrote: > > > > Hi list, > > > > the test for (1) is using mockito-inline dependency for mocking static > methods as

Re: Review requested: Add downgradesstables

2022-12-09 Thread Jacek Lewandowski
Hi, The feature looks useful to me Could you add the pull request address to the ticket and summarize the features it is going to provide? Thank you, - - -- --- - - Jacek Lewandowski On Fri, Dec 9, 2022 at 10:13 AM Claude Warren, Jr via dev < dev@cassandra.apache.

Re: [VOTE] CEP-25: Trie-indexed SSTable format

2022-12-19 Thread Jacek Lewandowski
+1 - - -- --- - - Jacek Lewandowski On Mon, Dec 19, 2022 at 2:00 PM Branimir Lambov wrote: > Hi everyone, > > I'd like to propose CEP-25 for approval. > > Proposal: > https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-25%3A+Trie-inde

Re: [DISCUSS] CEP-25: Trie-indexed SSTable format

2022-11-22 Thread Jacek Lewandowski
+1 for the proposal ! btw. regarding tests - perhaps we will have to let Python DTests run with either new or old format thanks - - -- --- - - Jacek Lewandowski On Mon, Nov 21, 2022 at 3:06 PM Benedict wrote: > Yes of course, this was absolutely just a qu

Re: Merging CEP-15 to trunk

2023-01-16 Thread Jacek Lewandowski
/index.html but for unreleased Cassandra version or a blog post, so that the syntax is known to the users and they can quickly get into speed, hopefully reporting any problems soon. - - -- --- - - Jacek Lewandowski On Mon, 16 Jan 2023 at 17:52, Benedict wrote: > That’s f

Re: Role of Hadoop code in Cassandra 5.0

2023-03-10 Thread Jacek Lewandowski
I've experimentally added https://issues.apache.org/jira/browse/CASSANDRA-16984 to https://issues.apache.org/jira/browse/CASSANDRA-18306 (post 4.0 cleanup) - - -- --- - - Jacek Lewandowski pt., 10 mar 2023 o 09:56 Berenguer Blasi napisał(a): > +1 deprecate + remo

Re: Role of Hadoop code in Cassandra 5.0

2023-03-09 Thread Jacek Lewandowski
Is there a ticket for that? - - -- --- - - Jacek Lewandowski czw., 9 mar 2023 o 20:27 Mick Semb Wever napisał(a): > > > On Thu, 9 Mar 2023 at 18:54, Brandon Williams wrote: > >> I think if we reach consensus here that decides it. I too vote to >

Re: [DISCUSS] Drop support for sstable formats m* (in trunk)

2023-03-14 Thread Jacek Lewandowski
people are still on 3.11 and we should not make their life harder when they consider upgrading directly to 5.0. Though clear rules for that would help the users and us. thanks, - - -- --- - - Jacek Lewandowski wt., 14 mar 2023 o 15:36 C. Scott Andreas napisał(a): >

Re: Welcome our next PMC Chair Josh McKenzie

2023-03-23 Thread Jacek Lewandowski
Congrats Josh! - - -- --- - - Jacek Lewandowski czw., 23 mar 2023 o 09:32 Berenguer Blasi napisał(a): > Congrats Josh! > On 23/3/23 9:22, Mick Semb Wever wrote: > > It is time to pass the baton on, and on behalf of the Apache Cassandra > Project Manag

Re: Role of Hadoop code in Cassandra 5.0

2023-03-09 Thread Jacek Lewandowski
I vote for removing it entirely. thanks - - -- --- - - Jacek Lewandowski czw., 9 mar 2023 o 18:07 Miklosovic, Stefan napisał(a): > Derek, > > I have couple more points ... I do not think that extracting it to a > separate repository is "win".

Re: Role of Hadoop code in Cassandra 5.0

2023-03-09 Thread Jacek Lewandowski
Lewandowski czw., 9 mar 2023 o 18:08 Jacek Lewandowski napisał(a): > I vote for removing it entirely. > > thanks > - - -- --- - ----- > Jacek Lewandowski > > > czw., 9 mar 2023 o 18:07 Miklosovic, Stefan > napisał(a): > >> Derek, >> >&

Re: Role of Hadoop code in Cassandra 5.0

2023-03-09 Thread Jacek Lewandowski
Is it possible to deprecate it in the 4.1.x patch release? :) - - -- --- - - Jacek Lewandowski czw., 9 mar 2023 o 18:11 Brandon Williams napisał(a): > This is my feeling too, but I think we should accomplish this by > deprecating it first. I don't expect an

Re: Should we cut some new releases?

2023-03-13 Thread Jacek Lewandowski
+1 pon., 13 mar 2023, 20:36 użytkownik Miklosovic, Stefan < stefan.mikloso...@netapp.com> napisał: > Yes, I was waiting for CASSANDRA-18125 to be in. > > I can release 4.1.1 to staging tomorrow morning CET if nobody objects that. > > Not sure about 4.0.9. We released 4.0.8 just few weeks ago. I

Re: Downgradability

2023-03-06 Thread Jacek Lewandowski
A bit of organization - I've created https://issues.apache.org/jira/browse/CASSANDRA-18300 epic to track tickets related to the downgradability. Please add the tickets you are aware of. thanks - - -- --- - - Jacek Lewandowski czw., 23 lut 2023 o 17:47 Benedict napisał

Re: [DISCUSSION] Cassandra's code style and source code analysis

2023-02-22 Thread Jacek Lewandowski
I suppose it can be easy for the existing feature branches if they have a single commit. Don't we need to adjust each commit for multi-commit feature branches? śr., 22 lut 2023, 19:48 użytkownik Maxim Muzafarov napisał: > Hello everyone, > > I have created an issue CASSANDRA-18277 that may help

Re: Downgradability

2023-02-23 Thread Jacek Lewandowski
Running upgrade tests backwards is great idea which does not require extra work. For stats metadata it already supports writing in previous serialization version We need a small fix in compression metadata and that's it. A flag with the write format version is probably LHF. Maybe let's try,

Merging CEP-17

2023-02-27 Thread Jacek Lewandowski
gonna merge it this week. I'm also open for doing some follow-up work if something is missing or something more is needed. Thanks, - - -- --- - - Jacek Lewandowski

Re: Downgradability

2023-02-20 Thread Jacek Lewandowski
ranges, like one impl for ma-nz, other for oa+, etc. without having a confusing implementation with a lot of conditional blocks. Old formats in such case could be maintained separately from the main code and easily switched any time. thanks - - -- --- - - Jacek Lewandowski

Re: [DISCUSS] Moving system property names to the CassandraRelevantProperties

2023-03-30 Thread Jacek Lewandowski
I'll do - - -- --- - - Jacek Lewandowski czw., 30 mar 2023 o 22:09 Miklosovic, Stefan napisał(a): > Hi list, > > we are looking for one more committer to take a look at this patch (1, 2). > > It looks like there is a lot to go through because of

Re: [DISCUSS] Introduce DATABASE as an alternative to KEYSPACE

2023-04-04 Thread Jacek Lewandowski
While for someone who already knows Cassandra keyspace is something natural, for newcomers it is yet another concept to understand. If namespace is used in PostgreSQL, it sounds even better to me. Thanks, - - -- --- - - Jacek Lewandowski wt., 4 kwi 2023 o 19:07 Rahul

Re: [VOTE] CEP-26: Unified Compaction Strategy

2023-04-04 Thread Jacek Lewandowski
+1 - - -- --- - - Jacek Lewandowski wt., 4 kwi 2023 o 15:01 Berenguer Blasi napisał(a): > +1 > On 4/4/23 14:36, J. D. Jordan wrote: > > +1 > > On Apr 4, 2023, at 7:29 AM, Brandon Williams > wrote: > >  > +1 > > On Tue, Apr 4,

Re: [DISCUSS] Introduce DATABASE as an alternative to KEYSPACE

2023-04-06 Thread Jacek Lewandowski
config, like simple 1, so that creating a names boils down to a simply CREATE KEYSPACE|SCHEMA|DATABASE|NAMESPACE ; thanks, - - -- --- - - Jacek Lewandowski czw., 6 kwi 2023 o 04:09 guo Maxwell napisał(a): > either KEYSPACE or DATABASE or SCHEMA is better than NAMESP

Re: [EXTERNAL] Re: (CVE only) support for 3,11 beyond published EOL

2023-04-14 Thread Jacek Lewandowski
of validation whether that effort is justified. btw. We have recently agreed to keep support for M sstables format (3.0 - 3.11). thanks, - - -- --- - - Jacek Lewandowski czw., 13 kwi 2023 o 21:59 Mick Semb Wever napisał(a): > Yes, this would be great. Right now us

Re: [VOTE] CEP-21 Transactional Cluster Metadata

2023-02-07 Thread Jacek Lewandowski
+1 - - -- --- - - Jacek Lewandowski wt., 7 lut 2023 o 10:12 Benjamin Lerer napisał(a): > +1 > > Le mar. 7 févr. 2023 à 06:21, a écrit : > >> +1 nb >> >> On Feb 6, 2023, at 9:05 PM, Ariel Weisberg wrote: >> >> +1 &

Re: Welcome Patrick McFadin as Cassandra Committer

2023-02-02 Thread Jacek Lewandowski
Congrats !!! - - -- --- - - Jacek Lewandowski czw., 2 lut 2023 o 19:10 Melissa Logan napisał(a): > Congrats, Patrick! > > On Thu, Feb 2, 2023 at 9:58 AM Benjamin Lerer wrote: > >> The PMC members are pleased to announce that Patrick Mc

Re: [DISCUSS] Limiting query results by size (CASSANDRA-11745)

2023-06-12 Thread Jacek Lewandowski
Josh, that answers my question exactly; thank you. I will not implement limiting the result set in CQL (that is, by LIMIT clause) and stay with just paging. Whether the page size is defined in bytes or rows can be determined by a flag - there are many unused bits for that. So my other question -

Re: Fwd: [DISCUSS] Formalizing requirements for pre-commit patches on new CI

2023-07-12 Thread Jacek Lewandowski
y 2 effort and define packages in >> the primary codebase where changes take place and multiplex (on a smaller >> scale) their respective packages of unit tests in the future if we see >> problems in this area. >> >> Flakey tests are a giant pain in the ass and a huge d

Re: Fwd: [DISCUSS] Formalizing requirements for pre-commit patches on new CI

2023-07-12 Thread Jacek Lewandowski
., 12 lip 2023 o 14:52 Jacek Lewandowski napisał(a): > Would it be re-opening the ticket or creating a new ticket with "revert of > fix" ? > > > > śr., 12 lip 2023 o 14:51 Ekaterina Dimitrova > napisał(a): > >> jenkins_jira_integration >> <http

Re: Fwd: [DISCUSS] Formalizing requirements for pre-commit patches on new CI

2023-07-12 Thread Jacek Lewandowski
Isn't novnodes a special case of vnodes with n=1 ? We should rather select a subset of tests for which it makes sense to run with different configurations. The set of configurations against which we run the tests currently is still only the subset of all possible cases. I could ask - why don't

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-07-11 Thread Jacek Lewandowski
; just gotten sidetracked by things and also realized how little I've >> actually modified locally since I just run most of the linting against >> delta'ed files only to keep my changed work in compliance. Still a very >> noisy mess when SpotBugs is run against the entire codebase

Re: [DISCUSS] Limiting query results by size (CASSANDRA-11745)

2023-07-10 Thread Jacek Lewandowski
eturned to the user when the full row > is queried without transformation. For all the other case the difference > can be really significant. For a group by queries doing a count(*), the > approach suggested will return a page size that is totally off with what > was requested. > > Le

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-07-10 Thread Jacek Lewandowski
>>> I'm not saying what you've proposed is bad, in fact, we're not >>> currently doing the pipeline I'm talking about, but adding an >>> additional endpoint is something we should consider very carefully as >>> it may create some difficulties for Maven/G

Re: [DISCUSS] Formalizing requirements for pre-commit patches on new CI

2023-07-05 Thread Jacek Lewandowski
Perhaps pre-commit checks should include mostly the typical configuration of Cassandra rather than some subset of possible combinations. Like it was said somewhere above - test with the default number of vnodes, test with the default compression settings, and test with the default heap/off-heap

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-07-06 Thread Jacek Lewandowski
rina >>> >>> On Thu, 29 Jun 2023 at 10:52, Josh McKenzie >>> wrote: >>> >>> >>> I really prefer separate tasks than flags. Flags are not listed in the >>> help message like "ant -p" and are not auto-completed in t

Re: [CASSANDRA-11471] Authentication mechanism negotiation (OPTIONS/SUPPORTED)

2023-05-26 Thread Jacek Lewandowski
a separate thread on that topic soon. thanks - - -- --- - - Jacek Lewandowski pt., 26 maj 2023 o 04:08 Dinesh Joshi napisał(a): > Leaving the naming aside (the hardest part of any software), I am > generally positive about your idea. A protocol version bu

[DISCUSS] CEP-31 negotiated authentication

2023-05-26 Thread Jacek Lewandowski
+and+authorization thanks, - - -- --- - - Jacek Lewandowski

Re: [DISCUSS] Limiting query results by size (CASSANDRA-11745)

2023-06-12 Thread Jacek Lewandowski
the resultset, or we instead want to use this >> mechanism to limit the amount of memory used internally for the data and >> prevent problems (assuming restricting size and rows number can be used >> simultaneously in a way that we stop when we reach any of the specified >> limits). >> >> https://issues.apache.org/jira/browse/CASSANDRA-11745 >> >> thanks, >> - - -- --- - - >> Jacek Lewandowski >> >

Re: [DISCUSS] Limiting query results by size (CASSANDRA-11745)

2023-06-12 Thread Jacek Lewandowski
then is > is really confusing and can be a problem for some usecases. We have users > keeping their session open and the page information to display page of data. > > Le lun. 12 juin 2023 à 09:08, Jacek Lewandowski < > lewandowski.ja...@gmail.com> a écrit : > >> Hi, &g

[DISCUSS] Limiting query results by size (CASSANDRA-11745)

2023-06-12 Thread Jacek Lewandowski
SANDRA-11745 thanks, - - -- --- - ---- ----- Jacek Lewandowski

Re: [DISCUSSION] Shall we remove ant javadoc task?

2023-08-02 Thread Jacek Lewandowski
With or without outputting JavaDoc to HTML, there are some errors which we should maybe fix. We want to keep the documentation, but there can be syntax errors which may prevent IDE generating a proper preview. So, the question is - should we validate the JavaDoc comments as a precommit task? Can

[DISCUSS] When to run CheckStyle and other verificiations

2023-06-26 Thread Jacek Lewandowski
and do not even touch Ant commands directly Checks can take time; to optimize that, they could be enforced locally to verify only the modified files in the same way as we currently determine the tests to be repeated for CircleCI. Thanks - - -- --- - - Jacek Lewandowski

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-26 Thread Jacek Lewandowski
consistently by adding a Git hook. Do you think we can encounter some particular problems with this approach? Maxim, this is a great idea, and I fully support it - but this does not address the issues I've raised there. - - -- --- - - Jacek Lewandowski pon., 26 cze 2023 o 14:05

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-26 Thread Jacek Lewandowski
That would work as well Brandon, basically what is proposed in CASSANDRA-18618, that is "check" target, actually needs to build the project to perform some verifications - I suppose running "ant check" should be sufficient. - - -- --- - ---- ----- Jacek Lewand

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-26 Thread Jacek Lewandowski
Yes, I've mentioned that there is a property we can set to skip checkstyle. Currently such a goal is "artifacts" which basically validates everything. - - -- --- - ----- Jacek Lewandowski pon., 26 cze 2023 o 13:09 Mike Adamson napisał(a): > While I

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-29 Thread Jacek Lewandowski
nd eclipse-warnings There is an additional flag "no-check" to disable checks in the "jar" target. Will not introduce any Git hook. wt., 27 cze 2023 o 18:35 Jacek Lewandowski napisał(a): > With git you can always opt-out by adding --no-verify flag to either push > or commi

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-29 Thread Jacek Lewandowski
> > On Thu, Jun 29, 2023 at 3:22 AM Jacek Lewandowski > wrote: > > > > So given all the feedback, I'm going to do the following: > > > > "jar" will depend on "check" target > > "build-project", "build-test" and "te

Re: [DISCUSSIONS] Replace ant eclipse-warnings with CheckerFramework

2023-06-16 Thread Jacek Lewandowski
Additional question is whether we want to run the checks against the whole project or just against the file changes between the feature branch and the target release branch? - - -- --- - - Jacek Lewandowski pt., 16 cze 2023 o 13:09 Aleksey Yeshchenko napisał

Re: [DISCUSSIONS] Replace ant eclipse-warnings with CheckerFramework

2023-06-16 Thread Jacek Lewandowski
Later, we may enable more checks than just leaked resources to improve the code gradually. - - -- --- - - Jacek Lewandowski pt., 16 cze 2023 o 13:48 Ekaterina Dimitrova napisał(a): > Got so excited that I forgot to say which of the two options exactly I >

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-27 Thread Jacek Lewandowski
recognize the sender and know the content is >> safe. >> >> >> >> not running it automatically with the targets which devs usually run >> locally. >> >> The checks tend to have an opt-out, such as -Dno-checkstyle=true… so its >> really

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-27 Thread Jacek Lewandowski
not be the best one is valid, and we should rather think about pre-commit - - -- --- - - Jacek Lewandowski wt., 27 cze 2023 o 09:25 Miklosovic, Stefan napisał(a): > I am doing all git-related operations in the console / bash (IDEA > terminal, alt+f12 in IDEA). I know ID

Re: [DISCUSS] When to run CheckStyle and other verificiations

2023-06-27 Thread Jacek Lewandowski
With git you can always opt-out by adding --no-verify flag to either push or commit I really prefer separate tasks than flags. Flags are not listed in the help message like "ant -p" and are not auto-completed in the terminal. That makes them almost undiscoverable for newcomers. Want to have jar

Re: [Discuss] "Latest" configuration for testing and evaluation (CASSANDRA-18753)

2024-02-14 Thread Jacek Lewandowski
śr., 14 lut 2024 o 17:30 Josh McKenzie napisał(a): > When we have failing tests people do not spend the time to figure out if > their logic caused a regression and merge, making things more unstable… so > when we merge failing tests that leads to people merging even more failing > tests... > >

Re: [Discuss] "Latest" configuration for testing and evaluation (CASSANDRA-18753)

2024-02-14 Thread Jacek Lewandowski
I fully understand you. Although I have that luxury to use more containers, I simply feel that rerunning the same code with different configurations which do not impact that code is just a waste of resources and money. - - -- --- - - Jacek Lewandowski czw., 15 lut 2024

Re: [Discuss] "Latest" configuration for testing and evaluation (CASSANDRA-18753)

2024-02-14 Thread Jacek Lewandowski
h and minimally require precommit tests for that configuration. >> Assignees and reviewers can determine if additional test variants are >> required based on the patch scope. >> >> Nightly and prerelease tests can be run to catch any issues outside the >> standard

Re: [Discuss] "Latest" configuration for testing and evaluation (CASSANDRA-18753)

2024-02-15 Thread Jacek Lewandowski
Great summary Josh, > >- JDK-based test suites on highest supported jdk using other config > > Do you mean a smoke test suite by that ^ ? - - -- --- - ----- Jacek Lewandowski czw., 15 lut 2024 o 18:12 Josh McKenzie napisał(a): > Would it make sens

Re: [Discuss] "Latest" configuration for testing and evaluation (CASSANDRA-18753)

2024-02-15 Thread Jacek Lewandowski
Brandon, that should be doable with the current filters I think - that is, select only those tests which do not support vnodes. Do you know about such in-jvm dtests as well? - - -- --- - - Jacek Lewandowski czw., 15 lut 2024 o 18:21 Brandon Williams napisał

Re: [Discuss] Introducing Flexible Authentication in Cassandra via Feature Flag

2024-02-14 Thread Jacek Lewandowski
to let the administrators enable/disable and reconfigure authentication without a restart so we could discuss whether such transitional mode would be needed at all in that case. Thanks, - - -- --- - - Jacek Lewandowski wt., 13 lut 2024 o 07:04 Jeff Jirsa napisał

Re: [Discuss] "Latest" configuration for testing and evaluation (CASSANDRA-18753)

2024-02-16 Thread Jacek Lewandowski
We should conclude this discussion by answering Branimir's original question.* I vote for merging that and exposing issues to the CI.* For pre-commit optimization I've opened https://issues.apache.org/jira/browse/CASSANDRA-19406 epic and we should add exact tasks there to make this valuable

Re: [Discuss] Improving CI workflows

2024-02-20 Thread Jacek Lewandowski
Let's not start another thread and discuss that directly on the ticket. - - -- --- - - Jacek Lewandowski wt., 20 lut 2024 o 11:31 Berenguer Blasi napisał(a): > Hi All, > > after the recent discussion that came up in CASSANDRA-18753's discuss > thre

Re: Welcome Brad Schoening as Cassandra Committer

2024-02-22 Thread Jacek Lewandowski
Congrats Brad! - - -- --- - - Jacek Lewandowski czw., 22 lut 2024 o 01:29 Štefan Miklošovič napisał(a): > Congrats Brad, great work in the Python department :) > > On Wed, Feb 21, 2024 at 9:46 PM Josh McKenzie > wrote: > >> The Apache Cas

Re: [Discuss] "Latest" configuration for testing and evaluation (CASSANDRA-18753)

2024-02-14 Thread Jacek Lewandowski
We should not block merging configuration changes given it is a valid configuration - which I understand as it is correct, passes all config validations, it matches documented rules, etc. And this provided latest config matches those requirements I assume. The failures should block release or we

Re: Harry in-tree (Forked from "Long tests, Burn tests, Simulator tests, Fuzz tests - can we clarify the diffs?")

2023-12-22 Thread Jacek Lewandowski
Obviously +1 Thank you Alex pt., 22 gru 2023, 16:45 użytkownik Sumanth Pasupuleti < sumanth.pasupuleti...@gmail.com> napisał: > +1, thank you for your efforts in bringing Harry in-tree. Anything that > improves the testing ecosystem for Cassandra, particularly around complex > scenarios / edge

Re: [ATTENTION] Forced push on cassandra-5.0 branch !!!

2023-12-16 Thread Jacek Lewandowski
no such merge (I pushed this branch also to my personal fork: https://github.com/jacek-lewandowski/cassandra/commits/cassandra-5.0) I am really curious about what went wrong as I want to avoid that in the future - - -- --- - - Jacek Lewandowski niedz., 17 gru 2023 o 05:00

Re: Long tests, Burn tests, Simulator tests, Fuzz tests - can we clarify the diffs?

2023-12-12 Thread Jacek Lewandowski
less well justified, which it may be - > just not immediately obvious to me. > > On 11 Dec 2023, at 08:33, Jacek Lewandowski > wrote: > >  > Nobody referred so far to the idea of moving to JUnit 5, what are the > opinions? > > > > niedz., 10 gru 2023 o 11:03

  1   2   >