Re: [DISCUSS] Change style guide to recommend use of @Override

2020-09-02 Thread David Capwell
Thanks all! Sent a patch out in https://issues.apache.org/jira/browse/CASSANDRA-16096 and tested the change autogenerates the annotation now (if using Intellij it is best to delete the project and regenerate it as the change didn't take without deleting in intellij). On Wed, Sep 2, 2020 at 10:22

Re: [DISCUSS] Change style guide to recommend use of @Override

2020-09-02 Thread Blake Eggleston
+1 > On Sep 1, 2020, at 11:27 AM, David Capwell wrote: > > Currently our style guide recommends to avoid using @Override and updates > intellij's code style to exclude it by default; I would like to propose we > change this recommendation to use it and to update intellij's style to > include it

Re: [DISCUSS] Change style guide to recommend use of @Override

2020-09-02 Thread Aleksey Yeshchenko
+1. Some of us have already adopted this change some time ago, but it’d be nice to make it official for everybody. > On 1 Sep 2020, at 19:27, David Capwell wrote: > > Currently our style guide recommends to avoid using @Override and updates > intellij's code style to exclude it by default; I

Re: [DISCUSS] Change style guide to recommend use of @Override

2020-09-02 Thread Robert Stupp
+1 — Robert Stupp @snazy > On 2. Sep 2020, at 10:38, Sylvain Lebresne wrote: > > +1 > -- > Sylvain > > > On Wed, Sep 2, 2020 at 10:21 AM Sam Tunnicliffe wrote: > >> +1 >> >>> On 2 Sep 2020, at 09:03, Benjamin Lerer >> wrote: >>> >>> +1 >>> >>> >>> >>> On Wed, Sep 2, 2020 at 5:36 AM

Re: [DISCUSS] Change style guide to recommend use of @Override

2020-09-02 Thread Sylvain Lebresne
+1 -- Sylvain On Wed, Sep 2, 2020 at 10:21 AM Sam Tunnicliffe wrote: > +1 > > > On 2 Sep 2020, at 09:03, Benjamin Lerer > wrote: > > > > +1 > > > > > > > > On Wed, Sep 2, 2020 at 5:36 AM Berenguer Blasi > > > wrote: > > > >> +1 > >> > >> On 2/9/20 5:09, Joshua McKenzie wrote: > >>> +1 > >>>

Re: [DISCUSS] Change style guide to recommend use of @Override

2020-09-02 Thread Sam Tunnicliffe
+1 > On 2 Sep 2020, at 09:03, Benjamin Lerer wrote: > > +1 > > > > On Wed, Sep 2, 2020 at 5:36 AM Berenguer Blasi > wrote: > >> +1 >> >> On 2/9/20 5:09, Joshua McKenzie wrote: >>> +1 >>> >>> On Tue, Sep 1, 2020 at 6:26 PM Jordan West wrote: >>> +1 On Tue, Sep 1, 2020 at

Re: [DISCUSS] Change style guide to recommend use of @Override

2020-09-02 Thread Benjamin Lerer
+1 On Wed, Sep 2, 2020 at 5:36 AM Berenguer Blasi wrote: > +1 > > On 2/9/20 5:09, Joshua McKenzie wrote: > > +1 > > > > On Tue, Sep 1, 2020 at 6:26 PM Jordan West wrote: > > > >> +1 > >> > >> On Tue, Sep 1, 2020 at 12:22 PM Benedict Elliott Smith < > >> bened...@apache.org> > >> wrote: > >>

Re: [DISCUSS] Change style guide to recommend use of @Override

2020-09-01 Thread Berenguer Blasi
+1 On 2/9/20 5:09, Joshua McKenzie wrote: > +1 > > On Tue, Sep 1, 2020 at 6:26 PM Jordan West wrote: > >> +1 >> >> On Tue, Sep 1, 2020 at 12:22 PM Benedict Elliott Smith < >> bened...@apache.org> >> wrote: >> >>> +1 >>> >>> >>> >>> On 01/09/2020, 20:09, "Caleb Rackliffe" >> wrote: >>> >>> >>>

Re: [DISCUSS] Change style guide to recommend use of @Override

2020-09-01 Thread Joshua McKenzie
+1 On Tue, Sep 1, 2020 at 6:26 PM Jordan West wrote: > +1 > > On Tue, Sep 1, 2020 at 12:22 PM Benedict Elliott Smith < > bened...@apache.org> > wrote: > > > +1 > > > > > > > > On 01/09/2020, 20:09, "Caleb Rackliffe" > wrote: > > > > > > > > +1 > > > > > > > > On Tue, Sep 1, 2020, 2:00

Re: [DISCUSS] Change style guide to recommend use of @Override

2020-09-01 Thread Jordan West
+1 On Tue, Sep 1, 2020 at 12:22 PM Benedict Elliott Smith wrote: > +1 > > > > On 01/09/2020, 20:09, "Caleb Rackliffe" wrote: > > > > +1 > > > > On Tue, Sep 1, 2020, 2:00 PM Jasonstack Zhao Yang < > jasonstack.z...@gmail.com> > > wrote: > > > > > +1 > > > > > > On Wed,

Re: [DISCUSS] Change style guide to recommend use of @Override

2020-09-01 Thread Benedict Elliott Smith
+1 On 01/09/2020, 20:09, "Caleb Rackliffe" wrote: +1 On Tue, Sep 1, 2020, 2:00 PM Jasonstack Zhao Yang wrote: > +1 > > On Wed, 2 Sep 2020 at 02:45, Dinesh Joshi wrote: > > > +1 > > > > > On Sep 1, 2020, at 11:27 AM, David Capwell wrote: > > >

Re: [DISCUSS] Change style guide to recommend use of @Override

2020-09-01 Thread Yifan Cai
+1 From: Caleb Rackliffe Sent: Tuesday, September 1, 2020 12:08:50 PM To: dev@cassandra.apache.org Subject: Re: [DISCUSS] Change style guide to recommend use of @Override +1 On Tue, Sep 1, 2020, 2:00 PM Jasonstack Zhao Yang wrote: > +1 > > On Wed, 2

Re: [DISCUSS] Change style guide to recommend use of @Override

2020-09-01 Thread Caleb Rackliffe
+1 On Tue, Sep 1, 2020, 2:00 PM Jasonstack Zhao Yang wrote: > +1 > > On Wed, 2 Sep 2020 at 02:45, Dinesh Joshi wrote: > > > +1 > > > > > On Sep 1, 2020, at 11:27 AM, David Capwell wrote: > > > > > > Currently our style guide recommends to avoid using @Override and > updates > > > intellij's

Re: [DISCUSS] Change style guide to recommend use of @Override

2020-09-01 Thread Jasonstack Zhao Yang
+1 On Wed, 2 Sep 2020 at 02:45, Dinesh Joshi wrote: > +1 > > > On Sep 1, 2020, at 11:27 AM, David Capwell wrote: > > > > Currently our style guide recommends to avoid using @Override and updates > > intellij's code style to exclude it by default; I would like to propose > we > > change this

Re: [DISCUSS] Change style guide to recommend use of @Override

2020-09-01 Thread Dinesh Joshi
+1 > On Sep 1, 2020, at 11:27 AM, David Capwell wrote: > > Currently our style guide recommends to avoid using @Override and updates > intellij's code style to exclude it by default; I would like to propose we > change this recommendation to use it and to update intellij's style to > include it

[DISCUSS] Change style guide to recommend use of @Override

2020-09-01 Thread David Capwell
Currently our style guide recommends to avoid using @Override and updates intellij's code style to exclude it by default; I would like to propose we change this recommendation to use it and to update intellij's style to include it by default. @Override is used by javac to enforce that a method is