Re: #{$cocoon/request/request/protocol}

2005-05-11 Thread Leszek Gawron
Daniel Fagerstrom wrote: AAHA! remember now. On pure o.a.c.environment.Request you cannot do coocon/request/someParameter (previous syntax) or the better one: cocoon/request/parameters/someParameter cocoon/request/attributes/someAttribute Sylvain refactored the environment handling in flow to

Re: #{$cocoon/request/request/protocol}

2005-05-11 Thread Sylvain Wallez
Daniel Fagerstrom wrote: Leszek Gawron wrote: Leszek Gawron wrote: Vadim Gritsenko wrote: snip/ Why FOM_Request is in jx in the first place? I understand why it is in old jxtg in Cocoon 2.1, but new version should be flow independent. The flow independence we talked about was to make JXTG work

Re: #{$cocoon/request/request/protocol}

2005-05-11 Thread Daniel Fagerstrom
Leszek Gawron wrote: Daniel Fagerstrom wrote: snip/ The accessors do not solve the problem with $cocoon/request/requestAttribute or $cocoon/request/requestParameter (preferably $cocoon/request/attributes/someAttribute and $cocoon/request/parameters/someParameter) We could provide some kind of

Re: #{$cocoon/request/request/protocol}

2005-05-11 Thread Leszek Gawron
Daniel Fagerstrom wrote: Leszek Gawron wrote: Daniel Fagerstrom wrote: snip/ The accessors do not solve the problem with $cocoon/request/requestAttribute or $cocoon/request/requestParameter (preferably $cocoon/request/attributes/someAttribute and $cocoon/request/parameters/someParameter) We

Re: #{$cocoon/request/request/protocol}

2005-05-11 Thread Leszek Gawron
Sylvain Wallez wrote: Daniel Fagerstrom wrote: Leszek Gawron wrote: Leszek Gawron wrote: Vadim Gritsenko wrote: snip/ Why FOM_Request is in jx in the first place? I understand why it is in old jxtg in Cocoon 2.1, but new version should be flow independent. The flow independence we talked

Re: #{$cocoon/request/request/protocol}

2005-05-11 Thread Daniel Fagerstrom
Sylvain Wallez wrote: Daniel Fagerstrom wrote: snip/ Sylvain refactored the environment handling in flow to simplify it, but it also lead to some back incompatibilities that we had long heated discussions about this in the begining of this year, check the archive. The varoious changes in the

Re: #{$cocoon/request/request/protocol}

2005-05-11 Thread Leszek Gawron
this.request.getParameter(name); } } If you accidentally provide a getter for private final Request request; than you are able to do $cocoon/request/request/protocol and the properties are visible. It means that FOM_Request is not able to properly proxy Request interface to JXPath. -- Leszek Gawron

Re: #{$cocoon/request/request/protocol}

2005-05-11 Thread Daniel Fagerstrom
Leszek Gawron wrote: Daniel Fagerstrom wrote: snip/ Are you certain about that it doesn't work for properties? I can't test right now, but looking at

Re: #{$cocoon/request/request/protocol}

2005-05-11 Thread Leszek Gawron
Daniel Fagerstrom wrote: Leszek Gawron wrote: Daniel Fagerstrom wrote: snip/ Are you certain about that it doesn't work for properties? I can't test right now, but looking at

Re: #{$cocoon/request/request/protocol}

2005-05-11 Thread Daniel Fagerstrom
Leszek Gawron wrote: Daniel Fagerstrom wrote: Leszek Gawron wrote: Daniel Fagerstrom wrote: snip/ IMO we should make the Request interface bean friendly and add the methods: Map getParameters(); Map getAttributes(); You won't reach those as collection in HttpServletRequest

Re: #{$cocoon/request/request/protocol}

2005-05-11 Thread Sylvain Wallez
Daniel Fagerstrom wrote: Sylvain Wallez wrote: Daniel Fagerstrom wrote: snip/ Sylvain refactored the environment handling in flow to simplify it, but it also lead to some back incompatibilities that we had long heated discussions about this in the begining of this year, check the archive. The

Re: #{$cocoon/request/request/protocol}

2005-05-11 Thread Leszek Gawron
Sylvain Wallez wrote: Daniel Fagerstrom wrote: Sylvain Wallez wrote: Daniel Fagerstrom wrote: snip/ Sylvain refactored the environment handling in flow to simplify it, but it also lead to some back incompatibilities that we had long heated discussions about this in the begining of this year,

#{$cocoon/request/request/protocol}

2005-05-10 Thread Leszek Gawron
I know now why #{$cocoon/request/protocol} does not work for JXPath in JXTG. Thing is FOM_Request is not JXPath friendly. JXPath is querying for all FOM_Request properties and finds none. if you add public Request getRequest() to FOM_Request then you are able to do #{$cocoon/request/request

Re: #{$cocoon/request/request/protocol}

2005-05-10 Thread Leszek Gawron
none. Why FOM_Request is in jxtg? I though this has already been refactored to use flow independent accessor. if you add public Request getRequest() to FOM_Request then you are able to do #{$cocoon/request/request/protocol} and it works. Yuck! Don't even think about it! Of course. I just

Re: #{$cocoon/request/request/protocol}

2005-05-10 Thread Vadim Gritsenko
Leszek Gawron wrote: Vadim Gritsenko wrote: Why FOM_Request is in jx in the first place? I understand why it is in old jxtg in Cocoon 2.1, but new version should be flow independent. for that we have to ask Daniel as he was the one to introduce it in TemplateObjectModelHelper revision 159059:

Re: #{$cocoon/request/request/protocol}

2005-05-10 Thread Leszek Gawron
properties and finds none. Why FOM_Request is in jxtg? I though this has already been refactored to use flow independent accessor. if you add public Request getRequest() to FOM_Request then you are able to do #{$cocoon/request/request/protocol} and it works. Yuck! Don't even think about

Re: #{$cocoon/request/request/protocol}

2005-05-10 Thread Daniel Fagerstrom
Leszek Gawron wrote: Leszek Gawron wrote: Vadim Gritsenko wrote: snip/ Why FOM_Request is in jx in the first place? I understand why it is in old jxtg in Cocoon 2.1, but new version should be flow independent. The flow independence we talked about was to make JXTG work without needing to call