So,

I’ve started building the release with multiple JDK versions.

For every version I ran “mvn clean install -Pallblocks,alldists”:

  *   Java 1.8 didn’t work, as some libraries now baseline with Java 11
  *   Java 11: OK
  *   Java 17: OK
  *   Java 21: OK

Having a look at my JDKs I never found a tools.jar in the lib directory.
However, having a look at the XSP module I found out the dependency is only 
added for non-mac builds (Obviously me building on a Mac isn’t affected).

However, looking at the windows jdk zips of Java 1.8, 11, 17 and 21 it seems 
only Java 1.8 had the tools.jar.
I removed the profile of the tools.jar in XSP module and was successful 
building cocoon with Java 11, 17 and 21 on Mac, Windows, Linux (yeah … I tried 
all of them)

After that I tried making the build work with Java 1.8 and had to find out the 
last version supporting 1.8 for two libraries.
I added a profile “.java-1.8” which auto-enables on Java 1.8 systems.
With these changes we’re also able to build on Java 1.8 on Linux, Mac and 
Windows.

Maybe worth doing an RC2 as as it looks building currently only works on Mac 
11, 17, 21 and nothing else.

Chris


Von: Cédric Damioli <cdami...@apache.org>
Datum: Freitag, 27. Oktober 2023 um 11:18
An: dev@cocoon.apache.org <dev@cocoon.apache.org>
Betreff: Re: [VOTE] Apache Cocoon 2.3.0 RC1
Hi Christofer,

First of all, many thanks for the huge work you made so far for helping us 
finally rolling out a release.

Which is the target JVM for this release ?
On my Windows laptop, I can't compile with JDK 8, due to external dependencies 
being only JDK11+
And I also can't compile with JDK11+, due to XSP block complaining that it 
can't find tools.jar

Cédric
Le 24/10/2023 à 20:50, Christofer Dutz a écrit :
Apache Cocoon 2.3.0 has been staged under [2] and it’s time to vote
on accepting it for release. All Maven artifacts are available under [1].
Voting will be open for 72hr.

A minimum of 3 binding +1 votes and more binding +1 than binding -1
are required to pass.

Release tag: 
https://svn.apache.org/viewvc/cocoon/tags/cocoon-2.3/cocoon/cocoon-2.3.0/
Director revision of the tag: 1913280

Per [3] "Before voting +1 PMC members are required to download
the signed source code package, compile it as provided, and test
the resulting executable on their own platform, along with also
verifying that the package meets the requirements of the ASF policy
on releases."

You can achieve the above by following the guide of a fellow Apache project [4].

[ ]  +1 accept (indicate what you validated - e.g. performed the non-RM items 
in [4])
[ ]  -1 reject (explanation required)


[1] https://repository.apache.org/content/repositories/orgapachecocoon-1006
[2] https://dist.apache.org/repos/dist/dev/cocoon/2.3.0/rc1/
[3] https://www.apache.org/dev/release.html#approving-a-release
[4] 
https://cwiki.apache.org/confluence/display/PLC4X/Validating+a+staged+Release




--

Cédric Damioli

CMS - Java - Open Source

www.ametys.org<http://www.ametys.org>

Reply via email to